From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:36018) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jFnId-00072V-Jc for guix-patches@gnu.org; Sat, 21 Mar 2020 19:13:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jFnIc-0004d3-AP for guix-patches@gnu.org; Sat, 21 Mar 2020 19:13:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42454) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jFnIb-0004cv-UP for guix-patches@gnu.org; Sat, 21 Mar 2020 19:13:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jFnIb-0005wx-Qn for guix-patches@gnu.org; Sat, 21 Mar 2020 19:13:01 -0400 Subject: [bug#40128] [PATCH 1/2] gnu: Add emacs-pretty-hydra. Resent-Message-ID: References: <871rpoq4tj.fsf@lafreniere.xyz> <87fte18xyz.fsf@nicolasgoaziou.fr> From: "LaFreniere, Joseph" In-reply-to: <87fte18xyz.fsf@nicolasgoaziou.fr> Date: Sat, 21 Mar 2020 18:12:34 -0500 Message-ID: <87wo7dl2u5.fsf@lafreniere.xyz> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Nicolas Goaziou Cc: 40128@debbugs.gnu.org --=-=-= Content-Type: text/plain; format=flowed Nicolas Goaziou writes: >> As noted in the description, this package is not intended for >> use by >> end-users. Is there a convention for communicating that? > > I think specifying it in the description is the correct way. Noted. >> + (propagated-inputs >> + `(("emacs-hydra" ,emacs-hydra) >> + ("emacs-s" ,emacs-s) >> + ("emacs-dash" ,emacs-dash))) > > Could you re-order them alphabetically? Done. >> + (arguments >> + `(#:phases >> + (modify-phases %standard-phases >> + (add-before 'add-source-to-load-path >> 'remove-pretty-hydra >> + (lambda* (#:key outputs #:allow-other-keys) >> + ;; major-mode-hydra is packaged separately. >> + (delete-file "major-mode-hydra.el") >> + #t))))) > > You can use #:exclude keyword from the Emacs build system > instead. Thanks for the tip! > Could you send an updated patch? Patch file is attached. -- Joseph LaFreniere --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-gnu-Add-emacs-pretty-hydra.patch >From bd33f91c6d1b69d9951e9c338b36c92328eb3555 Mon Sep 17 00:00:00 2001 From: Joseph LaFreniere Date: Wed, 18 Mar 2020 20:59:49 -0500 Subject: [PATCH 1/2] gnu: Add emacs-pretty-hydra. * gnu/packages/emacs-xyz.scm (emacs-pretty-hydra): New variable. --- gnu/packages/emacs-xyz.scm | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 1ea3155807..50eec6d516 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -5486,6 +5486,34 @@ the Hydra very seamless; it's like a minor mode that disables itself automatically.") (license license:gpl3+))) +(define-public emacs-pretty-hydra + (package + (name "emacs-pretty-hydra") + (version "0.2.2") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/jerrypnz/major-mode-hydra.el.git") + (commit version))) + (sha256 + (base32 + "08a15knkdq35pzjq82imff016fbfdib5q4glg2xmdy2b5fnk7jqa")))) + (build-system emacs-build-system) + (propagated-inputs + `(("emacs-dash" ,emacs-dash) + ("emacs-hydra" ,emacs-hydra) + ("emacs-s" ,emacs-s))) + (arguments + `(#:exclude (cons "^major-mode-hydra\\.el" %default-exclude))) + (home-page "https://github.com/jerrypnz/major-mode-hydra.el") + (synopsis "Major mode keybindings managed by Hydra") + (description + "This package offers an hydra-based method of managing major +mode-specific key bindings. It is intended for use as a library only; see +package @code{emacs-major-mode-hydra} for a user-friendly interface.") + (license license:gpl3+))) + (define-public emacs-ivy (package (name "emacs-ivy") -- 2.25.1 --=-=-=--