From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:39182) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jItaF-0007DG-1o for guix-patches@gnu.org; Mon, 30 Mar 2020 08:32:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jItaD-00040e-U3 for guix-patches@gnu.org; Mon, 30 Mar 2020 08:32:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49549) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jItaD-00040I-Q6 for guix-patches@gnu.org; Mon, 30 Mar 2020 08:32:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jItaD-0008OK-Jx for guix-patches@gnu.org; Mon, 30 Mar 2020 08:32:01 -0400 Subject: [bug#40289] [PATCH] games.scm: add "neverball" and "neverputt" (bundled together) Resent-Message-ID: Received: from eggs.gnu.org ([2001:470:142:3::10]:39074) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jItZa-0006RZ-So for guix-patches@gnu.org; Mon, 30 Mar 2020 08:31:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jItZZ-0003S6-HI for guix-patches@gnu.org; Mon, 30 Mar 2020 08:31:22 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:58007) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jItZZ-0003RN-BP for guix-patches@gnu.org; Mon, 30 Mar 2020 08:31:21 -0400 From: Nicolas Goaziou References: Date: Mon, 30 Mar 2020 14:31:16 +0200 In-Reply-To: (Vitaliy Shatrov via Guix-patches via's message of "Sat, 28 Mar 2020 17:37:16 +0000") Message-ID: <87wo7281nv.fsf@nicolasgoaziou.fr> MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 40289@debbugs.gnu.org Cc: D0dyBo0D0dyBo0@protonmail.com Hello, Vitaliy Shatrov via Guix-patches via writes: > gnu/packages/games.scm: > Added: > * a game neverball and it's "addon", neverputt. > * the #:use-module "copy-build-system". Thank you! Somme comments follow > Subject: [PATCH] games.scm: add "neverball" and "neverputt" (bundled > together). > > gnu/packages/games.scm: > Added: > * a game neverball and it's "addon", neverputt. > * the #:use-module "copy-build-system". The commit message should be gnu: Add neverball * gnu/packages/games.scm (neverball): New variable. That's it. > + (source (origin Nitpick: I suggest to move `origin' on the line below `source'. > + ;; Debian doesn't strip it, though. i'm dummy > + (delete-file-recursively "data/ball/octocat")) Usually, we would delete it in a snippet so "guix build -S neverball" returns source without the problematic part. Could you do it? > + (add-after 'install 'install-icons Could this be moved within the install plan? > + (description > + "Also included is Neverputt, which is a 3D miniature golf > game. The first sentence should be complete. > +In the grand tradition of Marble Madness and Super Monkey Ball, > +Neverball has you guide a rolling ball through dangerous territory. > +Balance on narrow bridges, navigate mazes, ride moving platforms, and > +dodge pushers and shovers to get to the goal. Race against the clock to > +collect coins to earn extra balls.") ;; mouse on sway cause crash The last comment seems out of place. This may need to be reported upstream instead. Also, note that end of line comments are expected to start with a single semicolon. Double semicolon comments start at the beginning of the line instead. Regards, -- Nicolas Goaziou