From: Tobias Geerinckx-Rice via Guix-patches via <guix-patches@gnu.org>
To: 40635@debbugs.gnu.org
Subject: [bug#40635] [PATCH] gnu: Add emacs-moody.
Date: Wed, 15 Apr 2020 23:18:26 +0200 [thread overview]
Message-ID: <87wo6gzbvh.fsf@nckx> (raw)
In-Reply-To: <20200415050447.14598-1-barbanegra+guix@posteo.mx>
[-- Attachment #1: Type: text/plain, Size: 3196 bytes --]
Alberto,
Alberto Eleuterio Flores Guerrero 写道:
> * gnu/packages/emacs-xyz.scm (emacs-moody): New variable.
> ---
> gnu/packages/emacs-xyz.scm | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/gnu/packages/emacs-xyz.scm
> b/gnu/packages/emacs-xyz.scm
> index a9550ee112..364cec47da 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -507,6 +507,33 @@ Alternatively the menu can be bound
> globally, for example:
> @code{(global-set-key [S-down-mouse-3]
> 'minions-minor-modes-menu)}.")
> (license license:gpl3+)))
>
> +(define-public emacs-moody
> + (let ((commit "2751d36152abcc2ac1479225392182b53f1e02dd")
> + (revision "1"))
There's a ‘v0.5.3’ tag so we can just use that:
(version "0.5.3")
(source
(origin
(method git-fetch)
(uri (git-reference
(url "https://…")
;; ‘Commit’ can really be any git identifier.
(commit (string-append "v" version))))
…))
and drop the (let …).
> + (package
> + (name "emacs-moody")
> + ;; version 4.0 is a bit old (2018)
Nitpick: ;;-comments are sentences, so capitalise and end with a
full stop.
However, IMO no comment is needed. The top release at
<https://github.com/tarsius/moody/releases> is 0.5.3, and I've
grown to ignore the ‘latest release’ badge on GitHub unless there
are reasons not to. Too many upstreams forget to move it.
> + (version (git-version "0.5.3" revision commit))
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url
> "https://github.com/tarsius/moody.git")
> + (commit commit)))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> +
> "1xyw4l42053595r76lj8safsx6pj25as0107wd96by3h7dg9m586"))))
> + (build-system emacs-build-system)
> + (home-page "https://github.com/tarsius/moody")
> + (synopsis "Tabs and ribbons for Emacs mode-line")
More nitpicks: ‘…the Emacs mode line’.
> + (description
> + "@code{emacs-moody} provides utilities for displaying
> elements of
> +the mode line as tabs and ribbons. It also provides
> replacements for a few
> +built-in elements. The biggest differences to similar packages
> is that
‘…difference[singular] with…’.
> +this one is much simpler and much more consistent. When using
> this package,
I don't know enough about other extensions to judge whether that's
true, so I'll give it the benefit of the doubt.
In general: feel free to remove content-free marketing from
upstream descriptions.
> +then only the color of the mode line changes when a window
> becomes in-/active.")
You can drop ‘then’ here. I'd write ‘(in)active’ but that might
be purely a matter of taste.
No need to send an updated patch; I'll make above changes and push
if that's all right with you. I might give others time to chime
in if I'm feeling laz^Wgenerous.
Kind regards,
T G-R
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2020-04-15 21:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 5:04 [bug#40635] [PATCH] gnu: Add emacs-moody Alberto Eleuterio Flores Guerrero
2020-04-15 21:18 ` Tobias Geerinckx-Rice via Guix-patches via [this message]
2020-09-10 6:50 ` bug#40635: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wo6gzbvh.fsf@nckx \
--to=guix-patches@gnu.org \
--cc=40635@debbugs.gnu.org \
--cc=me@tobias.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).