From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id qJMBNnxx7F7aEgAA0tVLHw (envelope-from ) for ; Fri, 19 Jun 2020 08:04:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id KAy9MXxx7F7NZgAAbx9fmQ (envelope-from ) for ; Fri, 19 Jun 2020 08:04:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 753649401CB for ; Fri, 19 Jun 2020 08:04:12 +0000 (UTC) Received: from localhost ([::1]:35288 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jmC0Q-0004a8-Gn for larch@yhetil.org; Fri, 19 Jun 2020 04:04:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47622) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jmC0I-0004Y6-Dz for guix-patches@gnu.org; Fri, 19 Jun 2020 04:04:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:43515) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jmC0I-0007yN-4Y for guix-patches@gnu.org; Fri, 19 Jun 2020 04:04:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jmC0H-0004fr-Vq for guix-patches@gnu.org; Fri, 19 Jun 2020 04:04:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41855] [PATCH 1/2] hurd-boot: Create individual translators instead of running MAKEDEV. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 19 Jun 2020 08:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41855 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jan Nieuwenhuizen Cc: 41855@debbugs.gnu.org Received: via spool by 41855-submit@debbugs.gnu.org id=B41855.159255381517927 (code B ref 41855); Fri, 19 Jun 2020 08:04:01 +0000 Received: (at 41855) by debbugs.gnu.org; 19 Jun 2020 08:03:35 +0000 Received: from localhost ([127.0.0.1]:55061 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jmBzr-0004f5-1U for submit@debbugs.gnu.org; Fri, 19 Jun 2020 04:03:35 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33182) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jmBzp-0004eq-QX for 41855@debbugs.gnu.org; Fri, 19 Jun 2020 04:03:34 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57735) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jmBzj-0007vs-Kw; Fri, 19 Jun 2020 04:03:27 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=37272 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jmBzi-00046D-Qd; Fri, 19 Jun 2020 04:03:27 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200614165430.3411-1-janneke@gnu.org> <20200614165649.3496-1-janneke@gnu.org> <87imfsyuib.fsf@gnu.org> <87y2omyap0.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 2 Messidor an 228 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 19 Jun 2020 10:03:25 +0200 In-Reply-To: <87y2omyap0.fsf@gnu.org> (Jan Nieuwenhuizen's message of "Tue, 16 Jun 2020 23:15:07 +0200") Message-ID: <87wo43h48i.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: bG6pCZI4Xj4A Hi, Jan Nieuwenhuizen skribis: >> It=E2=80=99s counter-intuitive that hurd-boot.scm is used from GNU/Linux. >> Should we move the shared bits in (gnu build hurd) or similar? > > Maybe...I don't know. hurd-boot defines functions that are needed to > create a bootable hurd -- some can be called from GNU/Linux. > > Similarly, "linux-boot" defines "make-essential-device-nodes", which > could be called from GNU/Hurd when we cross build a linux VM. Right. > Well, having one weird situation is a bad argument to propagate the > madness. > > I guess it makes sense to move utility functions like > passive-translator-xattr, passive-translator-installed?, and translated? > could be moved to (gnu build hurd). > > Haven't made this change yet, let me know you want; or feel free to make > the change yourself :-) Yeah, we can leave that for later. :-) > From 1e27aabb8bf32e85547517e1f0e35f789a08933d Mon Sep 17 00:00:00 2001 > From: "Jan (janneke) Nieuwenhuizen" > Date: Mon, 8 Jun 2020 13:02:13 +0200 > Subject: [PATCH v2 1/2] hurd-boot: Create individual translators instead = of > running MAKEDEV. > > * guix/build/utils.scm Something=E2=80=99s wrong! > * gnu/build/hurd-boot.scm (make-hurd-device-nodes): Do not create > dev/{null,zero,full,random,urandom} mount points. > (passive-translator-xattr?, passive-translator-installed?, translated?, > set-hurd-device-translators): New procedures. > (false-if-EEXIST): New macro. > (boot-hurd-system): Use them instead of running MAKEDEV. [...] > +(define* (set-translator! file-name command #:optional (mode #o600)) Nitpick: there shouldn=E2=80=99t be a bang here (just like for =E2=80=98mkd= ir=E2=80=99, etc.). Otherwise LGTM, thank you! Ludo=E2=80=99.