unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Oleg Pykhalov <go.wigust@gmail.com>
To: Joseph LaFreniere <joseph@lafreniere.xyz>
Cc: 42525@debbugs.gnu.org
Subject: [bug#42525] [PATCH 2/2] gnu: Add emacs-major-mode-hydra.
Date: Sat, 25 Jul 2020 16:28:08 +0300	[thread overview]
Message-ID: <87wo2rlo5z.fsf@gmail.com> (raw)
In-Reply-To: <87lfj8gx9q.fsf@odyssey.lafreniere.xyz> (Joseph LaFreniere's message of "Fri, 24 Jul 2020 21:10:25 -0500")

[-- Attachment #1: Type: text/plain, Size: 1116 bytes --]

Joseph LaFreniere <joseph@lafreniere.xyz> writes:

> Patch file is attached.  Similar to the first patch in this series, `guix
> lint` reports "the source file name should contain the package name".

Yes, because emacs-major-mode-hydra inherits emacs-pretty-hydra.


Does emacs-major-mode-hydra is useful without emacs-pretty-hydra and
vice versa?

I guess not, in that case we could just have emacs-pretty-hydra
containing '*.el' for both.

[…]

> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 147c6b476b..649f856a83 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -677,6 +677,20 @@ mode-specific key bindings.  It is intended for use as a library only; see
>  package @code{emacs-major-mode-hydra} for a user-friendly interface.")
>      (license license:gpl3+)))
>  
> +(define-public emacs-major-mode-hydra
> +  (package
> +    ...
> +    (arguments
> +     `(#:include '("^major-mode-hydra\\.el$")))
> +    (synopsis "Create nice-looking hydras")

Could you extend the synopsis little bit? ;-)

Thanks,
Oleg.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  reply	other threads:[~2020-07-25 13:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-25  2:04 [bug#42525] [PATCH 1/2] gnu: Add emacs-pretty-hydra Joseph LaFreniere
2020-07-25  2:10 ` [bug#42525] [PATCH 2/2] gnu: Add emacs-major-mode-hydra Joseph LaFreniere
2020-07-25 13:28   ` Oleg Pykhalov [this message]
2020-07-25 15:02     ` LaFreniere, Joseph
2020-12-18 13:24       ` bug#42525: " Ludovic Courtès
2020-07-25 13:20 ` [bug#42525] [PATCH 1/2] gnu: Add emacs-pretty-hydra Oleg Pykhalov
2020-07-25 14:57   ` LaFreniere, Joseph
2020-07-25 15:05     ` LaFreniere, Joseph
2020-07-25 18:34     ` Oleg Pykhalov
2020-07-26 14:04 ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wo2rlo5z.fsf@gmail.com \
    --to=go.wigust@gmail.com \
    --cc=42525@debbugs.gnu.org \
    --cc=joseph@lafreniere.xyz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).