From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id uAElCGkDTF9ifAAA0tVLHw (envelope-from ) for ; Sun, 30 Aug 2020 19:52:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id mNr3A2kDTF+WawAA1q6Kng (envelope-from ) for ; Sun, 30 Aug 2020 19:52:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AB0BB94053E for ; Sun, 30 Aug 2020 19:52:08 +0000 (UTC) Received: from localhost ([::1]:60126 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kCTN1-0005gh-Ka for larch@yhetil.org; Sun, 30 Aug 2020 15:52:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39106) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kCTMw-0005ga-03 for guix-patches@gnu.org; Sun, 30 Aug 2020 15:52:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39260) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kCTMv-0007Pt-NQ for guix-patches@gnu.org; Sun, 30 Aug 2020 15:52:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kCTMv-0005fS-Mu for guix-patches@gnu.org; Sun, 30 Aug 2020 15:52:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42849] [PATCH 1/3] install: Factorize cow-store procedure. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 30 Aug 2020 19:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42849 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mathieu Othacehe Cc: 42849@debbugs.gnu.org Received: via spool by 42849-submit@debbugs.gnu.org id=B42849.159881711321771 (code B ref 42849); Sun, 30 Aug 2020 19:52:01 +0000 Received: (at 42849) by debbugs.gnu.org; 30 Aug 2020 19:51:53 +0000 Received: from localhost ([127.0.0.1]:50806 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCTMn-0005f5-2F for submit@debbugs.gnu.org; Sun, 30 Aug 2020 15:51:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57202) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCTMl-0005et-LZ for 42849@debbugs.gnu.org; Sun, 30 Aug 2020 15:51:52 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44176) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kCTMg-0007PT-Cg for 42849@debbugs.gnu.org; Sun, 30 Aug 2020 15:51:46 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=43516 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kCTMf-0006NO-Fn; Sun, 30 Aug 2020 15:51:45 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200813122323.262805-1-othacehe@gnu.org> <20200813123419.263639-1-othacehe@gnu.org> Date: Sun, 30 Aug 2020 21:51:44 +0200 In-Reply-To: <20200813123419.263639-1-othacehe@gnu.org> (Mathieu Othacehe's message of "Thu, 13 Aug 2020 14:34:17 +0200") Message-ID: <87wo1fhpyn.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: Dj6PQKZBO1px Hi! Mathieu Othacehe skribis: > Move the cow-store procedure from the service declaration in (gnu system > install) to (gnu build install), so that it can be called from within a > different context than Shepherd. > > * gnu/build/install.scm (mount-cow-store, umount-cow-store): New procedur= es. > * gnu/system/install.scm (make-cow-store): Remove it, > (cow-store-service-type): adapt it accordingly. Nitpick: Unlike K&R back then, I think we can afford the =E2=80=98n=E2=80= =99 in =E2=80=98unmount=E2=80=99. :-) Other than that LGTM! Ludo=E2=80=99.