From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id UHA5Geu6jF9HTwAA0tVLHw (envelope-from ) for ; Sun, 18 Oct 2020 22:00:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id oHSGFOu6jF+0cQAAbx9fmQ (envelope-from ) for ; Sun, 18 Oct 2020 22:00:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0BA1694042A for ; Sun, 18 Oct 2020 22:00:11 +0000 (UTC) Received: from localhost ([::1]:45832 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUGin-0000qq-VB for larch@yhetil.org; Sun, 18 Oct 2020 18:00:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51710) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUGig-0000qT-OB for guix-patches@gnu.org; Sun, 18 Oct 2020 18:00:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55916) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kUGig-0002ZY-Dl for guix-patches@gnu.org; Sun, 18 Oct 2020 18:00:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kUGig-0006Dn-DG for guix-patches@gnu.org; Sun, 18 Oct 2020 18:00:02 -0400 Subject: bug#43883: [PATCH] gnu: Add libebur128. Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Sun, 18 Oct 2020 22:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 43883 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Vinicius Monego Cc: 43883-done@debbugs.gnu.org Mail-Followup-To: 43883@debbugs.gnu.org, marius@gnu.org, monego@posteo.net Received: via spool by 43883-done@debbugs.gnu.org id=D43883.160305839323862 (code D ref 43883); Sun, 18 Oct 2020 22:00:02 +0000 Received: (at 43883-done) by debbugs.gnu.org; 18 Oct 2020 21:59:53 +0000 Received: from localhost ([127.0.0.1]:39228 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUGiS-0006Ck-TJ for submit@debbugs.gnu.org; Sun, 18 Oct 2020 17:59:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44852) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUGiR-0006CY-CP for 43883-done@debbugs.gnu.org; Sun, 18 Oct 2020 17:59:47 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50592) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUGiM-0002WV-1s; Sun, 18 Oct 2020 17:59:42 -0400 Received: from ti0006q161-1594.bb.online.no ([46.9.75.77]:36556 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kUGiK-0006uL-Fr; Sun, 18 Oct 2020 17:59:41 -0400 From: Marius Bakke In-Reply-To: <87imbb11s3.fsf@posteo.net> References: <20201009151256.7949-1-monego@posteo.net> <87imbdrfo7.fsf@gnu.org> <87imbb11s3.fsf@posteo.net> Date: Sun, 18 Oct 2020 23:59:38 +0200 Message-ID: <87wnznjiut.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.11 X-TUID: 3WviETVS+/Jp --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Vinicius Monego writes: > Marius Bakke writes: > >> Vinicius Monego writes: >> >>> * gnu/packages/audio.scm (libebur128): New variable. >> >> [...] >>=20=20=20 >>> + (arguments >>> + `(;; Tests require .wav files that are not distributed with the c= ode. >>> + ;; See https://github.com/jiixyj/libebur128/issues/82. >>> + #:tests? #f >> >> It is easy to provide these data files using an (origin ...) in >> native-inputs, like e.g. 'json-modern-cxx'. Obviously we should check >> the terms of use first, as the data set is unrelated to this package. >> >> (I don't really have a strong opinion here, just sayin') >> > > I had a look at the terms (link provided in the issue referenced above) > and commercial usage is forbidden, making the audio files nonfree. Also, = the > zip file weighs 87 MB. Oh, thanks for checking, too bad. >>> + #:configure-flags '("-DCMAKE_BUILD_TYPE=3DRelease" >> >> Note: you can use #:build-type "Release" instead. The default is >> "RelWithDebInfo", so it's customary to add a comment when changing it. >> Is there a particular reason to not provide debugging information here? > > Oh, I wasn't aware of #:build-type. Thanks. > > I remove debugging information to save space. The ideal case is to move > it to a separate output as in > > https://guix.gnu.org/manual/en/html_node/Installing-Debugging-Files.html > > , but that is something I have yet to take a look at. > > I will enable it again in the v2 and add a comment about the data. Excellent, applied! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFDBAEBCgAtFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl+MusoPHG1hcml1c0Bn bnUub3JnAAoJEKKgbfKjOlT65sgH/2ZKf2VYiif1LjicjLlaTELTDZojHS5CyOIS 1UNsj/6X94NcgqGiroF3N0SuVGNIRy7kfnar11YBZNu+T0qB9F7TdAXNURJ8G7Y4 SlCMxSOxpzTaZyT2iov8dYhdPZwkKtJCcsXFW0xO9kmeLXhwS89a6zUKxbefSihU JKl4IWSlVl71dJJt7k+w8XuONv1QJPmdosRYPCSQcWrDhtVPz7xceNGonyfgp8am 5g7vyt15qDjkKfumCYTmE64HK110EbBfX8jwJ/OCYfeIBMZQSi137ZFv4l6jEBOF JdL8OyzZD88TOXeUAD5oexVeqOLqWqEwZyHaNdn21GIdaEucD0o= =naON -----END PGP SIGNATURE----- --=-=-=--