unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Miguel Ángel Arruga Vivas" <rosen644835@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 44321@debbugs.gnu.org
Subject: [bug#44321] [PATCH 3/6] guix build: 'options->transformation' no longer takes a 'store' parameter.
Date: Fri, 30 Oct 2020 23:27:29 +0100	[thread overview]
Message-ID: <87wnz74aem.fsf@gmail.com> (raw)
In-Reply-To: <20201029231000.14568-3-ludo@gnu.org> ("Ludovic Courtès"'s message of "Fri, 30 Oct 2020 00:09:57 +0100")

[-- Attachment #1: Type: text/plain, Size: 1447 bytes --]

Hi Ludo,

I just have one comment here:

Ludovic Courtès <ludo@gnu.org> writes:
> ("options->transformation, with-source")
> ("options->transformation, with-source, replacement")
> ("options->transformation, with-source, with version")
> ("options->transformation, with-source, PKG=URI"): Use 'lower-object' to
> compute the store file name of the source.
[...]
> @@ -64,12 +66,9 @@
>    (let* ((p (dummy-package "guix.scm" (replacement coreutils)))
>           (s (search-path %load-path "guix.scm"))
>           (t (options->transformation `((with-source . ,s)))))
> -    (with-store store
> -      (let ((new (t store p)))
> -        (and (not (eq? new p))
> -             (string=? (package-source new)
> -                       (add-to-store store "guix.scm" #t "sha256" s))
> -             (not (package-replacement new)))))))
> +    (let ((new (t p)))
> +      (and (not (eq? new p))
> +           (not (package-replacement new))))))
>  
>  (test-assert "options->transformation, with-source, with version"
>    ;; Our pseudo-package is called 'guix.scm' so the 'guix.scm-2.0' source

It's the only one that doesn't follow the same pattern as others, where
the change look quite similar: instead of (t store p) -> (t p) (source
(run-...)), also specified in the message.

If removing that comparison is intended, I think the commit message
should be changed.  Otherwise it LGTM.

Happy hacking!
Miguel

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 658 bytes --]

  reply	other threads:[~2020-10-30 22:28 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-29 23:08 [bug#44321] [PATCH 0/6] Adding a (guix transformations) module Ludovic Courtès
2020-10-29 23:09 ` [bug#44321] [PATCH 1/6] guix build: 'package-with-source' no longer takes a 'store' parameter Ludovic Courtès
2020-10-29 23:09   ` [bug#44321] [PATCH 2/6] guix build: Remove unnecessary (replacement #f) Ludovic Courtès
2020-10-29 23:09   ` [bug#44321] [PATCH 3/6] guix build: 'options->transformation' no longer takes a 'store' parameter Ludovic Courtès
2020-10-30 22:27     ` Miguel Ángel Arruga Vivas [this message]
2020-10-31 10:03       ` Ludovic Courtès
2020-10-29 23:09   ` [bug#44321] [PATCH 4/6] guix build: Move transformation options to (guix transformations) Ludovic Courtès
2020-10-30 23:03     ` Miguel Ángel Arruga Vivas
2020-10-31 10:04       ` Ludovic Courtès
2020-10-29 23:09   ` [bug#44321] [PATCH 5/6] transformations: Raise '&formatted-message' exceptions instead of 'leave' Ludovic Courtès
2020-10-30 10:59     ` zimoun
2020-10-30 22:39       ` Miguel Ángel Arruga Vivas
2020-10-31 10:06         ` Ludovic Courtès
2020-10-31 22:18           ` bug#44321: " Ludovic Courtès
2020-11-02 12:25           ` [bug#44321] " zimoun
2020-11-02 15:48             ` Ludovic Courtès
2020-10-29 23:10   ` [bug#44321] [PATCH 6/6] doc: Add "Defining Package Variants" section Ludovic Courtès
2020-10-30 11:20     ` zimoun
2020-10-31 10:14       ` Ludovic Courtès
2020-10-30 23:27   ` [bug#44321] [PATCH 1/6] guix build: 'package-with-source' no longer takes a 'store' parameter Miguel Ángel Arruga Vivas
2020-10-31 10:17     ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wnz74aem.fsf@gmail.com \
    --to=rosen644835@gmail.com \
    --cc=44321@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).