unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Chris Marusich <cmmarusich@gmail.com>
Cc: 41845-done@debbugs.gnu.org
Subject: bug#41845: [PATCH] tests: lint: Add origin patch file name test cases.
Date: Mon, 07 Dec 2020 12:50:47 +0100	[thread overview]
Message-ID: <87wnxtzvfs.fsf@gnu.org> (raw)
In-Reply-To: <871rmhtm0a.fsf@gnu.org> ("Ludovic Courtès"'s message of "Sun, 14 Jun 2020 22:45:09 +0200")

Hi Chris,

Ludovic Courtès <ludo@gnu.org> skribis:

> Chris Marusich <cmmarusich@gmail.com> skribis:
>
>> From 5fa2156f8561afb87d7f9a63de0243334e9da53b Mon Sep 17 00:00:00 2001
>> From: Chris Marusich <cmmarusich@gmail.com>
>> Date: Sat, 13 Jun 2020 22:09:46 -0700
>> Subject: [PATCH] tests: lint: Add origin patch file name test cases.
>>
>> In particular, "<origin> patches: same file name -> no warnings" would
>> have caught the issue which was fixed in commit
>> 21887021b9acf60157b1b0a39c16f2ec6498021b.
>>
>> * tests/lint.scm (patches: file names): Rename this test case...
>> ("file patches: different file name -> warning"): ... to this.
>> ("file patches: same file name -> no warnings")
>> ("<origin> patches: different file name -> warning")
>> ("<origin> patches: same file name -> no warnings"): New test cases.
>
> LGTM.  Thanks for taking the time to write these tests!

I went ahead and pushed it as d8ae7852057d5c1818c9c8bb77e8c41407a0d985.

Thanks,
Ludo’.




      reply	other threads:[~2020-12-07 13:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-14  5:34 [bug#41845] [PATCH] tests: lint: Add origin patch file name test cases Chris Marusich
2020-06-14 20:45 ` Ludovic Courtès
2020-12-07 11:50   ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wnxtzvfs.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=41845-done@debbugs.gnu.org \
    --cc=cmmarusich@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).