unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: "Nicolò Balzarotti" <anothersms@gmail.com>
Cc: 45972@debbugs.gnu.org
Subject: [bug#45972] [PATCH] Add julia-json with dependencies
Date: Tue, 26 Jan 2021 22:33:37 +0100	[thread overview]
Message-ID: <87wnvzwfgu.fsf@gnu.org> (raw)
In-Reply-To: <87ft2xzu1g.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> ("Nicolò Balzarotti"'s message of "Tue, 19 Jan 2021 00:47:55 +0100")

Hi Nicolò,

Nicolò Balzarotti <anothersms@gmail.com> skribis:

> This patch series adds julia-json together with its dependencies.

Neat.  I looked at it quickly and it LGTM.  Nitpicks:

> +    (synopsis "Julia implementation of associative containers that preserve
> +insertion order")

Maybe remove “Julia implementation of”.

> +    (description "This package implements OrderedDicts and OrderedSets, which

Ideally use @code for identifiers.

> +    (synopsis "Fixed point types for julia")

s/julia/Julia/

> +    (synopsis "JSON parsing and printing")
> +    (description "Parsing and printing JSON in pure Julia.")

Please make that a full sentence.

If you’re confident with the licenses and ‘guix lint’ is happy,
please push!  Nice to see more Julia packages.

Ludo’.




  reply	other threads:[~2021-01-26 21:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-18 23:47 [bug#45972] [PATCH] Add julia-json with dependencies Nicolò Balzarotti
2021-01-26 21:33 ` Ludovic Courtès [this message]
2021-01-26 23:23   ` Nicolò Balzarotti
2021-01-27 22:40     ` Ludovic Courtès
2021-01-28  0:30       ` Nicolò Balzarotti
2021-01-28 13:10         ` Ludovic Courtès
2021-01-28 15:37           ` Nicolò Balzarotti
2021-01-30 14:10             ` bug#45972: " Ludovic Courtès
2021-01-30 14:46         ` [bug#45972] Julia importer? zimoun
2021-01-30 20:13           ` Nicolò Balzarotti
2021-01-30 21:42             ` Nicolò Balzarotti
2021-01-31 19:35             ` zimoun
2021-01-31 20:00               ` Nicolò Balzarotti
2021-02-01  7:22                 ` zimoun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wnvzwfgu.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=45972@debbugs.gnu.org \
    --cc=anothersms@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).