From: Kyle Meyer <kyle@kyleam.com>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 46866@debbugs.gnu.org
Subject: [bug#46866] [PATCH] gnu: b4: Fix setup.py version incompatibility.
Date: Tue, 09 Mar 2021 17:54:04 -0500 [thread overview]
Message-ID: <87wnugym43.fsf@kyleam.com> (raw)
In-Reply-To: <YEctPxAc/y/aIcet@3900XT>
Efraim Flashner writes:
> Indeed, it does fail at startup. Two things about your patch, you've
> added a patch file but didn't register it in gnu/local.mk. This means
> it'll get dropped during a 'make dist' which would be a problem.
Doh, thanks for catching that.
> The second is that it's a lot of patch for a small amount of code
> change.
I like that a patch fails loudly once it's no longer valid, but I'm
happy to defer to your opinion that it's an overkill here (and will try
to recalibrate for future patches).
> With your permission I'd like to commit the attached patch instead.
[...]
> From: Kyle Meyer <kyle@kyleam.com>
> Date: Tue, 9 Mar 2021 10:06:13 +0200
> Subject: [PATCH] gnu: b4: Fix setup.py version incompatibility.
>
> * gnu/packages/version-control.scm (b4)[source]: Add snippet to not
> require too specific of a version.
>
> Co-authored with Efraim Flashner <efraim@flashner.co.il>
>
> Signed-off-by: Efraim Flashner <efraim@flashner.co.il>
Sounds fine to me. I have a slight preference that you put yourself as
the author and put a
Noticed-by: Kyle Meyer <kyle@kyleam.com>
or
Reported-by: Kyle Meyer <kyle@kyleam.com>
trailer for me, but either way is okay.
> @@ -2347,7 +2347,15 @@ based on a manifest file published by servers.")
> (method url-fetch)
> (uri (pypi-uri "b4" version))
> (sha256
> - (base32 "1j904dy9cwxl85k2ngc498q5cdnqwsmw3jibjr1m55w8aqdck68z"))))
> + (base32 "1j904dy9cwxl85k2ngc498q5cdnqwsmw3jibjr1m55w8aqdck68z"))
> + (modules '((guix build utils)))
> + (snippet
> + '(begin
> + ;; Fixes issue with dependency requirements being too strict. See upstream commit:
> + ;; https://git.kernel.org/pub/scm/utils/b4/b4.git/commit/?id=31348a14afdb1d39e7faf9576eaddea1ced76e19
> + (substitute* "setup.py"
> + (("\\.0'") "'"))
Just a note: This won't catch a similar problem if dkimpy (1.0.5) is
upgraded before b4, though perhaps that's unlikely and not worth
worrying about.
Thank you for the review.
next prev parent reply other threads:[~2021-03-09 22:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-02 1:51 [bug#46866] [PATCH] gnu: b4: Fix setup.py version incompatibility Kyle Meyer
2021-03-09 8:09 ` Efraim Flashner
2021-03-09 22:54 ` Kyle Meyer [this message]
2021-03-16 12:29 ` bug#46866: " Efraim Flashner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wnugym43.fsf@kyleam.com \
--to=kyle@kyleam.com \
--cc=46866@debbugs.gnu.org \
--cc=efraim@flashner.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).