unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Simon Streit <simon@netpanic.org>
Cc: 48027@debbugs.gnu.org
Subject: [bug#48027] [PATCH] gnu: Add volctl.
Date: Mon, 03 May 2021 23:09:22 +0200	[thread overview]
Message-ID: <87wnsftth9.fsf@gnu.org> (raw)
In-Reply-To: <yguv989mptv.fsf@netpanic.org> (Simon Streit's message of "Mon, 26 Apr 2021 09:00:30 +0200")

Hi Simon,

Simon Streit <simon@netpanic.org> skribis:

> * gnu/packages/gtk.scm: New Variable.

[...]

> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://github.com/buzz/" name
> +                                  "/archive/v" version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "1xanqn6s2i6s2n6wysvgz6l58lsdkl3zmzz4hccla01gx7h4yx4f"))))

To placate ‘guix lint’, could you (1) use ‘git-fetch’ instead of
referring to an autogenerated tarball, and (2) add a ‘file-name’ field
as done elsewhere?

> +    (arguments
> +     `(#:tests? #t

You can remove this line, it’s the default.

> +    (synopsis "Per-application volume control and OSD for Linux desktops")
> +    (description "Volctl is a PulseAudio-enabled tray icon volume control and
> +OSD applet for Linux desktops.  It's not meant to be an replacement for a

I’d suggest:

  s/OSD/on-screen display (OSD)/
  s/Linux desktops/graphical desktops/

Could you send an updated patch?

Thank you,
Ludo’.




  reply	other threads:[~2021-05-03 21:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-26  7:00 [bug#48027] [PATCH] gnu: Add volctl Simon Streit
2021-05-03 21:09 ` Ludovic Courtès [this message]
2021-05-06  9:39   ` Simon Streit
2021-05-08 12:48     ` bug#48027: " Ludovic Courtès
2021-05-08 22:30       ` [bug#48027] " Simon Streit
2021-05-10  7:58         ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wnsftth9.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=48027@debbugs.gnu.org \
    --cc=simon@netpanic.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).