From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id YCDsAQBsxmBveAEAgWs5BA (envelope-from ) for ; Sun, 13 Jun 2021 22:35:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 1SaYOP9rxmBodAAAB5/wlQ (envelope-from ) for ; Sun, 13 Jun 2021 20:35:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 101571B111 for ; Sun, 13 Jun 2021 22:35:09 +0200 (CEST) Received: from localhost ([::1]:60210 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lsWp2-000115-2L for larch@yhetil.org; Sun, 13 Jun 2021 16:35:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56298) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lsWov-00010r-Us for guix-patches@gnu.org; Sun, 13 Jun 2021 16:35:01 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:32879) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lsWov-0008Ka-MW for guix-patches@gnu.org; Sun, 13 Jun 2021 16:35:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lsWov-00025S-JA for guix-patches@gnu.org; Sun, 13 Jun 2021 16:35:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48943] [PATCH] import: hackage: Support "common" field and imports Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 13 Jun 2021 20:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48943 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Philip Munksgaard Cc: 48943@debbugs.gnu.org Received: via spool by 48943-submit@debbugs.gnu.org id=B48943.16236164958006 (code B ref 48943); Sun, 13 Jun 2021 20:35:01 +0000 Received: (at 48943) by debbugs.gnu.org; 13 Jun 2021 20:34:55 +0000 Received: from localhost ([127.0.0.1]:44425 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lsWop-000254-Gq for submit@debbugs.gnu.org; Sun, 13 Jun 2021 16:34:55 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58532) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lsWoo-00024p-2F for 48943@debbugs.gnu.org; Sun, 13 Jun 2021 16:34:54 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52322) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lsWoi-0008Bd-OP; Sun, 13 Jun 2021 16:34:48 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=57546 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lsWoi-00005f-Dr; Sun, 13 Jun 2021 16:34:48 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20210610083953.664318-1-philip@munksgaard.me> Date: Sun, 13 Jun 2021 22:34:46 +0200 In-Reply-To: <20210610083953.664318-1-philip@munksgaard.me> (Philip Munksgaard's message of "Thu, 10 Jun 2021 10:39:53 +0200") Message-ID: <87wnqxzeop.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1623616509; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=BQrSjYxdJCqtUWc8k1j1jeyyTrFCWW3HtSe8w6rTu7M=; b=KCt9lE5I/auVAYeZYjy9OIS+hMjih5b+VKV9uLSNBaKmcbESl+jBrUfKaJk7eWD3/5PNbp F8hFstEEHjhejQLy1mgkpvcbeKHokLxh1aTleRJTHY9vROe+BtoFrmn6hHNiDDHkcaNzHK DEUsm1vtpxNbq9gVxXvY3HxpuNBWzyXU5Po+7j4oMqfXhZldBXHjdhermk1OMX9BJ5rXIO LHEFcv8Tdh9iT39sbD6xDhQx1hJADI5RIjp3sg+14FKwlrb+idQ4XbyMYSv/yJRistcsv8 RrRiYdft19MDEE9CL5XStlRq2CobuIP4p3inC80IO+A/wMp0dyk2/n1sVUdwGw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1623616509; a=rsa-sha256; cv=none; b=WRGYVZvkEUBERuleIisHMZd9uFnt2Ww/7D4l2M6rgKPnjNBmS90pMTUL4zdDBDI8D6jUyU 6OLxK3W9/vAMRKBz5zlz4d6hK4nrFUFMe+kQfRrX6kqdKV0gploqY/a4/fORE+r1nQgaaW V1LM8/KxVepO9A63Iz/p/FgoQv6TynhKwIbvqPnyxGsO0avJ2xC+aQXUvhEeAGsVZ+ujes cvZh9Focdvm3iSYhWGbwO26ySy/oOtB8e7Dz1JoN4QpkPhIoKkZ+0ugfld76mSWmNi9iEC XFhqZpGFf+yjFLVgnjc9piNUAm2XI1HfbIIJeZYZxWHLMaX08hl9krNsOMVO1A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.92 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 101571B111 X-Spam-Score: -2.92 X-Migadu-Scanner: scn0.migadu.com X-TUID: xE3EeSVrJ5AN Hi, Philip Munksgaard skribis: > Fixes . > > * guix/import/cabal.scm (make-cabal-parser): Modify. > (is-common): New variable. > (lex-common): New procedure. > (is-id): Modify. > (eval-cabal): Modify. Could you add a test case in =E2=80=98tests/hackage.scm=E2=80=99 and send a= n updated patch? Apart from that it LGTM, thanks! Ludo=E2=80=99.