unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#49736] [PATCH] gnu: Add emacs-nasm-mode.
@ 2021-07-25 21:44 Ron Nazarov via Guix-patches via
  2021-07-27 17:43 ` Nicolas Goaziou
  2021-07-28 15:35 ` [bug#49736] [PATCH v2] " Ron Nazarov via Guix-patches via
  0 siblings, 2 replies; 4+ messages in thread
From: Ron Nazarov via Guix-patches via @ 2021-07-25 21:44 UTC (permalink / raw)
  To: 49736; +Cc: Ron Nazarov

* gnu/packages/emacs-xyz.scm (emacs-nasm-mode): New variable.
---
 gnu/packages/emacs-xyz.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index a26a023a2b..83a59ca3a4 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -101,6 +101,7 @@
 ;;; Copyright © 2021 David Dashyan <mail@davie.li>
 ;;; Copyright © 2021 Dhruvin Gandhi <contact@dhruvin.dev>
 ;;; Copyright © 2021 Matthew James Kraai <kraai@ftbfs.org>
+;;; Copyright © 2021 Noisytoot <noisytoot@disroot.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -29037,3 +29038,26 @@ Believing} is a ruby gem to evaluate Ruby code, recording the results of each
 line.  This minor mode provides an easy way to run it from Emacs on the
 current region or entire buffer.")
       (license license:gpl3+))))
+
+(define-public emacs-nasm-mode
+  (package
+    (name "emacs-nasm-mode")
+    (version "20190410.342")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://melpa.org/packages/nasm-mode-"
+             version
+             ".el"))
+       (sha256
+        (base32
+         "10js4bdgqgvlhpk3mgq3rjglmkgkxchj1bny16bkl7glw5mqwl8c"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/skeeto/nasm-mode")
+    (synopsis "NASM x86 assembly major mode")
+    (description
+     "@code{nasm-mode} is a major mode for editing NASM x86 assembly programs.
+It includes syntax highlighting, automatic indentation, and imenu integration.
+Unlike Emacs' generic @code{asm-mode}, it understands NASM-specific syntax.")
+    (license license:unlicense)))
-- 
2.32.0





^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#49736] [PATCH] gnu: Add emacs-nasm-mode.
  2021-07-25 21:44 [bug#49736] [PATCH] gnu: Add emacs-nasm-mode Ron Nazarov via Guix-patches via
@ 2021-07-27 17:43 ` Nicolas Goaziou
  2021-07-28 15:35 ` [bug#49736] [PATCH v2] " Ron Nazarov via Guix-patches via
  1 sibling, 0 replies; 4+ messages in thread
From: Nicolas Goaziou @ 2021-07-27 17:43 UTC (permalink / raw)
  To: 49736; +Cc: noisytoot

Hello,

Ron Nazarov via Guix-patches via <guix-patches@gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-nasm-mode): New variable.

Thank you.

> +(define-public emacs-nasm-mode
> +  (package
> +    (name "emacs-nasm-mode")
> +    (version "20190410.342")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://melpa.org/packages/nasm-mode-"
> +             version
> +             ".el"))

Please use Github repository instead of MELPA.  The latter has a strange
versioning scheme, and source is not stable.

> +       (sha256
> +        (base32
> +         "10js4bdgqgvlhpk3mgq3rjglmkgkxchj1bny16bkl7glw5mqwl8c"))))
> +    (build-system emacs-build-system)
> +    (home-page "https://github.com/skeeto/nasm-mode")
> +    (synopsis "NASM x86 assembly major mode")
> +    (description
> +     "@code{nasm-mode} is a major mode for editing NASM x86 assembly programs.

I would write NASM mode is ...

> +It includes syntax highlighting, automatic indentation, and imenu integration.
> +Unlike Emacs' generic @code{asm-mode}, it understands NASM-specific syntax.")

ditto: ASM mode.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou




^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#49736] [PATCH v2] gnu: Add emacs-nasm-mode.
  2021-07-25 21:44 [bug#49736] [PATCH] gnu: Add emacs-nasm-mode Ron Nazarov via Guix-patches via
  2021-07-27 17:43 ` Nicolas Goaziou
@ 2021-07-28 15:35 ` Ron Nazarov via Guix-patches via
  2021-07-29  7:42   ` Nicolas Goaziou
  1 sibling, 1 reply; 4+ messages in thread
From: Ron Nazarov via Guix-patches via @ 2021-07-28 15:35 UTC (permalink / raw)
  To: 49736; +Cc: Ron Nazarov

* gnu/packages/emacs-xyz.scm (emacs-nasm-mode): New variable.
---
 gnu/packages/emacs-xyz.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index d7c317a076..088266e01b 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -101,6 +101,7 @@
 ;;; Copyright © 2021 David Dashyan <mail@davie.li>
 ;;; Copyright © 2021 Dhruvin Gandhi <contact@dhruvin.dev>
 ;;; Copyright © 2021 Matthew James Kraai <kraai@ftbfs.org>
+;;; Copyright © 2021 Noisytoot <noisytoot@disroot.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -29055,3 +29056,26 @@ Believing} is a ruby gem to evaluate Ruby code, recording the results of each
 line.  This minor mode provides an easy way to run it from Emacs on the
 current region or entire buffer.")
       (license license:gpl3+))))
+
+(define-public emacs-nasm-mode
+  (package
+    (name "emacs-nasm-mode")
+    (version "1.1.1")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/skeeto/nasm-mode")
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "1dyc50a1zskx9fqxl2iy2x74f3bkb2ccz908v0aj13rqfqqnns9j"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/skeeto/nasm-mode")
+    (synopsis "NASM x86 assembly major mode")
+    (description
+     "NASM mode is a major mode for editing NASM x86 assembly programs.
+It includes syntax highlighting, automatic indentation, and imenu integration.
+Unlike Emacs' generic ASM mode, it understands NASM-specific syntax.")
+    (license license:unlicense)))
-- 
2.32.0





^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#49736] [PATCH v2] gnu: Add emacs-nasm-mode.
  2021-07-28 15:35 ` [bug#49736] [PATCH v2] " Ron Nazarov via Guix-patches via
@ 2021-07-29  7:42   ` Nicolas Goaziou
  0 siblings, 0 replies; 4+ messages in thread
From: Nicolas Goaziou @ 2021-07-29  7:42 UTC (permalink / raw)
  To: 49736; +Cc: 49736-done, Ron Nazarov

Hello,

Ron Nazarov via Guix-patches via <guix-patches@gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-nasm-mode): New variable.

Applied. Thank you!

Please note (for future contributions) that adding package definitions
at the very end of a file is prone to merge conflicts. It is better to
use a random location.

Regards,
-- 
Nicolas Goaziou




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-07-29  7:44 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-25 21:44 [bug#49736] [PATCH] gnu: Add emacs-nasm-mode Ron Nazarov via Guix-patches via
2021-07-27 17:43 ` Nicolas Goaziou
2021-07-28 15:35 ` [bug#49736] [PATCH v2] " Ron Nazarov via Guix-patches via
2021-07-29  7:42   ` Nicolas Goaziou

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).