From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id MNtqKrO1HmFkegEAgWs5BA (envelope-from ) for ; Thu, 19 Aug 2021 21:49:07 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id gJPzJbO1HmGPOwAAbx9fmQ (envelope-from ) for ; Thu, 19 Aug 2021 19:49:07 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1CFB426B10 for ; Thu, 19 Aug 2021 21:49:07 +0200 (CEST) Received: from localhost ([::1]:35054 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mGo2E-0004b8-6O for larch@yhetil.org; Thu, 19 Aug 2021 15:49:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52902) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mGo2A-0004b0-8d for guix-patches@gnu.org; Thu, 19 Aug 2021 15:49:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49281) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mGo2A-0007SV-0z for guix-patches@gnu.org; Thu, 19 Aug 2021 15:49:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mGo29-0004D1-Py for guix-patches@gnu.org; Thu, 19 Aug 2021 15:49:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50117] [PATCH 0/2] go-github-com-aswinkarthik-csvdiff package updates Resent-From: Arun Isaac Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 19 Aug 2021 19:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50117 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: BonfaceKilz , 50117@debbugs.gnu.org Cc: BonfaceKilz , iskarian@mgsn.dev Received: via spool by 50117-submit@debbugs.gnu.org id=B50117.162940248416105 (code B ref 50117); Thu, 19 Aug 2021 19:49:01 +0000 Received: (at 50117) by debbugs.gnu.org; 19 Aug 2021 19:48:04 +0000 Received: from localhost ([127.0.0.1]:60827 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mGo1A-0004BM-0F for submit@debbugs.gnu.org; Thu, 19 Aug 2021 15:48:04 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:46298) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mGo13-0004B6-Sz for 50117@debbugs.gnu.org; Thu, 19 Aug 2021 15:47:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=UVsJaCzjt8PmLaPv6M6T1ZauQVXlOg0Yh2ScATpwSgk=; b=oFhO7Sdi4Vm/Jn9wNn8s9+SI4n SHMPMoADK8xu0RgkTQJ0rQv9hUS0Q9rU71kTJvV2tHySTTd8DkyMuBFbkv3BspfVkiJC4vZaeoTBp x0bcZlPpEtzeoZbqptc5k5Et1gMss4oHCgYxmyunXlaZwi7UMTMTm6W7fT1EXqfgtEFLUmwmZsdRT ip+kUpRz5t/qOtrEk2Wmhvdr4SCT7c7KGBCbT+n2gu4GWJd3bcEAq1KD5eiNOM9s+/Ws6dc1Hyyud yklatT0fvqVQc0mSSp0fhoHYIoJUJ6GOiqcnTFbwEHG/1s1RLqmQfp+jLVViK8Djvyl09ONYFz/sK O3lzYR2Q==; Received: from [192.168.2.1] (port=6692 helo=steel) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mGo0v-0007Fk-Dn; Fri, 20 Aug 2021 01:17:45 +0530 From: Arun Isaac In-Reply-To: <20210819072156.90545-1-me@bonfacemunyoki.com> References: <20210819072156.90545-1-me@bonfacemunyoki.com> Date: Fri, 20 Aug 2021 01:17:39 +0530 Message-ID: <87wnohrzc4.fsf@systemreboot.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1629402547; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=UVsJaCzjt8PmLaPv6M6T1ZauQVXlOg0Yh2ScATpwSgk=; b=a+1MwrCIZSrYicyHvwhZOTmhDB9NO7+wfKcjtKnn5j4VIyqr/Jmmjq+MO1fb8hHzUy5UlH C6uWF2OITteL00mChkF8TJb/coZuUXsasWMIwieKKL5JF+PbKQo/7Lo/2nVfshKDneMb8/ zLJO85emb1B+Rebl2suk2dAxf73yOkgl+RGf3uoPAJBbgzAR9Y3YmrmkOOyXRQfNiSC4AM ep7JQFSIkT6CZMjoY+ZVlhldbb3VeBRExSKZCJRAfYjd6c5n7VlV7Om1aOM6EBRWqms4cv cpa9ni+7E2nbjscMW4uDBCVzvwbGyalOGEYFAOV7y0+9VcVRtOCEDfQwOKEogg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1629402547; a=rsa-sha256; cv=none; b=m/EApyIGtpuKLAyQ+AqtQe9iRzkWpfiSPI9Tw3XKRbtGWcgfh60Pe2PZlylRbpI2Tq4mtp iB89xIcHrPbok3SQ9fjFQaJTfT3DClE4xxySOe6Gt81AtYAlcm6Ume/KPDV0dTJUWegTRJ BnF0IHIo7uEshNSE2kTgO6SjQ6iJ8TWoqNHOHoYSbbIsZwjT9Sl6hmsAlp+4DW6ZqB1PVl PV0pqRbVT+zVEOVru5SNi33gTaDqLGFwZcKk7Nl7hbo0XIJKSqaLnefSYU5CTA/tGnS+X9 VUXvrdb0y94eaIF7NQpjgjj8IxxMtEmuALaBl4oxWzdo1jz6frPQW8FtulyxQw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=systemreboot.net header.s=default header.b=oFhO7Sdi; dmarc=fail reason="SPF not aligned (relaxed)" header.from=systemreboot.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -3.42 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=systemreboot.net header.s=default header.b=oFhO7Sdi; dmarc=fail reason="SPF not aligned (relaxed)" header.from=systemreboot.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 1CFB426B10 X-Spam-Score: -3.42 X-Migadu-Scanner: scn0.migadu.com X-TUID: hlfaiWU74qBR --=-=-= Content-Type: text/plain Hi Bonface, Thanks for the patches! Some feedback follows. 1. I think we can combine the two commits into one since this is logically just a single change. 2. We should retain the old package as a deprecated package. We should add something like the snippet below. --8<---------------cut here---------------start------------->8--- (define-public go-github-com-aswinkarthik-csvdiff (deprecated-package "go-github-com-aswinkarthik-csvdiff" csvdiff)) --8<---------------cut here---------------end--------------->8--- > (define-public go-github-com-aswinkarthik-csvdiff 3. We should rename the variable name as well. > (package > - (name "go-github-com-aswinkarthik-csvdiff") > + (name "csvdiff") 3. We should also move the package to some file other than golang.scm. How about textutils.scm? Thank you for your patience! :-) Arun --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFPBAEBCAA5FiEEf3MDQ/Lwnzx3v3nTLiXui2GAK7MFAmEetVsbHGFydW5pc2Fh Y0BzeXN0ZW1yZWJvb3QubmV0AAoJEC4l7othgCuzRoIH/RKkfAklXhz2l9QommDE gWWBXmUTg1DqbvzbtqoekbhiXQv2lteC5V8SuTBsMPK6fCdP3YR+16kdDJHOwSR8 COrcekCM+W0V9WClUvyk9MPNmtbIF0pu4zeCXHmlPpspN8Qj6lLAlkeZ6V/Fsi8J d2d6gpCJcQDpqHNK5IPLVRFP/jRVJ5g0A9NjnlsNJ5dzQ8U/H7jABy5f8iDWa0qp FIhqPh648934xRTNLz2VCfKEeqnhRodUFs2BxmBC50evaOsBb8EszLqFPq8GpuVH dHQf/FcCCo5yFrk9ZD6bZGH/zSctibdDH6HsC5sRXI7C1kBnAM7WBeVWP3y7UDlq HMU= =Q5Z+ -----END PGP SIGNATURE----- --=-=-=--