From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id IvJwJVslKWGuGwEAgWs5BA (envelope-from ) for ; Fri, 27 Aug 2021 19:48:11 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 4KeOIFslKWHwXgAAB5/wlQ (envelope-from ) for ; Fri, 27 Aug 2021 17:48:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 178D9AAC6 for ; Fri, 27 Aug 2021 19:48:11 +0200 (CEST) Received: from localhost ([::1]:59650 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mJfxa-0003HU-5p for larch@yhetil.org; Fri, 27 Aug 2021 13:48:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55350) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJfxS-0003HB-F1 for guix-patches@gnu.org; Fri, 27 Aug 2021 13:48:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41388) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mJfxS-0002e2-7Q for guix-patches@gnu.org; Fri, 27 Aug 2021 13:48:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mJfxR-00071n-Tx for guix-patches@gnu.org; Fri, 27 Aug 2021 13:48:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50227] [PATCH] build-system/go: Trim store references using the native compiler option. Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 27 Aug 2021 17:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50227 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 50227@debbugs.gnu.org Received: via spool by 50227-submit@debbugs.gnu.org id=B50227.163008645126973 (code B ref 50227); Fri, 27 Aug 2021 17:48:01 +0000 Received: (at 50227) by debbugs.gnu.org; 27 Aug 2021 17:47:31 +0000 Received: from localhost ([127.0.0.1]:52934 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJfwx-00070y-Id for submit@debbugs.gnu.org; Fri, 27 Aug 2021 13:47:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39120) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJfwu-00070j-Gv for 50227@debbugs.gnu.org; Fri, 27 Aug 2021 13:47:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57292) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mJfwo-0002Db-UE for 50227@debbugs.gnu.org; Fri, 27 Aug 2021 13:47:23 -0400 Received: from host-37-191-231-185.lynet.no ([37.191.231.185]:38014 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJfwm-0002Io-Hq for 50227@debbugs.gnu.org; Fri, 27 Aug 2021 13:47:22 -0400 From: Marius Bakke In-Reply-To: <20210827164423.17109-1-marius@gnu.org> References: <20210827151052.12611-1-marius@gnu.org> <20210827164423.17109-1-marius@gnu.org> Date: Fri, 27 Aug 2021 19:47:17 +0200 Message-ID: <87wno6n5ju.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1630086491; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=a580dBRsoPm2k+/Xj8Ozx9zWCAMbjA3SVfDTb1am+Y0=; b=l5m915HLRDKg2DMH+vXjQwhrZVAOZc2DVZQ0A6yzAI/wHhFN49zA0x31E9HBTsEMl2V88D 0Ib5a2KcFdYPL/gPYjEAVZ1mbgW7KJMhpyLwkU5+uH0HKQ5FhBEAR3ghS2ynY1DCewbK/q HcGA29RkNjpCi/nG9Zbb8wE7qauBG9joFpCsBvVh3Ev3VxdNjFBtIPx4zZfIDw/wrljH9E 7FRIwOv0c1E6TlSYR+U0AC2MRU06cEfEvgUEeRtgwpq4VfucXznfMwyXZgUJAqMFYD5ptU Q1hTWnt1uXJ0HItS74B37KIn8ZRAB81LcKlS2XtdFU04Mw11xHkP7KuMPvFFCg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1630086491; a=rsa-sha256; cv=none; b=VmyNtbn0F/qrTQJHRQGpL95nwOR52WKNpcQ5Jr4O0uTbQntsSKKVHeEoFYfl1PMlj4OAJr eais5w8YCxPAU0ORR1CRI3ffXROFbhhpDEFDIcmPBJCcXHVyj2p4ZyZtcAr7lcBIOFzBdH YvwUVNAz81u+SsvbzsNqIst+NFv2oMfM6h0elHyq63R6tQuVo+oHez4GzCuWidhBS7kp8t PvZDQdvJBkPlkPlAeZzKRKV8EaBKO+5JjLWxOOo653VaMY+hpZQlLXanOSjocPO8VaHw5v yKxvLiWmVnbr0CZnnuvpjO2zhJ2dnMJa/+nJfqFaCFF8i7gjFb15GrROqHJWZg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -5.03 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 178D9AAC6 X-Spam-Score: -5.03 X-Migadu-Scanner: scn0.migadu.com X-TUID: 2xpmt5r3K1Gl --=-=-= Content-Type: text/plain Marius Bakke skriver: > * guix/build/go-build-system.scm (build): Add '-trimpath' to the 'go install' > invocation. > (remove-store-references, remove-go-references): Remove procedures. > (%standard-phases): Don't include remove-go-references. > * gnu/packages/docker.scm (docker)[arguments]: Add the '-trimpath' option to > the build flags. Remove phase remove-go-references. > * gnu/packages/uucp.scm (nncp)[arguments]: Likewise. Some context for this patch, which I forgot to save before sending: I happened to rediscover and pulled out my yak shaving device again. This patch removes the custom 'remove-store-references' procedure in favor of the native '-trimpath' option to 'go install', as alluded to in the bug report as well as the build system commentary. I don't spot any difference in sizes from 'master' apart from one package: Docker. Docker explodes from 764.4 MiB to 1215.5 MiB with this patch even though it does use the '-trimpath' option. Perhaps -trimpath does not work as well with dynamically linked executables as it does for static? I'm willing to overlook this regression for now in favor of the reduced complexity, but comments welcome. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIUEARYKAC0WIQRNTknu3zbaMQ2ddzTocYulkRQQdwUCYSklJQ8cbWFyaXVzQGdu dS5vcmcACgkQ6HGLpZEUEHeJ9gD/Uq7jBi7fNKwJnDUx1sBTVWG8abmZstu3sJU2 wFnmd+UA/0x+T5WzVa95c546RK7bleaOFOC0yKrN4rEiVd2YPbYG =ZQ24 -----END PGP SIGNATURE----- --=-=-=--