From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id aNdfLrwZVmE2JgEAgWs5BA (envelope-from ) for ; Thu, 30 Sep 2021 22:10:36 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id SEjwKbwZVmFgTQAAbx9fmQ (envelope-from ) for ; Thu, 30 Sep 2021 20:10:36 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6705C98A8 for ; Thu, 30 Sep 2021 22:10:36 +0200 (CEST) Received: from localhost ([::1]:40536 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mW2O3-00085D-9O for larch@yhetil.org; Thu, 30 Sep 2021 16:10:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50586) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mW2NX-00084j-1w for guix-patches@gnu.org; Thu, 30 Sep 2021 16:10:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42552) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mW2NW-0001vi-Q8 for guix-patches@gnu.org; Thu, 30 Sep 2021 16:10:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mW2NW-0004kn-Iy for guix-patches@gnu.org; Thu, 30 Sep 2021 16:10:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50620] [PATCH 0/2] Unify 'computed-origin-method' (linux, icecat) Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 30 Sep 2021 20:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50620 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler Cc: Mark H Weaver , 50620@debbugs.gnu.org, zimoun Received: via spool by 50620-submit@debbugs.gnu.org id=B50620.163303256218218 (code B ref 50620); Thu, 30 Sep 2021 20:10:02 +0000 Received: (at 50620) by debbugs.gnu.org; 30 Sep 2021 20:09:22 +0000 Received: from localhost ([127.0.0.1]:54098 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mW2Mr-0004jm-Rr for submit@debbugs.gnu.org; Thu, 30 Sep 2021 16:09:22 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45304) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mW2Mq-0004jY-Cq for 50620@debbugs.gnu.org; Thu, 30 Sep 2021 16:09:20 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58078) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mW2Ml-0001Ij-4t; Thu, 30 Sep 2021 16:09:15 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=36434 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mW2Mj-0007Oc-LP; Thu, 30 Sep 2021 16:09:15 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20210916114734.2686426-1-zimon.toutoune@gmail.com> <9b6ee27ff10e1042a5d61d0f93d957cf760e9ecb.camel@gmail.com> <87v930ay5y.fsf@netris.org> <87pmstghx0.fsf@netris.org> <87a6jv8qu7.fsf_-_@gnu.org> <87pmsr5a0z.fsf_-_@gnu.org> <09c009ec61b8f9c1746f98916f492b8953b16dcc.camel@gmail.com> <87r1d64gd3.fsf_-_@gnu.org> <735304d110f5e99c66904fc7ced3465bf1815baf.camel@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 9 =?UTF-8?Q?Vend=C3=A9miaire?= an 230 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 30 Sep 2021 22:09:12 +0200 In-Reply-To: <735304d110f5e99c66904fc7ced3465bf1815baf.camel@gmail.com> (Liliana Marie Prikler's message of "Thu, 30 Sep 2021 16:17:48 +0200") Message-ID: <87wnmx3jx3.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1633032636; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=P/04QQ/9Oddv9u0bCxYBPzQdWdcTiP6M2tgGaigv72k=; b=O8/Sha0tYQcyunYxTfeEO/lyJckpj84RpxK3bRmjUaQFOPvob78f7INhblY42OLcGK8Gt3 2hQlEyT244t5bNDjkhodH8YAo7K3ksE4VgMJgmhFuJGCgX6ksqOAUPsDjckVR6WiK48tHB 1lmsiM7+5pAj03FYGnw3sEOZKIPPgxRsr0PnYve++88yOfOe8qJL/hgyeKyd63nOJKPI1h eAbvbWnxsNvfWKCvlOFvDuXcNI0tIPk0JM8vz1bJPAICu2baYDsSr2O1RPzMGTH+74Xgw3 WaJbT7mM39LJhxKhe61kuFMENKaZJhmsNQ8OdFIeffuWFM9pEXK8nXETHWKgqQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1633032636; a=rsa-sha256; cv=none; b=qRBjCJt3y0fIAWfD/+WlcIXSnPGuEPNEqxi3MsGwhH4CaWrYVMrwkcM12TfqVgbHQaYjZ9 n8CiONmC6+SRAu3Af+rS83N7BS9z4tVhzXTYNwIhE2NqbgzGSOCKbHYc48eRqCFrjOmnO7 qZhcOqyMjL8+Lh94/6Br9jKSnMWztpHjjvnTl3ni0qOHtzgtKVQbUjoNrH2pv8tnsM4VVq PIHTSB0MQqKW/4R5QeN1xjzsQN5fK1huE8XoKaNw/7WTBeVipeHbljk9l33vWiOfT3Cr4T MmT/oEmH0oUscItXbbLLX2rTTIq3zDn3MruFTA/kHS5PKhq5RaDsslsw3/aSAg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.40 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 6705C98A8 X-Spam-Score: -1.40 X-Migadu-Scanner: scn0.migadu.com X-TUID: Vy9offfvEBxw Liliana Marie Prikler skribis: > Am Donnerstag, den 30.09.2021, 10:28 +0200 schrieb Ludovic Court=C3=A8s: >> [...] >> > What we can't currently control is the top directory name and the >> > output name. Both of that could be customized by supplying a >> > "repack-name" field, which is used as basis for the directory name >> > and the tarball name. >> > Another thing we can't easily control are extraneous inputs to the >> > patches, although the patch-inputs field *does* exist. >>=20 >> It=E2=80=99s possible to use a gexp as the snippet, where you can refer = to >> additional things in there (though in practice this is currently >> impractical due to snippets not being thunks/promises.) > Which is a practical issue because it'd mean that the tarball gets > built as soon as the source is interpreted? It=E2=80=99s impractical because typical usage introduces top-level circular references (e.g., if you write #$gzip). > I mean that we don't need to wrap local-file inside an origin for > example whereas we do need to wrap e.g. svn-fetch instead of having an > svn-checkout constructor at the top. It's not really that noticable > normally, but weird once you start thinking a little too hard about it. Hmm yeah, I must not be thinking hard enough. :-) > Slightly similar, but I don't think I'd want a singular source url.=20 > Instead > > (define-record-type* computed-tarball=20 > make-computed-tarball > computed-tarball? > this-computed-tarball > (sources computed-tarball-sources) ; list of origins, local=20 > ; files or other things > (builder computer-tarball-builder (thunked)) ; gexp > (name computed-tarball-name) ; perhaps? > (location computed-tarball-location (innate)=20 > (default (current-source-location)))) > > At the start of BUILDER, SOURCES are already unpacked to the current > working directory under their stripped file names. After builder > returns, we either package the contents of the current working > directory up into a tarball (variant A) or we have builder return a > list of files to pack up (variant B) which we then post-process maybe. >=20=20 > WDYT? Overall LGTM! IWBN to see if there are other potential users in the tree (I can=E2=80=99t think of any), but for IceCat and Linux-libre, it cou= ld already improve the situation. Thanks, Ludo=E2=80=99.