From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id PEYjFJrWnWHdJQEAgWs5BA (envelope-from ) for ; Wed, 24 Nov 2021 07:07:22 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id oABkD5rWnWHoaQAA1q6Kng (envelope-from ) for ; Wed, 24 Nov 2021 06:07:22 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AAD28187F4 for ; Wed, 24 Nov 2021 07:07:21 +0100 (CET) Received: from localhost ([::1]:43620 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mplRA-0006e8-Ft for larch@yhetil.org; Wed, 24 Nov 2021 01:07:20 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52526) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mplQs-0006cY-Vu for guix-patches@gnu.org; Wed, 24 Nov 2021 01:07:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:41208) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mplQs-0007cz-8m for guix-patches@gnu.org; Wed, 24 Nov 2021 01:07:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mplQs-000473-43 for guix-patches@gnu.org; Wed, 24 Nov 2021 01:07:02 -0500 Subject: bug#52065: [PATCH core-updates-frozen] gnu: gdm: Pass GDK_PIXBUF_MODULE_FILE to sessions. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Wed, 24 Nov 2021 06:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 52065 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Josselin Poiret Cc: 52065-done@debbugs.gnu.org Mail-Followup-To: 52065@debbugs.gnu.org, maxim.cournoyer@gmail.com, dev@jpoiret.xyz Received: via spool by 52065-done@debbugs.gnu.org id=D52065.163773400015730 (code D ref 52065); Wed, 24 Nov 2021 06:07:01 +0000 Received: (at 52065-done) by debbugs.gnu.org; 24 Nov 2021 06:06:40 +0000 Received: from localhost ([127.0.0.1]:52752 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mplQW-00045e-7w for submit@debbugs.gnu.org; Wed, 24 Nov 2021 01:06:40 -0500 Received: from mail-qt1-f169.google.com ([209.85.160.169]:39720) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mplQR-00045H-0F for 52065-done@debbugs.gnu.org; Wed, 24 Nov 2021 01:06:38 -0500 Received: by mail-qt1-f169.google.com with SMTP id l8so1631047qtk.6 for <52065-done@debbugs.gnu.org>; Tue, 23 Nov 2021 22:06:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=BVXgD32JKeJeUSi8Nd+gZNJ0ETMFEP5STlbOSrifPxA=; b=qolZMmjjQMSL2KsHlGrdwGRc46gpE2+BFPTGC+XtLmIVnxUbeIRItQ71CFTTGhmyV4 jGmWMMFVpjRpNAauFjakgs2FG/LtqdkIaRqmLLJEz/V4aNr+1iE6OiY1KtckhAqZ7QB2 VJwbIwiiLv4DwYdo4YIW83bD/SWhuiVvJuEr/gJHKq8G+Qsh0aJcVthjOwy1JI1VX0qG mqGBjcRONoa4LhRnwq62ZWK9DqxBcj27MNyC0hhzj2Yo5Xab02rpBLWTotZ7KkOfgjsF BKJ2/wA7o3AgLHq8K7a0Z+aDfE9G5vPRoqSRrQtln1rdOF6+nxj03OvyzF0oPNtKarsw toow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=BVXgD32JKeJeUSi8Nd+gZNJ0ETMFEP5STlbOSrifPxA=; b=wnq9/ZM+YvjrrtrFUY+Evcnyo6UYoBmE5DS/0jlIzTjcBBHSCHEdGjr9OG41bp/dxE Nt5aO5Rnay6Z+aqoLd9aGJJQmKCzBCXq1td4RpVNrxa89u1lXyXEeO6nQYkCkfBF59ki HmNV77HT56cLxUTYc04XqNXbEGabXsoTiT1EJ6EpWyzbxGiqJXqCgVlczYGEtn/JVekQ qnttQCjzu1SKRdnU28MTCTrg3ZgBb+LNIRRLscw1QdDQY+8RQgc80mD2rpM3HrmVOvm8 sFx8AtufR72G9tnQSqRo0lt3IfWN2+5MNTdscFM6M6r8OitQMyyfyN9NUpf8cc0aKXrr Y/XA== X-Gm-Message-State: AOAM533HvAwJ8+LjAqTY7S+r4wtLIeD2wYWfYRiyr7/FIiVN0ryIPNwH dR3pGArJKNRwtNBQCgELG1k1RcEG2km5/w== X-Google-Smtp-Source: ABdhPJxrglrHeK31eFC8aejVkiCOEz9dMlbwRpjMPWLk3mcz/j54eTYn9o2pgyYDU00+bGb1lMF+ww== X-Received: by 2002:a05:622a:1115:: with SMTP id e21mr3867730qty.315.1637733989207; Tue, 23 Nov 2021 22:06:29 -0800 (PST) Received: from hurd (dsl-149-45.b2b2c.ca. [66.158.149.45]) by smtp.gmail.com with ESMTPSA id v15sm7908726qkl.91.2021.11.23.22.06.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Nov 2021 22:06:28 -0800 (PST) From: Maxim Cournoyer References: <20211123202510.14090-1-dev@jpoiret.xyz> Date: Wed, 24 Nov 2021 01:06:28 -0500 In-Reply-To: <20211123202510.14090-1-dev@jpoiret.xyz> (Josselin Poiret's message of "Tue, 23 Nov 2021 20:25:10 +0000") Message-ID: <87wnkyytnf.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1637734041; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=BVXgD32JKeJeUSi8Nd+gZNJ0ETMFEP5STlbOSrifPxA=; b=BXsp1dMSerg9OSwmWcJ614+lAfYSSHucJKJHI834j0DWeTv9laEytRUg9Y9ztzPD1Nxzar bN81o6c8XyYya0bmZZn4NyMlP9BIIkxPTr8IbtvqpepFdBi5fIV0XsFfhsERLBRulWZnW5 G1blootXmHG+6MZk44UOx4VXv3zSpScJjMp3PRgZLJgAo6O6lm2ABrARiC4KuWv1nY8Z+D J19queySCgDriW715N4fzV+tk+49mcrwYi2lFTfG/DmIualAfJvnbItu3w4FnqKUi1wXmj NHSNd61scEdm+F5tpgQOAhvKuda08wWd17vHPfCpQsppwqw/+rsCWqsqu6YzQg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1637734041; a=rsa-sha256; cv=none; b=Qkh842huGq2v8Ly/n0s0z3HsDnTdVZ2PJqoKM+JFFNok7yA64DI5l0gNRC77HweHK+vmCV piM+KdKYtsO11Jpgqw2Fj57CMZ1ty2lLHmbF7UrmHafsecu4D3VmLA7F3xRfqzvhjZh9XX mmpYMlWD7NLzwQLyGiBSa25nV3vtFP6IEsQwNZM8x8brj7y7Cy/fmim5LXBFY4m4R2DmSO 4igCvDPehepl9GlKetMgEvEqLHBFyomqoeO+TFv0+Q7TCEMMHz+AUv9BKnVbRkcHrie1Mw e6uZn0eIbqQFmBUG+rcH2TNJBW+3/IQbAdyjOEhXXMuLI4NIWs4p6BaUVT84AA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=qolZMmjj; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.79 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=qolZMmjj; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: AAD28187F4 X-Spam-Score: -1.79 X-Migadu-Scanner: scn1.migadu.com X-TUID: SFrwuL19UrVL Hello Josselin, Josselin Poiret writes: > Hello, > > This patch should fix GDM not showing svg icons, most notably the peek > password one on the login prompt. > > Best, > Josselin > > -- >8 -- > * gnu/packages/patches/gdm-pass-gdk-pixbuf-loader-env.patch: Add > patch. > * gnu/local.mk (dist_patch_DATA): List it. > * gnu/packages/gnome.scm (gdm): Use it. > * gnu/services/xorg.scm (gdm-shepherd-service): Pass > GDK_PIXBUF_MODULE_FILE. Thank you so much for tackling this! [...] > diff --git a/gnu/services/xorg.scm b/gnu/services/xorg.scm > index 0735d777bd..3abee8694a 100644 > --- a/gnu/services/xorg.scm > +++ b/gnu/services/xorg.scm > @@ -1004,6 +1004,10 @@ (define (gdm-shepherd-service config) > ;; cursors. gdm doesn't login so doesn't source > ;; the corresponding line in /etc/profile. > "XCURSOR_PATH=/run/current-system/profile/share/icons" > + (string-append > + "GDK_PIXBUF_MODULE_FILE=" > + #$gnome-shell > + "/lib/gdk-pixbuf-2.0/2.10.0/loaders.cache") > (string-append > "GDM_WAYLAND_SESSION=" > #$(gdm-configuration-wayland-session config)))))) I've modified the above slightly like so: --8<---------------cut here---------------start------------->8--- @@ -49,6 +49,7 @@ (define-module (gnu services xorg) #:use-module (gnu packages admin) #:use-module (gnu packages bash) #:use-module (gnu system shadow) + #:use-module (guix build-system glib-or-gtk) #:use-module (guix build-system trivial) #:use-module (guix gexp) #:use-module (guix store) @@ -1004,6 +1005,9 @@ (define (gdm-shepherd-service config) ;; cursors. gdm doesn't login so doesn't source ;; the corresponding line in /etc/profile. "XCURSOR_PATH=/run/current-system/profile/share/icons" + (string-append + "GDK_PIXBUF_MODULE_FILE=" + #$gnome-shell "/" #$%gdk-pixbuf-loaders-cache-file) (string-append "GDM_WAYLAND_SESSION=" #$(gdm-configuration-wayland-session config)))))) --8<---------------cut here---------------end--------------->8--- To avoid hard coding the path. I tested it in a VM with --8<---------------cut here---------------start------------->8--- ./pre-inst-env guix system vm gnu/system/examples/desktop.tmpl --8<---------------cut here---------------end--------------->8--- It all looked good, so I push as commit c3fd310d8f9ab0b5ae0b23bf6a6c67e5e25cc135. Thank you! Maxim