unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: jgart <jgart@dismail.de>
Cc: 53287@debbugs.gnu.org
Subject: [bug#53287] [PATCH] doc: Document the documentation process.
Date: Fri, 21 Jan 2022 22:06:25 +0100	[thread overview]
Message-ID: <87wnis3ijy.fsf_-_@gnu.org> (raw)
In-Reply-To: <20220115194521.2158-1-jgart@dismail.de> (jgart@dismail.de's message of "Sat, 15 Jan 2022 14:45:22 -0500")

Hi!

jgart <jgart@dismail.de> skribis:

> * doc/contributing.texi (Contributing): Add documentation documentation.
>
> Co-authored-by: jgart <jgart@dismail.de>
> Julien Lepiller <julien@lepiller.eu>
> Matt Trzcinski <matt@excalamus.com>
> Fabio Natali <me@fabionatali.com>
> Gabor Boskovits <boskovits@gmail.com>

That’s a much welcome addition!

Overall it LGTM.  I have minor comments to complement what zimoun
already wrote:

> --- a/doc/contributing.texi
> +++ b/doc/contributing.texi
> @@ -30,6 +30,7 @@ choice.
>  * Commit Access::               Pushing to the official repository.
>  * Updating the Guix Package::   Updating the Guix package definition.
>  * Translating Guix::            Make Guix speak your native language.
> +* Documenting Guix::            Improving documentation in GNU Guix.
>  @end menu

I’d move this section before “Translating Guix” because that
conceptually happens before.

Note that you need to add the line above also in the other menus that
show this section.  In Emacs that’s M-x texinfo-all-menus-update I
think, but otherwise you can copy/paste it by hand…  (Menus are one of
the bad things of Texinfo.)

Last, how about changing the title to “Writing Documentation” or
something along these lines?  (In general I like to not repeat “Guix”
everywhere because it’s implicit.)

> +Guix is documented using the Texinfo system.  However, if you are not

I’d remove “However”.

> +To modify the documentation, you need to edit @file{doc/guix.texi} and
> +@file{doc/contributing.texi} (which contains this documentation
> +section), or @file{doc/guix-cookbook.texi} for the cookbook.  If
> +you compiled the Guix repository before, you will have
> +many more @file{.texi} files that are translations of these
> +documents.  Do not modify them, the translation is managed through
> +@uref{https://translate.fedoraproject.org/projects/guix, Weblate},

Replace comma with a period…

> +@pxref{Translating Guix} for more information.

… and pxref with xref.

> +To render your documentation changes, we recommend to execute one of
> +the following commands:

What about:

  To render documentation, you must first make sure that you ran
  @command{./configure} in your source tree (@pxref{Running Guix Before
  It Is Installed}).  After than you can run one of the following
  commands:

?

> +@itemize
> +@item @samp{make doc/guix.info} to compile the info manual.

s/info manual/Info manual/

> +@item @samp{make doc/guix-cookbook.info} for the cookbook info manual.

Likewise.

Could you send an updated patch?

Thumbs up to everyone who participated in this meetup!

Ludo’.




  parent reply	other threads:[~2022-01-21 21:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-15 18:08 [bug#53287] [PATCH] doc: Document the documentation process jgart via Guix-patches via
2022-01-15 19:27 ` [bug#53287] [PATCH v2] " jgart via Guix-patches via
2022-01-15 19:45 ` [bug#53287] [PATCH v3] " jgart via Guix-patches via
2022-01-17 16:31   ` zimoun
2022-01-21 21:06   ` Ludovic Courtès [this message]
2022-01-25  7:27 ` [bug#53287] (no subject) jgart via Guix-patches via
2022-04-08 18:26 ` [bug#53287] [PATCH] doc: Document the documentation process Luis Felipe via Guix-patches via
2022-07-07 18:42   ` Maxim Cournoyer
2022-07-07 21:41     ` Luis Felipe via Guix-patches via
2022-07-07 23:55       ` jgart via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wnis3ijy.fsf_-_@gnu.org \
    --to=ludo@gnu.org \
    --cc=53287@debbugs.gnu.org \
    --cc=jgart@dismail.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).