From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id MFmLNpsPp2LIngAAbAwnHQ (envelope-from ) for ; Mon, 13 Jun 2022 12:21:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id gGtqNpsPp2JOEgAA9RJhRA (envelope-from ) for ; Mon, 13 Jun 2022 12:21:15 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 53F673989B for ; Mon, 13 Jun 2022 12:21:15 +0200 (CEST) Received: from localhost ([::1]:51142 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o0hC5-0004n5-VJ for larch@yhetil.org; Mon, 13 Jun 2022 06:21:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51948) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o0hBu-0004lY-Nh for guix-patches@gnu.org; Mon, 13 Jun 2022 06:21:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:35173) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o0hBu-0006k2-DW for guix-patches@gnu.org; Mon, 13 Jun 2022 06:21:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o0hBu-00077k-9f for guix-patches@gnu.org; Mon, 13 Jun 2022 06:21:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55565] [PATCH] gnu: Add python-blis Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 13 Jun 2022 10:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55565 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "Artyom V. Poptsov" Cc: 55565@debbugs.gnu.org Received: via spool by 55565-submit@debbugs.gnu.org id=B55565.165511562927308 (code B ref 55565); Mon, 13 Jun 2022 10:21:02 +0000 Received: (at 55565) by debbugs.gnu.org; 13 Jun 2022 10:20:29 +0000 Received: from localhost ([127.0.0.1]:57301 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0hBN-00076O-Dl for submit@debbugs.gnu.org; Mon, 13 Jun 2022 06:20:29 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38584) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0hBL-000764-Sj for 55565@debbugs.gnu.org; Mon, 13 Jun 2022 06:20:28 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35442) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o0hBF-0006Xt-Fa; Mon, 13 Jun 2022 06:20:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=hiuYlkbszH2F7JMAyknmTmIGQKUNJDUvcnq84Ko0jTE=; b=fMbaKjJiqRD2b9SMag9W NzZr37OjF9SaSwUxA+ONVnxnMGcYqLIY8/Dzmr4+ZwOfHS9RJGtxTT0tkc+kMZI9GaF2wxUBYgnWC B+E/aNwIlXh+Q7BL96j9SVtJkLzevPNLZvuSWYXLFQRTnvdVDyYwXuugBtcCh6Kn4QAgeNv3VBgDJ BivPutOEJsMwgTQF1mZ11kPwEU8fSIOV87UE1/BnAzDGTnJRtAx7HFZDvX8mgsdt90yr4nNZn0D+n 8h30vqyxuKxOmIs/nmwNb+NjeWmH02ThQPtGTKalE+XK9XC5L0UbBMfkYA8qtTG+GmBtl0WWDLoIc O8QJVlJtHpq3cw==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=43448 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o0hBF-0003Y4-24; Mon, 13 Jun 2022 06:20:21 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87tu9ifs3m.fsf@gmail.com> <87pmjyd60l.fsf@gnu.org> <87pmjfxywd.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Quintidi 25 Prairial an 230 de la =?UTF-8?Q?R=C3=A9volution, ?= jour de la Tanche X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 13 Jun 2022 12:20:18 +0200 In-Reply-To: <87pmjfxywd.fsf@gmail.com> (Artyom V. Poptsov's message of "Sat, 11 Jun 2022 13:44:34 +0300") Message-ID: <87wndksw4d.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1655115675; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=hiuYlkbszH2F7JMAyknmTmIGQKUNJDUvcnq84Ko0jTE=; b=DY1rmqI5Vl25gFWo0xKNSFfmJv1A+DYnIG0+zZRIJIY4Js8TPJzJyJyCcJpQA6an3Jm3N+ JqZEwTYKAbXhhaLGARUtdJAuZ6tRPpSbI61KM1WZP5gHYeb+gnnMRTzAVl6knzu1AmV0Yn 889rpby+q1bxrLs5NPGVbpi4iPwtrpulyTqvarzvaKlOaIJ7SSqP0LQl+Bi7Fo1mDChgOj DK6anLFhhU3IHarZH/lsN1a204urGKle8V3bZLY9CUOdTrtOkTjqBDoXb5RFR5polUKr2E Oi81Lp8UJcfudiVVn94XKLH9OX29YU7yTRqTWG54nMqV358JuGhwsZw6NTqNQA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1655115675; a=rsa-sha256; cv=none; b=t7ytLYMMx5B2lWVTs6SBrImWhIj4DWPHvlPwQQHjKCiFhu9jS52UH4kkKeXo/egHlnaU78 iQ7px18SjL+LbrKMKpc3E6d9yUdj9L1ug+yoIHg704V6Cwbp/vGgOn/p7lEY2oeUUQQX52 3cevqlGFiyEUJabC/Te9NP079zcHfOLh82N0JujTrXxmBAgm2VWiH+pgw8bbzqulB2eA2I yca3B5NGFDRWQt0+8hl0olhvux3z/VTqN2aP2C42j87Knepjaqv0E31F+uhI75d1MeRbjt MAL8gvR681dY28hNAJViU5BuequlrIFoTQWB3dL5lezim3nf8W3msqFYi4FcWg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=fMbaKjJi; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.79 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=fMbaKjJi; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 53F673989B X-Spam-Score: -4.79 X-Migadu-Scanner: scn0.migadu.com X-TUID: xTJVG3MphHx6 Hi Artyom, "Artyom V. Poptsov" skribis: > Basically I patched 'blis/benchmark.py' to use "blas_opt_info" instead > of "blas_ilp64_opt_info" and tests went fine. An issue with different > numpy versions I guess? I also added "blis" and "python-numpy-next" to > the "native-inputs". Unfortunately this is not sufficient: the source bundles a copy of BLIS under =E2=80=98blis/_src=E2=80=99 and it starts by building it (which is wh= y it takes so long), whether or not BLIS is among the inputs. Could you (1) add a snippet that removes =E2=80=98blis/_src=E2=80=99, and (= 2) see whether/how =E2=80=98setup.py=E2=80=99 can be patched to not build BLIS? I= t might be that commenting out the line that reads: cmdclass=3D{"build_ext": ExtensionBuilder}, would be enough, I don=E2=80=99t know. Anyhow, given that BLIS is the kind of package that=E2=80=99s highly tuned = on our side for performance and reproducibility configuration, it=E2=80=99s important to not have several copies around. > + (native-inputs (list python-numpy-next > + python-pytest > + python-cython > + blis > + python-hypothesis)) NumPy and BLIS should definitely be =E2=80=98inputs=E2=80=99, not =E2=80=98= native-inputs=E2=80=99; not sure about =E2=80=98hypothesis=E2=80=99. Also, please include a short comment explaining why numpy-next is used rather than numpy (like =E2=80=9Cversion >=3D X.Y required=E2=80=9D). Could you send an updated patch? Sorry that this is providing trickier than we=E2=80=99d like! Thanks, Ludo=E2=80=99.