unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Maxime Devos <maximedevos@telenet.be>
Cc: 55912@debbugs.gnu.org
Subject: [bug#55912] [PATCH v2] home: Add OpenSSH service.
Date: Thu, 16 Jun 2022 12:47:02 +0200	[thread overview]
Message-ID: <87wndglwbd.fsf@gnu.org> (raw)
In-Reply-To: <d49a133833492d09c2a2845748667abe74be6ec1.camel@telenet.be> (Maxime Devos's message of "Wed, 15 Jun 2022 22:47:07 +0200")

Maxime Devos <maximedevos@telenet.be> skribis:

> Ludovic Courtès schreef op wo 15-06-2022 om 22:29 [+0200]:
>> +  (computed-file name
>> +                 (with-imported-modules '((guix build utils))
>> +                   #~(begin
>> +                       (use-modules (guix build utils))
>> +
>> +                       ;; Support non-ASCII file names.
>> +                       (setenv "GUIX_LOCPATH"
>> +                               #+(file-append glibc-utf8-locales
>> +                                              "/lib/locale"))
>> +                       (setlocale LC_ALL "en_US.utf8")
>
> For robustness, I think it would be best to move this locale
> initialisation code to the implementation of 'computed-file' itself, to
> eliminate this potential pitfall entirely.

I’d rather have ‘computed-file’ do just what it’s documented to do; I
don’t think this kind of thing belongs there.  (It’s beyond the scope of
this patch set too.)

Ideally Guile would just do the right thing without us fiddling with
locales.  That is, it would default to UTF-8 rather than ASCII.

Thanks,
Ludo’.

  reply	other threads:[~2022-06-16 11:12 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-11 16:49 [bug#55912] [PATCH] home: Add OpenSSH service Ludovic Courtès
2022-06-11 19:51 ` Maxime Devos
2022-06-11 22:13   ` Maxime Devos
2022-06-13  9:41   ` Ludovic Courtès
2022-06-13 10:51     ` Maxime Devos
2022-06-13 12:02       ` Ludovic Courtès
2022-06-13 12:38         ` Maxime Devos
2022-06-13 21:58     ` Maxime Devos
2022-06-14  8:08       ` Ludovic Courtès
2022-06-15 20:29   ` [bug#55912] [PATCH v2] " Ludovic Courtès
2022-06-15 20:47     ` Maxime Devos
2022-06-16 10:47       ` Ludovic Courtès [this message]
2022-06-16 12:16         ` Maxime Devos
2022-06-16 12:31           ` Maxime Devos
2022-06-16 16:18           ` [bug#55912] [PATCH] " Ludovic Courtès
2022-06-16 16:45             ` Maxime Devos
2022-06-17 12:32               ` Ludovic Courtès
2022-06-17 12:42               ` Philip McGrath
2022-06-17 20:56                 ` Maxime Devos
2022-06-18 21:41     ` bug#55912: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wndglwbd.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=55912@debbugs.gnu.org \
    --cc=maximedevos@telenet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).