From: "Ludovic Courtès" <ludo@gnu.org>
To: "Edison Ibáñez" <arkhan@riseup.net>
Cc: 56454@debbugs.gnu.org
Subject: [bug#56454] [PATCH] gnu: xonsh: Update to 0.13.0
Date: Sun, 10 Jul 2022 23:54:15 +0200 [thread overview]
Message-ID: <87wnckpraw.fsf@gnu.org> (raw)
In-Reply-To: <87tu7rvdl0.fsf@riseup.net> ("Edison Ibáñez"'s message of "Fri, 08 Jul 2022 10:17:15 -0500")
Hi,
Edison Ibáñez <arkhan@riseup.net> skribis:
>>From 6aa6764e9b2c13e91afcd73f3725db9db446c699 Mon Sep 17 00:00:00 2001
> From: arkhan <arkhan@riseup.net>
> Date: Fri, 8 Jul 2022 09:52:54 -0500
> Subject: [PATCH] gnu: update xonsh to 1.3.0
>
> ---
> gnu/packages/shells.scm | 17 +++++++++++------
[...]
> + (version "0.13.0")
> (source
> (origin
> (method url-fetch)
> @@ -554,15 +556,12 @@ (define-public xonsh
> (base32 "0xlac84nsgs0052n2pw8np1smlgghrbd7p6yrcp7d5qh8zdr9lx3"))
Look like you forgot to update the hash, which leads to:
--8<---------------cut here---------------start------------->8---
downloading from https://files.pythonhosted.org/packages/source/x/xonsh/xonsh-0.13.0.tar.gz ...
xonsh-0.13.0.tar.gz 751KiB 17.1MiB/s 00:00 [##################] 100.0%
sha256 hash mismatch for /gnu/store/jy4fj2bbgrmhi164z3qk6423mhdzma00-xonsh-0.13.0.tar.gz:
expected hash: 0xlac84nsgs0052n2pw8np1smlgghrbd7p6yrcp7d5qh8zdr9lx3
actual hash: 12ayz1kw2ag3r407j0lng2kfp75im8xqap1nvpmpa0lmsx8wk7ll
hash mismatch for store item '/gnu/store/jy4fj2bbgrmhi164z3qk6423mhdzma00-xonsh-0.13.0.tar.gz'
--8<---------------cut here---------------end--------------->8---
> (inputs
> - (list python-ply))
> + (list python-distro
> + python-ply
> + python-pygments
> + python-pyperclip
> + python-setproctitle
> + python-setuptools
> + python-wheel))
‘guix lint’ reports this:
--8<---------------cut here---------------start------------->8---
$ ./pre-inst-env guix lint xonsh
gnu/packages/shells.scm:589:5: xonsh@0.13.0: 'python-setuptools' should probably not be an input at all
--8<---------------cut here---------------end--------------->8---
Is setuptools used at run time? If not, which is likely, it probably
shouldn’t be there.
Could you send an updated patch?
Bonus points if you can provide a ChangeLog-style commit log. :-)
https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html
Thanks,
Ludo’.
next prev parent reply other threads:[~2022-07-10 21:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-08 15:17 [bug#56454] [PATCH] gnu: xonsh: Update to 0.13.0 Edison Ibáñez
2022-07-10 21:54 ` Ludovic Courtès [this message]
2022-07-11 15:10 ` Edison Ibáñez
2022-07-11 15:07 ` Edison Ibáñez
2022-07-11 20:01 ` bug#56454: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wnckpraw.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=56454@debbugs.gnu.org \
--cc=arkhan@riseup.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).