From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id sIswBz2rmGO48gAAbAwnHQ (envelope-from ) for ; Tue, 13 Dec 2022 17:41:33 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id gMFYBj2rmGNqIwAAG6o9tA (envelope-from ) for ; Tue, 13 Dec 2022 17:41:33 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B8E9B13BFE for ; Tue, 13 Dec 2022 17:41:32 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p58L3-0005Bl-RO; Tue, 13 Dec 2022 11:41:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p58L0-00057D-P0 for guix-patches@gnu.org; Tue, 13 Dec 2022 11:41:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p58L0-0006sK-HG for guix-patches@gnu.org; Tue, 13 Dec 2022 11:41:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p58Kz-0006Ar-Sk for guix-patches@gnu.org; Tue, 13 Dec 2022 11:41:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#58136] [PATCH] ui: Improve sort order when searching package names. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 13 Dec 2022 16:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58136 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: moreinfo patch To: Lars-Dominik Braun Cc: 58136@debbugs.gnu.org Received: via spool by 58136-submit@debbugs.gnu.org id=B58136.167094965223707 (code B ref 58136); Tue, 13 Dec 2022 16:41:01 +0000 Received: (at 58136) by debbugs.gnu.org; 13 Dec 2022 16:40:52 +0000 Received: from localhost ([127.0.0.1]:33270 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p58Kq-0006AJ-Ck for submit@debbugs.gnu.org; Tue, 13 Dec 2022 11:40:52 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48660) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p58Kn-0006AA-8T for 58136@debbugs.gnu.org; Tue, 13 Dec 2022 11:40:51 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p58Kg-0006nU-Et; Tue, 13 Dec 2022 11:40:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=Kho8Mu9yAo+6OpyU6synf2XX7pPmvBu0QPL1AKnbVd8=; b=T3aa8L3sRJd9PYzuZ94p yUc/KhsJ2nfD0coThB7l+6b5jK8GHVEdCRLm5hBTnjSaFYCoxgLhi794CJywp3709tjJXYF6PeRX9 dAnTJg8hbvJd0PurxSQPKyCYZahHanzJJ57V/rDQkf0tjkHmIimgQtlsREDhb7Mw2pvmrA/o9rfua nZm0aivXYlAmCdAF5MM/ip/QQWszgpCgvdKsVAt8MAbPOEGJwn55SJd87Ho6bUHqtS3ympRf24xMq 2uK1XDDgtB1Ph3Ca+CIOhCeRgoQHVCcLMeh17dXf+WBNY7RFJbm6hEsz6ZIrVvfTmmH3i9ISo2q3y oh7PkrD8nTohWQ==; Received: from eduroam-111172.grenet.fr ([130.190.111.172] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p58Kf-0008FS-S1; Tue, 13 Dec 2022 11:40:42 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87fsdjwhyd.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Tridi 23 Frimaire an 231 de la =?UTF-8?Q?R=C3=A9volution, ?= jour du Roseau X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 13 Dec 2022 17:40:36 +0100 In-Reply-To: (Lars-Dominik Braun's message of "Tue, 13 Dec 2022 15:53:41 +0100") Message-ID: <87wn6vuuij.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1670949692; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Kho8Mu9yAo+6OpyU6synf2XX7pPmvBu0QPL1AKnbVd8=; b=IOUlaY4/r8MPJahRqUfVG7a4X9RhXm4Ehkc4ePiFgKs/iD/scdN3z9V+tU4R8Gk+ftd4Zs lauWnxG3V3PPyaO5es6a5CgJ0r9hIxoL+Pyov+MZJXH+pgEyHmLal/njwBCOpzXBEbAt1k +Lt3z9hmSWnqLfCQehzOYBbtfBIN+tIbwh/Pjes5EJ9i6e5NLEG7AywAVwfjXxDDOF8S/k rP7XxfSSCl5y0IxvQ16o9QWX7UxkSDaL1wdU4xIKpRDL1hM0SIoMUepyY5Egi/+iDcL6+E Ne6h0NTImK67J0wQA9KwqNZ854+EBPfZ5LS9Y+nI+yk6La2qPQw9cPWJ2YRzew== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=T3aa8L3s; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1670949692; a=rsa-sha256; cv=none; b=Nghja3HT8e6F+BfPUM6x9RM8TvYXUqMhuj+AGIx0IYzePSbXTYax4knNWf4G11oF5Ozb5L fLpW6mLuzxzFS/lbI6V97RQa8fkUydHcprNGbwvWhmP1mx8Cad6+DuVwvnzr/eAcivANkG pQHrz70qzkxb8eFulnN3SS6oPv5wQZeLYgdU65nGHSwyEfrNYtG4QMxDEYF7Ao/hJ9T9MF AUdWIRme3OT54QB9xVHPEe9085iuH3rlttvPgPPfgYGUZmqaPIhL8k+cE6w4fpHyoHcjcL zPYYPz9xKVomWkRFRhurE3RKh4myDsT1r6e5vCqjnEETSVrUUG3quWKkfSU1Yg== X-Migadu-Spam-Score: -2.37 X-Spam-Score: -2.37 X-Migadu-Queue-Id: B8E9B13BFE X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=T3aa8L3s; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org X-TUID: mpIU+bwHS5eY Hi, Lars-Dominik Braun skribis: >> Applied with the minor changes below, thank you! > thank you! > >> +(test-assert "package-relevance and upstream name" >> + ;; https://issues.guix.gnu.org/58136 >> + (let ((ggplot2 (specification->package "r-ggplot2")) >> + (ggstance (specification->package "r-ggstance")) >> + (rx (make-regexp "ggplot2" regexp/icase))) >> + (> (package-relevance ggplot2 (list rx)) >> + (package-relevance ggstance (list rx)) >> + 0))) > I was hesitant to add a system test, which depends on real package > descriptions (not synthetic ones), because at some point it *will* break. Yes, that=E2=80=99s a tradeoff. For now, I would think the test is a plus = as it will allow us to see if future tweaks break this use case but yeah, on the day it breaks, we=E2=80=99ll have to rewrite it or to drop it. Ludo=E2=80=99.