unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Attila Lendvai <attila@lendvai.name>
Cc: 54836@debbugs.gnu.org, "Ludovic Courtès" <ludo@gnu.org>
Subject: [bug#54836] [PATCH 1/2] http-client: Fix redirection.
Date: Tue, 03 Jan 2023 17:29:33 -0500	[thread overview]
Message-ID: <87wn63xnea.fsf_-_@gmail.com> (raw)
In-Reply-To: <8735hyjlix.fsf@gnu.org> ("Ludovic Courtès"'s message of "Wed, 27 Apr 2022 22:53:26 +0200")

Hi Attila,

Ludovic Courtès <ludo@gnu.org> writes:

> Hi,
>
> And sorry for the delay.
>
> Attila Lendvai <attila@lendvai.name> skribis:
>
>>> > It's not enough to just handle the thrown exception, because we need to be
>>> > able to get hold of the fetched content, too.
>>>
>>> Would it make sense, then, to use the lower-level ‘http-get’ from (web
>>> client)? That would let the code deal with all the HTTP idiosyncrasies.
>>
>>
>> i think it boils down to this trade-off:
>>
>> 1) keep http-fetch simpler, at the expense of reimplementing parts of
>>    it in the go importer (e.g. the redirection logic)
>>
>> 2) add this extra complexity to http-fetch, and avoid the extra
>>    complexity of a local, potentially half-assed %http-fetch in the go
>>    importer.
>>
>> 3) something else i'm not aware of
>
> For now, I’m somewhat in favor of #1.
>
> My take would be: try to implement whatever’s needed specifically for
> the Go importer; from there, we can eventually revisit that situation
> and maybe switch to something that’s more like #2.
>
> How does that sound?

I think we're missing your reworked 1/3 patch here, taking into account the above
feedback from Ludo.

-- 
Thanks,
Maxim




  reply	other threads:[~2023-01-03 22:30 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-10 13:34 [bug#54836] [PATCH 1/2] http-client: Fix redirection Attila Lendvai
2022-04-10 13:35 ` [bug#54836] [PATCH 2/2] http-client: Factor out open-connection*, rename variables Attila Lendvai
2022-04-10 13:41 ` [bug#54836] [PATCH v2 1/3] http-client: Added accept-all-response-codes? argument Attila Lendvai
2022-04-10 13:41   ` [bug#54836] [PATCH 2/3] http-client: Fix redirection Attila Lendvai
2022-04-11 12:44     ` [bug#54836] [PATCH 1/2] " Ludovic Courtès
2022-04-10 13:41   ` [bug#54836] [PATCH 3/3] http-client: Factor out open-connection*, rename variables Attila Lendvai
2022-04-11 12:45   ` [bug#54836] [PATCH 1/2] http-client: Fix redirection Ludovic Courtès
2022-04-12  7:28     ` Attila Lendvai
2022-04-27 16:37       ` Attila Lendvai
2022-04-27 20:53       ` Ludovic Courtès
2023-01-03 22:29         ` Maxim Cournoyer [this message]
2022-04-28 10:22 ` [bug#54836] [PATCH v3] http-client: Factor out open-connection*, rename variables Attila Lendvai
2023-01-06 18:46 ` [bug#54836] [PATCH v4 1/2] " Attila Lendvai
2023-01-06 18:46   ` [bug#54836] [PATCH v4 2/2] http-client: Added accept-all-response-codes? argument Attila Lendvai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wn63xnea.fsf_-_@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=54836@debbugs.gnu.org \
    --cc=attila@lendvai.name \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).