From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Vagrant Cascadian <vagrant@reproducible-builds.org>
Cc: 60941@debbugs.gnu.org
Subject: [bug#60941] Update diffoscope to 232
Date: Sun, 22 Jan 2023 20:04:45 -0500 [thread overview]
Message-ID: <87wn5eysb6.fsf@gmail.com> (raw)
In-Reply-To: <87fsc36yh4.fsf@contorta> (Vagrant Cascadian's message of "Sat, 21 Jan 2023 19:26:47 -0800")
Hi,
Vagrant Cascadian <vagrant@reproducible-builds.org> writes:
[...]
>>> diff --git a/gnu/packages/diffoscope.scm b/gnu/packages/diffoscope.scm
>>> index f730d976fe..59875c2e8e 100644
>>> --- a/gnu/packages/diffoscope.scm
>>> +++ b/gnu/packages/diffoscope.scm
> ...
>>> + (add-after 'unpack 'remove-mono-external-tool
>>> + ;; Fixed upstream, remove this phase when updating to
>>> + ;; diffoscope 233
>>> + (lambda _
>>> + (substitute* "diffoscope/external_tools.py"
>>> + ;; "guix": "mono",
>>> + ((".guix.: .mono.,")
>>> + ""))))
>>> (add-after 'build 'build-man-page
>>> (lambda* (#:key (make-flags '()) #:allow-other-keys)
>>
>> There are no #:make-flags argument for the python or pyproject build
>> systems, so that's useless.
>
> I would welcome a fix for that... I could not figure out how to make it
> build successfully without it, but that does not say a whole lot. :)
I addressed it in a subsequent commit ("gnu: diffoscope: Simplify the
build-man-page phase.").
--
Thanks,
Maxim
next prev parent reply other threads:[~2023-01-23 1:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 1:31 [bug#60941] Update diffoscope to 232 Vagrant Cascadian
[not found] ` <handler.60941.B.16740919305557.ack@debbugs.gnu.org>
2023-01-19 1:36 ` [bug#60941] [PATCH 1/2] gnu: Add python-pypdf Vagrant Cascadian
2023-01-19 1:38 ` [bug#60941] [PATCH 2/2] gnu: diffoscope: Update to 232 Vagrant Cascadian
2023-01-19 1:48 ` [bug#60941] Update diffoscope " Maxim Cournoyer
2023-01-22 3:26 ` Vagrant Cascadian
2023-01-23 1:04 ` Maxim Cournoyer [this message]
2023-01-22 3:32 ` [bug#60941] [PATCH v2 2/2] gnu: diffoscope: Update to 233 Vagrant Cascadian
2023-01-19 1:42 ` [bug#60941] [PATCH 1/2] gnu: Add python-pypdf Maxim Cournoyer
2023-01-22 3:30 ` [bug#60941] [PATCH v2 " Vagrant Cascadian
2023-01-22 7:03 ` [bug#60941] [PATCH v3 " Vagrant Cascadian
2023-01-22 7:06 ` [bug#60941] [PATCH v3 2/2] gnu: diffoscope: Update to 233 Vagrant Cascadian
2023-01-23 1:07 ` bug#60941: " Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wn5eysb6.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=60941@debbugs.gnu.org \
--cc=vagrant@reproducible-builds.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).