From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id aLqkC3L/4mNEagEAbAwnHQ (envelope-from ) for ; Wed, 08 Feb 2023 02:48:34 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id CPWIC3L/4mMPMgAAauVa8A (envelope-from ) for ; Wed, 08 Feb 2023 02:48:34 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 070EE9571 for ; Wed, 8 Feb 2023 02:48:33 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pPZZ7-0006L8-Bu; Tue, 07 Feb 2023 20:48:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPZZ5-0006KZ-4K for guix-patches@gnu.org; Tue, 07 Feb 2023 20:48:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pPZZ4-0007rB-SA for guix-patches@gnu.org; Tue, 07 Feb 2023 20:48:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pPZZ4-0004LD-OV for guix-patches@gnu.org; Tue, 07 Feb 2023 20:48:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60673] [PATCH 01/39] gnu: Add ocaml-domain-name. Resent-From: Csepp Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 08 Feb 2023 01:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60673 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: moreinfo patch To: Christopher Baines Cc: 60673@debbugs.gnu.org, raingloom@riseup.net X-Debbugs-Original-Cc: 60673@debbugs.gnu.org, Csepp , guix-patches@gnu.org Received: via spool by 60673-submit@debbugs.gnu.org id=B60673.167582087916656 (code B ref 60673); Wed, 08 Feb 2023 01:48:02 +0000 Received: (at 60673) by debbugs.gnu.org; 8 Feb 2023 01:47:59 +0000 Received: from localhost ([127.0.0.1]:54335 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPZZ1-0004KZ-Gd for submit@debbugs.gnu.org; Tue, 07 Feb 2023 20:47:59 -0500 Received: from mx0.riseup.net ([198.252.153.6]:55388) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPZYz-0004JX-GQ for 60673@debbugs.gnu.org; Tue, 07 Feb 2023 20:47:57 -0500 Received: from fews2.riseup.net (fews2-pn.riseup.net [10.0.1.84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mail.riseup.net", Issuer "R3" (not verified)) by mx0.riseup.net (Postfix) with ESMTPS id 4PBNDS0QZBz9tGK; Wed, 8 Feb 2023 01:47:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1675820872; bh=KgWzVxERTrf07ne0aklTDVemeOqAut40aqm/MacA15E=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=Pj7ZLkHkPZ2hl+G+C0dEc8Wvq+bdLTmurAyFPs4ibVpONZDqjAfdMvVvP8Vw0iROC ShS7SNw5uwY9IAREwHDgAvzC45TQEbFrvOhFR635QWilOx21ZcF9fEt2gUI63oMEjJ 6a7Y2END6osWkpCX9L++uVDYeJlUUagdiaN3+uPY= X-Riseup-User-ID: B34BB363BDD0B34CC9AFD24DD45DF21F6D5794AA94B055AB9014B308E3DA00FD Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews2.riseup.net (Postfix) with ESMTPSA id 4PBNDR2Kfhz1yBT; Wed, 8 Feb 2023 01:47:51 +0000 (UTC) References: <20230109003529.23375-1-raingloom@riseup.net> <874jrxdhxi.fsf@cbaines.net> From: Csepp Date: Wed, 08 Feb 2023 02:37:48 +0100 In-reply-to: <874jrxdhxi.fsf@cbaines.net> Message-ID: <87wn4t2aik.fsf@riseup.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=riseup.net header.s=squak header.b=Pj7ZLkHk; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=riseup.net (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1675820914; a=rsa-sha256; cv=none; b=UNBLtCr+e4N0FyIxR0utouGGKKLoPzARXctlbzT+XbbIsWXMfQ21I8Qqt/NT8UIobYDhuq eVNSN/Q2u/58CJL6No601Ju0yc95DxNgR6nqsOpE0WKVA6vSdARJX+ol+jHK28Bl19JUwO OwCl4gr6Uj1/Jmd9ihk104TQkrzwEb+SWrVlOGj8mLcTECizDiKfqK+10PjgDH4th6nkpw BvGeMQX0k9yMU1Wi1tIZuI40RX57lt7rgDZRouHUuJRWYcNen4uyxSchheqLAA0RIt4N13 pF+MvBOgWL/oapK4nhZGmcvfyNLHG6xl2rPoqN4NMZSZ2xLejEfQ+6JCV10xoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1675820914; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=1/Qj9go5DqqVYVEHZT1epx+i5pDe3yDmx6iVi52y908=; b=uWlh3GOTxmB8IUScLc9dRHuC9kTUTFRP1M54rH0xTXido6GkG6RJJX0T2N3xn35cabkuNp lco1OuRVwKaQh7tYSyuw/q1ias7P4YzQhalLbEHceldWfQWBL/aP8gZycAM/pmv9cLiRot XNi2vyFlV6Ok3TGWaSRYzfotovXZ886+iTDfCuwYyDL1MTPhfn+KMM5sMd2UAZbntLd6Lu I/TZDCWl5Lyl5zDHN1uo1eKe1S/qP0wFqXSgS/1mFg9zkAVpGvlFjX8VF6oGs1MPBn7xIm kdrMwgtl+at4Q71h6cubJ/IRvoz2Z1eAnU6NLZ8qeJtdIvLm+ie8hB8jTnnCjQ== X-Migadu-Spam-Score: -0.59 X-Spam-Score: -0.59 X-Migadu-Queue-Id: 070EE9571 X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=riseup.net header.s=squak header.b=Pj7ZLkHk; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=riseup.net (policy=none) X-TUID: 5roO9ZnyVtje Christopher Baines writes: > [[PGP Signed Part:Undecided]] > Hey, > > While I think the builds look OK for this series, there are quite a few > formatting issues raised by the linter (this can be seen on [1] and [2]). > > 1: https://qa.guix.gnu.org/issue/60674 > 2: > https://data.qa.guix.gnu.org/compare?base_commit=238f965c331990459a69cbc713ca951ad40e6044&target_commit=3b5485b9cdaebda127dc040ad67a287f39e33519 > > Could you run the linter on the packages you've added here, address the > issues it raises and send an updated series? > > Thanks, > > Chris > > [[End of PGP Signed Part]] Those are all URL constants, can't really do much about them other than slice them up with string-append, which I'm not sure really helps with readability or ease of editing. They were not an issue while I was editing the code and gnu/packages/ocaml.scm already has a lot of lines that whitespace-mode highlights as too long, so I thought it wouldn't matter much and my time would be better spent elsewhere. The real fix IMHO would be to convert them into git-fetch origins, which would also make it possible to use git related package transforms. This is on my TODO list. Or at least the OPAM importer should be changed to do the URL splitting.