From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id WLuKKu37JWSZ6wAASxT56A (envelope-from ) for ; Thu, 30 Mar 2023 23:15:25 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 2P+JKu37JWQDdgEA9RJhRA (envelope-from ) for ; Thu, 30 Mar 2023 23:15:25 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 293938498 for ; Thu, 30 Mar 2023 23:15:25 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1phzbt-0002aW-Ai; Thu, 30 Mar 2023 17:15:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phzbr-0002aN-SV for guix-patches@gnu.org; Thu, 30 Mar 2023 17:15:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1phzbr-0006V5-4c for guix-patches@gnu.org; Thu, 30 Mar 2023 17:15:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1phzbq-0005nC-KN for guix-patches@gnu.org; Thu, 30 Mar 2023 17:15:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#61774] [PATCH] gnu: Add luarocks. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 30 Mar 2023 21:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61774 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Timo Wilken Cc: 61774@debbugs.gnu.org Received: via spool by 61774-submit@debbugs.gnu.org id=B61774.168021090022247 (code B ref 61774); Thu, 30 Mar 2023 21:15:02 +0000 Received: (at 61774) by debbugs.gnu.org; 30 Mar 2023 21:15:00 +0000 Received: from localhost ([127.0.0.1]:59588 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phzbn-0005mk-VN for submit@debbugs.gnu.org; Thu, 30 Mar 2023 17:15:00 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41964) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phzbl-0005mN-St for 61774@debbugs.gnu.org; Thu, 30 Mar 2023 17:14:58 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phzbg-0006T0-4v; Thu, 30 Mar 2023 17:14:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=n/sIinvZR+Ag81efjbNa524exMmzsYTCiJEvpScUVzI=; b=Pm5BVDVZ4IU77WDvdnfk tkl+vd69dK9Xr1mJqcbhevSerlVBTCN01W9qugoLVE+Lx36aikoJVm0X/ihaAWGds1TWKgeW/TFP6 QSYi4DwQHmbvC6lr5+a3NkbUL4nYfbqOQBDUAP9oD5bb57pPi4kCu2W6kmOPz291rxTF/1nJWVykF Q4yTCHwPZeTX2BekbWqAAOKb4huMa8zDYleOgV8G6z6SzYGNm0tfum7jm2O+iOAt0ri5d+frteYUQ s+XhIcVTZTgrtXFnN96qygDLlRnm2IRbGGQk1pV9Ya+K6t+ALfklGPpIicgGiOF/u8yrKNdMkd5TK zzQ05+ttAsHP0w==; Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phzbf-0004a0-Ha; Thu, 30 Mar 2023 17:14:51 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20230224224613.25630-1-guix@twilken.net> Date: Thu, 30 Mar 2023 23:14:49 +0200 In-Reply-To: <20230224224613.25630-1-guix@twilken.net> (Timo Wilken's message of "Fri, 24 Feb 2023 23:46:13 +0100") Message-ID: <87wn2ygcvq.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1680210925; a=rsa-sha256; cv=none; b=tlFzpPtQRpTdl6Px56B2m+dO8DCv8W2KT+UbgQYndC+/kEg4EvL88DIQGLLSJq83uZpjOE YGDahZppTQtpSnegJhBsLXCRsPSu0j/LitwOBLdFKEZGiCt+r03+7huZ9Gekm17tMMIHvo s040Z09k1afMFyihm0AUDFNy2iLpoKUPHiNl4PPzsFAE5ExkNZhIPFb+vxT77r4+v8pSK5 gX4UqL8zJWNg0xpOUKjpYC+22mSudIrTgyesXKE1DqgXI7UAGg8OwueQQBvnx4u/WtCwo7 SddnVhP9gA4NSq4QSPW4j89hl48loa8CaIvD9M7DZv2LMTuerjOcyy9PSnDkuQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Pm5BVDVZ; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1680210925; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=n/sIinvZR+Ag81efjbNa524exMmzsYTCiJEvpScUVzI=; b=ckPW7n1LChQ4aF1eXa9S1GBAvMh8AhoxfiPp3DAJ7pnbfZsv05jls8Ux9I1C3YDVe4E43M dxrrE+kKZFYhuUUFkwHurhsxLuyBTM37izkl9liyk5/Coqsl4EmypuxjH7sN0KfVB01NVw rRcAL0eX0Z2MdLgZzPzkB9HT6UWMTc1TG9NdE0rBqmlVoXelnRL+eCyykccV13y+fCenHv 52aK7nCQ307veBnACAKUeYZkid0LymET5dLsTQrkrD3pQCNTMlLyMfGDY3m+0tAOimYGvd EkSv/qVt6ynmCUfyGFEHh4STMhHeY9LkizyEJ5hiqO5Er7YQPFciZ/v/L3KHxw== X-Migadu-Spam-Score: -4.12 X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Pm5BVDVZ; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Spam-Score: -4.12 X-Migadu-Queue-Id: 293938498 X-TUID: 67AQr5dHvrKh Hi, Timo Wilken skribis: > Luarocks is a package manager for Lua modules. > > It is used by the Prosody XMPP server (already packaged in Guix) to > install extensions. > > * gnu/packages/lua.scm (luarocks): Add variable. Could resend the two patches merged as one? Some comments: > + (substitute* '("GNUmakefile" "src/luarocks/fs/unix= .lua" > + "src/luarocks/core/sysdetect.lua") > + (("/bin/sh") > + (string-append (assoc-ref inputs "bash-minimal") > + "/bin/sh"))))) Rather (search-input-file inputs "/bin/sh"). > + (synopsis "A package manager for Lua modules") I believe =E2=80=98guix lint=E2=80=99 will tel you to remove =E2=80=9CA=E2= =80=9D. :-) > + ;; The home page says: > + ;; "LuaRocks is free software and uses the same license as Lua." > + (license license:x11))) Please double-check the license in the source (and remove the comment). > + (add-after 'install 'patch-unzip > + (lambda* (#:key inputs outputs #:allow-other-keys) > + (substitute* > + (string-append > + (assoc-ref outputs "out") "/etc/luarocks/config-" > + ,(substring (package-version lua) 0 3) ".lua") ;e.g. "= 5.2" > + (("variables =3D \\{") > + (string-append > + "variables =3D {\n" > + " AR =3D \"" (assoc-ref inputs "binutils") "/bin/ar\"= ;\n" > + " BUNZIP2 =3D \"" (assoc-ref inputs "bzip2") "/bin/bu= nzip2\";\n" > + " CC =3D \"" (assoc-ref inputs "gcc") "/bin/gcc\";\n" > + " CHMOD =3D \"" (assoc-ref inputs "coreutils") "/bin/= chmod\";\n" > + " CMAKE =3D \"" (assoc-ref inputs "coreutils") "/bin/= cmake\";\n" These should all use =E2=80=98search-input-file=E2=80=99. However=E2=80=A6 > + " CP =3D \"" (assoc-ref inputs "coreutils") "/bin/cp\= ";\n" > + " CURL =3D \"" (assoc-ref inputs "curl") "/bin/curl\"= ;\n" > + " CVS =3D \"" (assoc-ref inputs "cvs") "/bin/cvs\";\n" > + " FIND =3D \"" (assoc-ref inputs "findutils") "/bin/f= ind\";\n" > + " GIT =3D \"" (assoc-ref inputs "git") "/bin/git\";\n" > + " GPG =3D \"" (assoc-ref inputs "gnupg") "/bin/gpg\";= \n" [...] > + " RSYNC =3D \"" (assoc-ref inputs "rsync") "/bin/rsyn= c\";\n" > + " SCP =3D \"" (assoc-ref inputs "openssh") "/bin/scp\= ";\n" > + " SEVENZ =3D \"" (assoc-ref inputs "p7zip") "/bin/7z\= ";\n" > + " SVN =3D \"" (assoc-ref inputs "subversion") "/bin/s= vn\";\n" > + " TAR =3D \"" (assoc-ref inputs "tar") "/bin/tar\";\n" Does it really need all these things? What does =E2=80=98guix size luarock= s=E2=80=99 say now? Maybe it=E2=80=99s OK to assume that some of the rarely-used dependencies (= say, CVS, SVN, 7zip) will be picked from $PATH and that it will fail otherwise? That would help keep the closure size under control. > + (inputs (list lua bash-minimal > + ;; Executables required by luarocks. > + binutils bzip2 coreutils curl cvs findutils gcc git gn= upg > + gzip gnu-make mercurial openssh openssl p7zip rsync > + subversion tar unzip wget zip)) Please one per line since there are many of them (you can run =E2=80=98guix style luarocks=E2=80=99). Could you send an updated patch? Thanks! Ludo=E2=80=99.