From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id i1zSNWbaXWS+pwAASxT56A (envelope-from ) for ; Fri, 12 May 2023 08:19:18 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id KD/hNGbaXWQQBQEAauVa8A (envelope-from ) for ; Fri, 12 May 2023 08:19:18 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 62CE747453 for ; Fri, 12 May 2023 08:19:18 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pxM7U-0005aQ-1R; Fri, 12 May 2023 02:19:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pxM7L-0005XN-7Y for guix-patches@gnu.org; Fri, 12 May 2023 02:19:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pxM7K-0002Ju-Ug for guix-patches@gnu.org; Fri, 12 May 2023 02:19:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pxM7K-0006y2-M6 for guix-patches@gnu.org; Fri, 12 May 2023 02:19:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63435] Add vcmi 1.2.1 to games.scm Resent-From: Vagrant Cascadian Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 12 May 2023 06:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63435 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Liliana Marie Prikler , 63435@debbugs.gnu.org Cc: iyzsong@envs.net Received: via spool by 63435-submit@debbugs.gnu.org id=B63435.168387228226685 (code B ref 63435); Fri, 12 May 2023 06:19:02 +0000 Received: (at 63435) by debbugs.gnu.org; 12 May 2023 06:18:02 +0000 Received: from localhost ([127.0.0.1]:53810 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxM6L-0006wA-Ew for submit@debbugs.gnu.org; Fri, 12 May 2023 02:18:02 -0400 Received: from cascadia.aikidev.net ([173.255.214.101]:46836) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxM6J-0006vo-NU for 63435@debbugs.gnu.org; Fri, 12 May 2023 02:18:00 -0400 Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:50]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 278371ACEF; Thu, 11 May 2023 23:17:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=debian.org; s=1.vagrant.user; t=1683872270; bh=OFYMPSExDE9xpYCnpW3lmLcdbpcQ+ljfpHELpaxRs5E=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=WwGXiOoj8GX70fpW6ZWsNiMDC+3qPoy+ZHg0cEGyjXK3JeRGsJeEUcVC5FElf3A57 njpUY5807NTaN3P8+XLCOxfHKmuOA9Pj6kRnlZ2LbNOb8+DLL9HMVbMFWpgTB/sy3y dSFKDiCm7LX5sh76+JULfeHZPj2xTDp8w211jathY94T+jRzuCGAfSBnlVNbS/xCXh +Twln8mAfLUAJpoWeRlH3lMx3rV6TG11peEcVoAsOByq0bMnWm9oBlOR0ls0I6dRB4 baXxaP7LUOAJ0p9s4RPnDQOharSGyT98gns9a4cqZBtndWKmyd7PgqTPVcYr2gXtS6 8P1AeKf2x+C9g== From: Vagrant Cascadian In-Reply-To: <9ee9b4f47ee7c5af274074da89febdb4df9ca68d.camel@gmail.com> References: <87a5yb4e41.fsf@wireframe> <51be2fdd711bf490e3a925334e571ff7871d6cbb.camel@gmail.com> <873542o7ze.fsf@wireframe> <87zg6ampqf.fsf@wireframe> <9ee9b4f47ee7c5af274074da89febdb4df9ca68d.camel@gmail.com> Date: Thu, 11 May 2023 23:17:45 -0700 Message-ID: <87wn1em5ti.fsf@wireframe> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1683872358; a=rsa-sha256; cv=none; b=bpcVCJW1Wq5r5/QYoLkHSlduHaktuooGlxoQpKKSE4RHZ6tiabZ5967h8ZdUw92d6S/6S3 38vBn1TvWvVW6wgpIQywNgqXLB/PuTo9drc1RuwHbzOyrEhgLxMNGYb8n/X6egmy5u0YK1 63/RWLP4axxpr1WN2YacVQQstiMJ3mg3Xq6AbKRftk5j6cq6eK/850Xq8K4mvNcmql3vyG nDFRmzwMwDQHiB/RhtQMVwj0JQn4BV34rleGvVekLevt5D/JCw1IRqfQLiQ0wzqdTgV5GJ SYZ8Lvvil8KiPeDmUSmcuna9HPnHxkcJJ8CM9e/FbFkCJrXUPAT6JEIl91PVig== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debian.org header.s=1.vagrant.user header.b=WwGXiOoj; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1683872358; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=MRYM9+DTJjEf1r9MhhT1Wqb50fvDVrL6q8ASvVOSXy0=; b=E9m4dZ0eMRbywk0jtsPG+q8EJcYGBUftD00PygYNgF6d+xMw3or6RX1Ri0EpfWd07/PLvU Vzu7N7p6vxxD4AjDkj8iHTcsCdMoPb2jr+DFEhinPgVbqnthmXxmdkKlbOktOz8nxTAjV/ W55+duCSd5WQRSyHbjHymjffEgF50Ow17awcQIvkoSOeXYby298v5te3Ph+xMN3LxAcLdG bwi0cAIiQPOYgHZujX8iuGMGfmxsPcQjTreA+vP6dlx4MDtAp7CB5EDyhQAhOtva/TKBL/ JUnggt8ZdDD/yy8jcTMh26EtR3VD0uKO4KqUWACtdxbJ/5SGs0YNExuJ5ENmsQ== X-Migadu-Spam-Score: -3.58 X-Spam-Score: -3.58 X-Migadu-Queue-Id: 62CE747453 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debian.org header.s=1.vagrant.user header.b=WwGXiOoj; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-TUID: Ct+mXAWwN8rL --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On 2023-05-12, Liliana Marie Prikler wrote: > Am Donnerstag, dem 11.05.2023 um 16:07 -0700 schrieb Vagrant Cascadian: > >> +(define-public vcmi >> + (package >> + (name "vcmi") >> + (version "1.2.1") >> + (source (origin >> + (method git-fetch) >> + (uri (git-reference >> + (url "https://github.com/vcmi/vcmi") >> + (commit version) >> + (recursive? #t))) > Can we do without the recursive checkout? There is one component still used with the recursive checkout. ... AI/Fuzzy* I think? I do not know if it could be built independently, but I have not seriously looked into it. If tests were enabled, the googletest stuff might be needed; it was a bit unclear to me if the googletest packaged in guix could work. Regardless, tests are disabled upstream... so if there is a way to only download one and not the other, I guess that would save some bandwith. I *think* those are the only two things pulled in. >> + (file-name (git-file-name name version)) >> + (sha256 >> + (base32 >> +=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 >> "1nx3i078cxkak2ci514pf4pgi5269mp08njynsg35pin4yp3fn0p")) >> + (patches (search-patches "vcmi-disable-privacy- >> breach.patch")))) > IIRC the reproducible builds patch is still missing, right? The Debian package implements building man pages and documentation outside of the upstream build system... It did not seem worth patching something that was not used to build anything... the reproducible builds patch(es) only apply to documentation which is not part of the upstream build process, so I left it out of this iteration. That said... Building vcmimanual.tex appears to be a one-liner, pulling in some tex related dependencies: https://salsa.debian.org/games-team/vcmi/-/blob/master/debian/rules#L56 And generating manpages used help2man and some templates debian ships: https://salsa.debian.org/games-team/vcmi/-/blob/master/debian/rules#L46-48 Not sure if the manpages are worth the effort, or if the manual is worth the larger dependency tree... >> + (native-inputs (list boost > Guix style is, like, a suggestion that can be wrong. You are allowed > to fight it when the result of doing so is demonstrably better. I get that ... but I also like just being able to run guix style and not having to make those judgement calls. Because other things guix style may change that are a good idea and it is really difficult to pick and choose which things to revert and which to keep over time... There are some things I think guix style does wrong(in particular, I always prefer one input per line to make diffs easier to read), but I do not hold strong opinions on guile coding style and just prefer to concede to guix style and bear with the results. I am also not strongly opinionated (it goes both ways, I guess!)... so for clarity, are you saying you would prefer: (native-inputs (list boost ... or: (native-inputs (list boost ... or something else? live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCZF3aCQAKCRDcUY/If5cW qslcAQDH7HIRNz8C/aVtGfZIJpFcGlyThKWYz2IallcXklEM0gD+P0Dr71hiaAuU YS3/ERY+rCu5vRIbqNrtYvED7dgl5gc= =qR6j -----END PGP SIGNATURE----- --=-=-=--