From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id cLLFCNNdZmQ8EgEASxT56A (envelope-from ) for ; Thu, 18 May 2023 19:18:11 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id WK9eCNNdZmRINwEAauVa8A (envelope-from ) for ; Thu, 18 May 2023 19:18:11 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DE9512C7EA for ; Thu, 18 May 2023 19:18:10 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pzhGO-0000q7-Jy; Thu, 18 May 2023 13:18:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzhGM-0000pp-Tl for guix-patches@gnu.org; Thu, 18 May 2023 13:18:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pzhGM-0001yo-Lf for guix-patches@gnu.org; Thu, 18 May 2023 13:18:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pzhGM-0000my-Gm for guix-patches@gnu.org; Thu, 18 May 2023 13:18:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63527] [PATCH 0/3] Initial attempt at rumpdisk support for the Hurd. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 18 May 2023 17:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63527 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Janneke Nieuwenhuizen Cc: 63527@debbugs.gnu.org Received: via spool by 63527-submit@debbugs.gnu.org id=B63527.16844302432977 (code B ref 63527); Thu, 18 May 2023 17:18:02 +0000 Received: (at 63527) by debbugs.gnu.org; 18 May 2023 17:17:23 +0000 Received: from localhost ([127.0.0.1]:54325 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzhFi-0000lw-Qs for submit@debbugs.gnu.org; Thu, 18 May 2023 13:17:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52374) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzhFg-0000lj-Bb for 63527@debbugs.gnu.org; Thu, 18 May 2023 13:17:20 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzhFa-0001qI-13; Thu, 18 May 2023 13:17:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=FRr1dhZoldnz7NX0IXabAIHDQWtEiM03Ppltrx0Rf7U=; b=h5a6AlX71tdlICryi2OX DpU84PGlgdKmZrBwjcHiVxuRNlvsVqx++wf7+qSubvjBx/xSZYiDvtgBIGwNYJIeS/MBeVRbTZYEv mJM+NkkW0Cetx69eUHixHOU59yMLL96yygS9ERTiEgRZmJ4eh7sscKPAd1T221s7nOtka0MGMTDyE EvPgL7cpuX1ar3C4ln7cUmuJuPl8nlo3BU5a2LHxMtI4WAWv4HYJQzkIbi+vZgCR1qnjlcz23+5H0 B/FckV6o9NYD3/cU80aDceZfjubuxbV8CQAuImXBj9GSX1Fa+88IdgPSE5V95TN5DHffHWkJ5A2Yl 9W5kYARNg3MnbA==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzhFZ-00010Y-KM; Thu, 18 May 2023 13:17:13 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: Date: Thu, 18 May 2023 19:17:11 +0200 In-Reply-To: (Janneke Nieuwenhuizen's message of "Thu, 18 May 2023 11:38:59 +0200") Message-ID: <87wn1536g8.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1684430290; a=rsa-sha256; cv=none; b=WgObgZYdE2/690MrGxNbgCQEhJqyzC7za5IqDPREYrZH1auXc36yjMHMlmXP6f+FaB+ge/ r0AZC8e1CvPhRY5SFxHM/SXx9L8SSEZROy74luAsnbT1Wg4o+zfS7ZlG/QhamRJ015wKMK kTymw4JCN1spLjDkrRqdiMBFMIlbNuzhf0R+7DLn6+Wc8fsydxqAOO8lCqzZ5V585aC0lz fI83gQeuR+U29ZtIUnGqdet+zKsZ4nMZR950VkL3RAEKrNXMk0MIo6BnNt7i8J6SJz4u/f dZrTIUm1/UPwkQAftR2YN6uIeq64vqhLSThum4WfOOTWAKJ+rJ/LhjugEx5SmQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=h5a6AlX7; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1684430290; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=FRr1dhZoldnz7NX0IXabAIHDQWtEiM03Ppltrx0Rf7U=; b=qiftQanJXpfL1m/W31LL3tumplyDNVDNXvh+wWQ/G93I5DsaYIfZS71M6bN312ANbludJu NQu2Vuzeiji4xUjeXW4GzgQKKHsOpKiKOH5ILjLBKajGpregMfTG3fxZR2UxOgaru+y0nX RoURUOIOf5MlYgPgcLSR6+CyAU1IFV/zc+3brxzWHGG0E3U+nq7dK7oFkdAGnTv5mm16OD 4HFPim2SeCgDYwxUiW26BcCllJpR0IbirYMf/C3ldECWXH66DA0klDn31w1LPyXgQXP16d F7TCpcLq9CWVJL9xFMkzjVnWroxG+ena5B9A5NoEG5JjKDWerL1TOcB5bixr3Q== X-Migadu-Spam-Score: -4.09 X-Spam-Score: -4.09 X-Migadu-Queue-Id: DE9512C7EA X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=h5a6AlX7; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-TUID: wdKxuW8tY5wD Janneke Nieuwenhuizen skribis: > This uses the Debian Salsa rumpkernel package git as upstream as that is = where > delopment happens. Once things have stabalized upstream may change to the > NetBSD git from where Debian takes their snapshots. Could you make it a comment close to the =E2=80=98origin=E2=80=99 form? > * gnu/packages/hurd.scm (rumpkernel): New variable. [=E2=80=A6] > + #~(modify-phases %standard-phases You can tell from the phases that it took of lot of sweat to get there. :-) Could you add a few comments while it=E2=80=99s fresh on your mind to expla= in the various tweaks? The =E2=80=98build=E2=80=99 phase is particularly inti= midating. > + (native-inputs > + (list > + autoconf > + automake > + libgcrypt > + (if (%current-target-system) > + (let* ((cross-base (resolve-interface '(gnu packages cross-b= ase))) > + (cross-mig (module-ref cross-base 'cross-mig))) > + (cross-mig (%current-target-system))) > + mig) I think you could #:use-module (gnu packages cross-base) and refer to =E2=80=98cross-mig=E2=80=99 directly. Also, watch out the indentation. ;-) (native-inputs (list autoconf automake =E2=80=A6)) > + (license (list > + asl2.0 > + boost1.0 Could you add a comment above briefly stating what this list means? (I suppose each license applies to a specific part of the source?) Anyhow, well done! Ludo=E2=80=99.