From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id EN2NG8ewtmSMPAEASxT56A (envelope-from ) for ; Tue, 18 Jul 2023 17:33:27 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id yLKcGsewtmSSDAAAG6o9tA (envelope-from ) for ; Tue, 18 Jul 2023 17:33:27 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C66F74A931 for ; Tue, 18 Jul 2023 17:33:26 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=QVH7zRf2; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1689694407; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=gSy44+9MVv/0xVqeRHH285rMKhZpkflM9AVY2c8/yjQ=; b=rX33PJ1oYPDJolZtOuPNRHX/gjq36fpQ8ouC7g1Ztw/1bRFYX4SpoDoIVpKThGHoPFqeu8 kO0JzifHAZeNP51eysOo/9Xisntm2u3hRZnkj0JgxEH4mbUbT9HZNovEPtyvHHvGR92F/x bBrRacg5RJmduUl82VwbwDIUUIKGKG5a19bFf68yrsIU83OJGtczoOVCzDcJe9VkhnRpj7 VV7FvYMRqLqYiZMA/JYh5CEksQXyFVi9uBz/N1Gl1shSHRyjRBj/dKL+9XliVcAhTV32sz Lv8lRY22csU81kTicwvZuJMMl3Ti+5gJ4WCPz/55ry7+VZe9hgyTTOjZqWlajg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=QVH7zRf2; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1689694407; a=rsa-sha256; cv=none; b=hThVwn6jWwBKmBN7nA/hq2b1ZuzuIrHQmsTuiQpBfIC7aFII92/cewVwDjnuUSCcn7dVMC D183aYP5IktyvOmy80Sk0+UhITvovjqxp2tRLUMbNLtZVYcF1QYD3Djfu9+wkVkmQfHsYt yg2htJmTGtJo3aGXB1Y6IgWkML9oucEkCvEAvi1Ag1Z8ZmbBZek5FPBXephMqAQOwBQ3MX 9IgpIlEFZ/xJrSjVDmu1rXqis7wNI43QEEXFxC93jFTqU6chqbHsz5+pToCMv4krHTbbzo KD11aJ46pKsYcSr7GblM6bbYvUNYjzmRJJ4QQcn01WTCEGZMaxrmKtKyY+KjYw== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qLmhF-0007wc-AO; Tue, 18 Jul 2023 11:33:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLmhC-0007wI-KH for guix-patches@gnu.org; Tue, 18 Jul 2023 11:33:02 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qLmhC-0004KL-Ck for guix-patches@gnu.org; Tue, 18 Jul 2023 11:33:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qLmhB-00086S-Tq for guix-patches@gnu.org; Tue, 18 Jul 2023 11:33:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63802] [mumi PATCH 0/3] Use consolidated X-Debbugs-Cc header Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 18 Jul 2023 15:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63802 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Arun Isaac Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 63802@debbugs.gnu.org Received: via spool by 63802-submit@debbugs.gnu.org id=B63802.168969436831129 (code B ref 63802); Tue, 18 Jul 2023 15:33:01 +0000 Received: (at 63802) by debbugs.gnu.org; 18 Jul 2023 15:32:48 +0000 Received: from localhost ([127.0.0.1]:53998 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLmgx-000860-Pm for submit@debbugs.gnu.org; Tue, 18 Jul 2023 11:32:48 -0400 Received: from mail-oa1-x34.google.com ([2001:4860:4864:20::34]:55626) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLmgv-00085l-3x for 63802@debbugs.gnu.org; Tue, 18 Jul 2023 11:32:46 -0400 Received: by mail-oa1-x34.google.com with SMTP id 586e51a60fabf-1b049163c93so3430198fac.3 for <63802@debbugs.gnu.org>; Tue, 18 Jul 2023 08:32:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689694359; x=1692286359; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=gSy44+9MVv/0xVqeRHH285rMKhZpkflM9AVY2c8/yjQ=; b=QVH7zRf2T9GVjUH+jqLdTE+Z3Z6sAz0Oxvf+MBryhvYDd8ueUStquU9etRmSRbuF3n iKZe5psd45hg43eCeJxzlYJ0HlaKc2X9ZrwUWB+zd43tQL9mmPan+CkLNqjf/ZeiP6E6 WpcnrGqcOTcUmRzJyRxlOZgJZ7TePMBuVStyQ/gTIqnUS8BcrcjqY/ZqIAIbjLTQUxW5 /omyexePhRYDoB2n3fZdujEHeZWOK9UFbi9uxgXfxgoqMbO7VP5hEep8i2NBNQdqWgFb +xiAsbMyhlhbE1Ng5POHssizc5HS3kMnLI0L1Y/fa1IwRZLPInwfIEEaFk1Gdc2Xaosu HGug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689694359; x=1692286359; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gSy44+9MVv/0xVqeRHH285rMKhZpkflM9AVY2c8/yjQ=; b=WBraHcVW5pmKL4ptIANt3plgYGvOIaDC6tBnOLhVPD2EGdPz+srLkASG/IhYc9TKN6 QMcaNTfFc59esivFcSiRl9CthfrVeP1EM0H1kEKX/VsGL8R+0imvxTqTvMjj8Um/K5US K/cqqHQUJy7oQKIKQ9KzV9FaY3/7A0CbmfBVAfx8+pQib/ca/21pkAkO2X8bOdGH16wd 0lhqoRfgMSKnTP3IG+Uf6uLrXnKtFKiBlkyRK66lxOdBMep1S0tCFAHWQd4LATJjcWdC 8/PGDQ5meCymA1OznimQyGuG3tAFnlO8k9EUVUaWCZdMEp1AKLzYgSsaDR0F8w7dmpwu NYSg== X-Gm-Message-State: ABy/qLbkiyzCiwnnXpbFRpo5897SGz+OOSbUn+j0kh/tBtzILjGWoFCd YCmNb0Vx3l8pdNpYGJOz45Y= X-Google-Smtp-Source: APBJJlEwJgdjEQLHiYTzZGoG27xUHGAurMItQ/RoVa1YwZcWi2q+GKuz5oVrFJ89aWgxrm0vOCydoA== X-Received: by 2002:a05:6870:e750:b0:1ba:66c1:da4c with SMTP id t16-20020a056870e75000b001ba66c1da4cmr6964755oak.57.1689694359257; Tue, 18 Jul 2023 08:32:39 -0700 (PDT) Received: from raisin ([2607:fad8:4:6::984a]) by smtp.gmail.com with ESMTPSA id pe8-20020a05620a850800b00767502e8601sm674916qkn.35.2023.07.18.08.32.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jul 2023 08:32:39 -0700 (PDT) From: Maxim Cournoyer References: <20230608171453.14788-1-arunisaac@systemreboot.net> <20230608171453.14788-2-arunisaac@systemreboot.net> <87351ov81r.fsf_-_@gmail.com> <87r0p6qj7s.fsf@systemreboot.net> Date: Tue, 18 Jul 2023 11:32:38 -0400 In-Reply-To: <87r0p6qj7s.fsf@systemreboot.net> (Arun Isaac's message of "Mon, 17 Jul 2023 23:14:15 +0100") Message-ID: <87wmyxteuh.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Spam-Score: 4.35 X-Migadu-Queue-Id: C66F74A931 X-Migadu-Spam-Score: 4.35 X-Migadu-Scanner: mx0.migadu.com X-TUID: x5iVl2JmXi5T Hello, Arun Isaac writes: [...] >>> + git-send-email-headers >>> + compose)) >> >> I think you've exported 'compose' erroneously here. > > Good catch! compose is part of a new "mumi compose" feature I am working > on. I had accidentally committed it. I have removed it from this commit. > > Now that you mention it, maybe I should call it compose-email so as to > not conflict with compose from guile core. Good idea! Shadowing builtins should be avoided; the warnings are annoying and require the use of #:hide on imports (and the code more confusing to read). [...] >> but: does call-with-input-pipe* raise an exception when git is available >> but 'sendemail.headerCmd' not set, thus exiting with status 1? I wasn't >> able to find its documentation in the Guile Reference manual. > > call-with-input-pipe* and call-with-input-pipe are both defined in > mumi/client.scm. They are not part of guile. The only difference between > them is whether they accept the command as a string or as a list of > arguments---thus, they parallel open-pipe and open-pipe*. > >> Otherwise you'd get header-command set to the empty string, which >> seems like it'd be a problem... > > call-with-input-pipe* does raise an exception when git is available but > sendemail.headerCmd is not set. I checked. So, this is not a problem. Good, thanks for checking. >>> + (headers >>> + (if header-command >>> + (call-with-input-pipe (string-append header-command " " patch) >> >> ^ ... here. Also, why the mixed use of >> 'call-with-input-pipe*' and 'call-with-input-pipe'? I'd >> stick with the former. > > sendemail.headerCmd is only available to us as a string, and not as a > list of arguments. It is quite non-trivial to correctly split the string > back into a list of arguments. That would require correct handling of > quotes like the shell does. So, we use call-with-input-pipe to handle > this case. Ah, I see. It's reasonable then to use it as is. > But everywhere else (such as when invoking "git config > sendemail.headerCmd"), we prefer to pass commands as a list of > arguments. So, we need call-with-input-pipe*. > > I understand it's a bit confusing to have two very similar > functions. But, the only possible compromise is to use > call-with-input-pipe everywhere. Should I make that compromise? WDYT? No, just the explanation here (and a possible comment in the source mirroring it) is enough! LGTM. -- Thanks, Maxim