unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Janneke Nieuwenhuizen <janneke@gnu.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 65755@debbugs.gnu.org, Marius Bakke <mbakke@fastmail.com>,
	Christopher Baines <mail@cbaines.net>
Subject: [bug#65755] [PATCH 0/3] Mark some packages as not supported on the hurd.
Date: Fri, 15 Sep 2023 22:06:18 +0200	[thread overview]
Message-ID: <87wmwryzet.fsf@gnu.org> (raw)
In-Reply-To: <87h6nv1ati.fsf_-_@gnu.org> ("Ludovic Courtès"'s message of "Fri, 15 Sep 2023 21:43:53 +0200")

Ludovic Courtès writes:

Hi,

> Christopher Baines <mail@cbaines.net> skribis:
>
>> Janneke Nieuwenhuizen <janneke@gnu.org> writes:
>>
>>> Marius found that building the updated "guix" package on the
>>> just-rebased hurd-team branch failed.
[..]

>> I don't think there's anything wrong with adjusting the expectation to
>> have the test pass, but to me the longer term thing to do is look at
>> changing the code around supported systems.
>
> Agreed, we need to change the expected result to:
>
>   (filter target-linux? %supported-systems)
>
> This is expected given that ‘%current-system’ is set to *-linux.

That makes sense (and fixes it :)

Pushed to master as edca2863bcb52388fe454e14136264a4f7490273

Thanks!
Janneke

-- 
Janneke Nieuwenhuizen <janneke@gnu.org>  | GNU LilyPond https://LilyPond.org
Freelance IT https://www.JoyOfSource.com | Avatar® https://AvatarAcademy.com




      reply	other threads:[~2023-09-15 20:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-05 11:17 [bug#65755] [PATCH 0/3] Mark some packages as not supported on the hurd Christopher Baines
2023-09-05 11:35 ` [bug#65755] [PATCH 1/3] gnu: musl-cross: Remove i586-gnu from supported-systems Christopher Baines
2023-09-05 11:35   ` [bug#65755] [PATCH 2/3] gnu: linux-libre-headers: " Christopher Baines
2023-09-05 11:35   ` [bug#65755] [PATCH 3/3] gnu: skalibs: Remove i586-gnu from %supported-systems Christopher Baines
2023-09-12  7:21 ` [bug#65755] [PATCH 0/3] Mark some packages as not supported on the hurd Ludovic Courtès
2023-09-12  7:46   ` bug#65755: " Christopher Baines
2023-09-15 18:32 ` [bug#65755] This broke make check on master Janneke Nieuwenhuizen
2023-09-15 18:56   ` Christopher Baines
2023-09-15 19:43     ` [bug#65755] [PATCH 0/3] Mark some packages as not supported on the hurd Ludovic Courtès
2023-09-15 20:06       ` Janneke Nieuwenhuizen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wmwryzet.fsf@gnu.org \
    --to=janneke@gnu.org \
    --cc=65755@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    --cc=mail@cbaines.net \
    --cc=mbakke@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).