From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:5f26::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id 6FM6AsHylmWcSQAAkFu2QA (envelope-from ) for ; Thu, 04 Jan 2024 19:02:41 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id iNzNNsDylmXhRAAAqHPOHw (envelope-from ) for ; Thu, 04 Jan 2024 19:02:41 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=fC7NrOIJ; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1704391360; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=yH3RC/scua7faPEKFoUb/qz6xUUdkDOlN4xIcpo9lhk=; b=GY+BmB8uOE01hslnDDCeU2JqG3bV2IOMFvUpY3rmz+3P2OuqhYNj9lgcw2VK2TIxCE1yC+ bC3Ow7T9pDgbqsnkh00iBo8Xpe7NvmBpM4ZD9FxTjvhbLIM6lhBcwdcdFK7Waw4vHnCekZ dvKqffQe9ufpUsoV5QbQEYO6SPuHW2FZwNu+6BWg5c+byT8KGNJi8VpRkX2nQAWjbPSzAu fDsC5IfDK1SOXed8UJ8VM7ecr6Tm150hI8nksJ71zgfXv3qnWQTc6WzrW83a4GG9ze0tOH 745XhlJz3aBYWtawQwl306tFB+13R0NXnnHe2JA4Rl7EKMWcSG5F+YZY8Hw4Eg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=fC7NrOIJ; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1704391360; a=rsa-sha256; cv=none; b=IiQJzadWAIWDk4BpSzh349VA6uQcPL66MI6RpGQj00cHFYsSix7kbQeNlvboCCDgAgiua6 rwt9qYkjh6LZfZfDgWM7J88T5HXGOxdHSzZOMDN0wQuRAI03wuMueMT1ZaeKnVRclxclIg Odl6VY3qOtr64lX3UVVeNVIXXsDbNBid6pGd0C+pzz4Ft8ss9LjZqx1iYMi8C51W5+hVYv BKvqV8YTc4seIV9WobokOUilYm4mvH4KnJI6fB1lZdf3gPFVuj81cYX7XhNd9ERtprCkFa PZUj5Zyf4Hon0D288vAK7EkDZhdlze3aWhdAQpw5ysOMac51V2npNnVF05Gi5A== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8B19F20605 for ; Thu, 4 Jan 2024 19:02:40 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rLS2p-0002RF-Kw; Thu, 04 Jan 2024 13:02:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rLS2e-0002O9-Eu for guix-patches@gnu.org; Thu, 04 Jan 2024 13:02:05 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rLS2Y-0004H0-Tk for guix-patches@gnu.org; Thu, 04 Jan 2024 13:02:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rLS2c-0003Sm-9Y for guix-patches@gnu.org; Thu, 04 Jan 2024 13:02:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#68052] [PATCH 1/4] gnu: python-poppler-qt5: update to 21.3.0 Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 04 Jan 2024 18:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68052 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Marco Rimoldi Cc: 68052@debbugs.gnu.org Received: via spool by 68052-submit@debbugs.gnu.org id=B68052.170439127311971 (code B ref 68052); Thu, 04 Jan 2024 18:02:02 +0000 Received: (at 68052) by debbugs.gnu.org; 4 Jan 2024 18:01:13 +0000 Received: from localhost ([127.0.0.1]:55654 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rLS1l-00031h-Tt for submit@debbugs.gnu.org; Thu, 04 Jan 2024 13:01:13 -0500 Received: from mail-vs1-xe34.google.com ([2607:f8b0:4864:20::e34]:47348) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rLS1h-0002lv-HK for 68052@debbugs.gnu.org; Thu, 04 Jan 2024 13:01:08 -0500 Received: by mail-vs1-xe34.google.com with SMTP id ada2fe7eead31-4673b620d95so163719137.2 for <68052@debbugs.gnu.org>; Thu, 04 Jan 2024 10:01:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704391254; x=1704996054; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=yH3RC/scua7faPEKFoUb/qz6xUUdkDOlN4xIcpo9lhk=; b=fC7NrOIJDxye/SzaKZySAp36SK80cfM2Wt2ns2u5F7oFzkzoOMoillAktJhEZExI1K 7XQTNSDNgL/GEOolctlxO4mj3JCl1nPZw7Y6ocwwGXzNfd6XJyJjKn7MPsHT/YfoLX/B FAnnXsPl1Mc1DS4DEN4Vxn8OapWRQSaMmRA/aeHhqEq+c7AIdrjdToWMf+HVLwpNGFbZ WSwPRm9QwwDvQmtqa9YwQ8logbD94yd6i0FcI42BxDymwaXVTi7PIWbazfO1mLmclIgS me5FH3x3uXuflhDhrTIh7vkeUHLCEebWG24Mfx8zdknrLoEOdr7y+MZwnFl67TEH4Rmg x1lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704391254; x=1704996054; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yH3RC/scua7faPEKFoUb/qz6xUUdkDOlN4xIcpo9lhk=; b=WIvlRlMJyNPfP0eIIWb8Ap40oOZfX02uLdqJIdqbL+q7kQ8f4DtkmMJ1dKvdP+3Kxo H6DiQ9Tw9ZyxWJbOvIqE8UehxW4T4KNxe+uvZB1mc8wXygq0SVMRJPvCbsvzMoUg9zQM cF/KBVmJ4D/JgM2SXhAvQPs7nKFHNQzymeyT0TQH3bV2TENKjibMbGLLQUU3yCPF0OZp P95UoU4P7jQR/V4b9eE2iXM7GhE38sK7gbsBO1tnXnw2yekvRwJE67v7dpRTkfGlKydY C5UzEEb0UBBMXedi6/2R0oYvv/CYOhMuAazLg/lcgmz4t5bFdDLuv/9cTPfxwAW9kOUr i76w== X-Gm-Message-State: AOJu0YzDeMYM+e8/bA2EkoK2J2eRWg1d10RDZu9NpOdeLjwZYtpLQJyr l/80XQfnLXLOPMenWG8naiNngyruCV3CNg== X-Google-Smtp-Source: AGHT+IEhrdT58y5ibmxMTlQMBrs9nZGINGLjJ/61nP/TIV/98/Hr0G6UyDCFcfLnot3J8K6v/Us1Qg== X-Received: by 2002:a05:6102:358e:b0:467:ae15:4d35 with SMTP id h14-20020a056102358e00b00467ae154d35mr598586vsu.8.1704391254224; Thu, 04 Jan 2024 10:00:54 -0800 (PST) Received: from hurd (dsl-10-135-125.b2b2c.ca. [72.10.135.125]) by smtp.gmail.com with ESMTPSA id dm6-20020ad44e26000000b0067f6ec98ae9sm11889123qvb.32.2024.01.04.10.00.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jan 2024 10:00:53 -0800 (PST) From: Maxim Cournoyer In-Reply-To: <20231226231408.6f2caeb5@libero.it> (Marco Rimoldi's message of "Tue, 26 Dec 2023 23:14:08 +0100") References: <20231226231408.6f2caeb5@libero.it> Date: Thu, 04 Jan 2024 13:00:52 -0500 Message-ID: <87wmsp0yi3.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -5.19 X-Spam-Score: -5.19 X-Migadu-Queue-Id: 8B19F20605 X-Migadu-Scanner: mx10.migadu.com X-TUID: aXoHXxSvzKpd Hello, Marco Rimoldi writes: > * gnu/packages/pdf.scm (python-poppler-qt5): Update tp 21.3.0 Please end complete sentences by a final period (also in the commit summary). > [build-system]: Change to pyproject, fix previous build failure. The changelog should ideally detail each change, such as specifying the 'sipbuild.api' backend. > Change-Id: I30d6e2a3180505091d8072ed452211b0bb3a0178 > --- > gnu/packages/pdf.scm | 37 +++++++++++++------------------------ > 1 file changed, 13 insertions(+), 24 deletions(-) > > diff --git a/gnu/packages/pdf.scm b/gnu/packages/pdf.scm > index 644a4617a6..787f5a2a6f 100644 > --- a/gnu/packages/pdf.scm > +++ b/gnu/packages/pdf.scm > @@ -415,40 +415,29 @@ (define-public poppler-qt5 > (define-public python-poppler-qt5 > (package > (name "python-poppler-qt5") > - (version "21.1.0") > + (version "21.3.0") > (source > (origin > (method url-fetch) > (uri (pypi-uri "python-poppler-qt5" version)) > (sha256 > (base32 > - "0b82gm4i75q5v19kfbq0h4y0b2vcwr2213zkhxh6l0h45kdndmxd")) > - (patches (search-patches "python-poppler-qt5-fix-build.patch")))) Patches are also registered in the build system in gnu/local.mk, and need to be de-registered there. > - (build-system python-build-system) > + "1q3gvmsmsq3llf9mcbhlkryrgprqrw2z7wmnvagy180f3y2fhxxl")))) > + (build-system pyproject-build-system) > (arguments > - `(;; There are no tests. The check phase just causes a rebuild. > - #:tests? #f > - #:phases > - (modify-phases %standard-phases > - (replace 'build > - (lambda* (#:key inputs #:allow-other-keys) > - (substitute* "setup.py" > - ;; This check always fails, so disable it. > - (("if not check_qtxml\\(\\)") > - "if True")) > - ;; We need to pass an extra flag here. This cannot be in > - ;; configure-flags because it should not be passed for the > - ;; installation phase. > - ((@@ (guix build python-build-system) call-setuppy) > - "build_ext" (list (string-append "--pyqt-sip-dir=" > - (assoc-ref inputs "python-pyqt") > - "/share/sip")) #t)))))) > + `( > + ;; The backend builder expects a Python dictionary as per > + ;; https://peps.python.org/pep-0517/#config-settings, but we > + ;; give it lists and it fails. The next line is a workaround. Please use double space after period (that's an Emacs/Texinfo/Scheme convention that allows navigating between sentences in Emacs). > + #:configure-flags '#nil > + #:build-backend "sipbuild.api" > + #:tests? #f)) > (native-inputs > (list pkg-config)) > (inputs > - (list python-sip-4 python-pyqt poppler-qt5 qtbase-5)) > - (home-page "https://pypi.org/project/python-poppler-qt5/") > - (synopsis "Python bindings for Poppler-Qt5") > + (list python-sip python-pyqt-builder python-pyqt poppler-qt5 qtbase-5)) > + (home-page "https://github.com/frescobaldi/python-poppler-qt5") > + (synopsis "Python binding to Poppler-Qt5") > (description > "This package provides Python bindings for the Qt5 interface of the > Poppler PDF rendering library.") The rest LGTM. -- Thanks, Maxim