unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Artyom V. Poptsov" <poptsov.artyom@gmail.com>
To: Sharlatan Hellseher <sharlatanus@gmail.com>
Cc: 69964@debbugs.gnu.org
Subject: [bug#69964] [PATCH 0/4] gnu: Add go-github-com-multiformats-go-multibase.
Date: Sun, 24 Mar 2024 16:03:56 +0300	[thread overview]
Message-ID: <87wmprbx37.fsf@gmail.com> (raw)
In-Reply-To: <CAO+9K5oRRfuYnwV8qqpWd5G_yXGeLf6gzReUoA5nuf3Oq7AOQw@mail.gmail.com> (Sharlatan Hellseher's message of "Sat, 23 Mar 2024 20:14:20 +0000")

[-- Attachment #1: Type: text/plain, Size: 945 bytes --]

Hello Oleg!

> I started the review process.

Great, thanks!

> Did you check a better place in gnu/packages for this one
> https://github.com/multiformats/multibase?tab=readme-ov-file#implementations
>
> It looks like a map of formats and the implementations may be not just in golang.

Yes, I saw this.  I just wasn't sure what module to use for the
"multibase" package.

> Check encoding module and consider to name it lees package specific.

Should I create "encodings.scm"?  Or maybe "specs.scm" is a better name
for it?  Because if there will be need for other protocol/format
specifications we can place the packages to "specs.scm".

Also what is the proper way to update the patch series?

Thanks!

- avp

-- 
Artyom "avp" Poptsov <poptsov.artyom@gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 869 bytes --]

  reply	other threads:[~2024-03-24 13:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-23 12:47 [bug#69964] [PATCH 0/4] gnu: Add go-github-com-multiformats-go-multibase Artyom V. Poptsov
2024-03-23 12:53 ` [bug#69964] [PATCH 1/4] gnu: Add go-github-com-multiformats-go-base32 Artyom V. Poptsov
2024-03-23 12:53 ` [bug#69964] [PATCH 2/4] gnu: Add go-github-com-multiformats-go-base36 Artyom V. Poptsov
2024-03-23 12:53 ` [bug#69964] [PATCH 3/4] gnu: Add go-github-com-multiformats-multibase Artyom V. Poptsov
2024-03-23 12:53 ` [bug#69964] [PATCH 4/4] gnu: Add go-github-com-multiformats-go-multibase Artyom V. Poptsov
2024-03-23 20:14 ` [bug#69964] [PATCH 0/4] " Sharlatan Hellseher
2024-03-24 13:03   ` Artyom V. Poptsov [this message]
2024-03-24 21:04 ` Sharlatan Hellseher
2024-04-06 22:40 ` bug#69964: " Sharlatan Hellseher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wmprbx37.fsf@gmail.com \
    --to=poptsov.artyom@gmail.com \
    --cc=69964@debbugs.gnu.org \
    --cc=sharlatanus@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).