From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id oJulLe/3F2bVOwEAqHPOHw:P1 (envelope-from ) for ; Thu, 11 Apr 2024 16:47:11 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id oJulLe/3F2bVOwEAqHPOHw (envelope-from ) for ; Thu, 11 Apr 2024 16:47:11 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=trop.in header.s=key1 header.b=oRYfcew+; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1712846831; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=pMk39ihKciWjk67zTn38KXOK9KaEEjHX0gXwlBl+7go=; b=lQM3gyuRLn+s6G8lw/eNfc5DG/GqIwT1mo0Oe8Uwll6HJUhC1CvxT181xpUgn/3n1vlD/4 +Z20BitZLXHdOAqyeYUfOmICl4boujtphRvPWUIFAxhi0AsI8CdwUotCvz50QKfil3p1Qw Aqrpbt2lz7tPnr6G9FDW7KNKhZIrLsrOGZtjT4SwietZiEcEeFNpy6n7qI1n9tFKn3r4Tn ZOsiqe/9GfMdOlpwSMkcRI+9iq7X9Dg+teSIq5y/BuGBVdkQRbqduVAa741mf+rTlXF+gx 8oqHlJPPiex/cVgS61eA5I9oVQBuUBD4i4cQS+vNiC6VlCd6kTraEzW3RIwhvg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=trop.in header.s=key1 header.b=oRYfcew+; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1712846831; a=rsa-sha256; cv=none; b=Mf380Po50FNGMH/iqjcoBlnsPTGbncjDR50jZPljSknpYi7ILJM2vAuCKhLJJPTXK4hQKN RBDNoS9VVRv1HNgPjYVxh8dGAb70W8rBMmkcEGy4cv1txqMsg7Z+sR4YBT8E9YDyypb3N8 UkwRzBBRZ1SEweEavqDsE/TkjricmMMHCq3waHXRIn/cvileQP+/nWsC8uaj2h+7nTw7wX p+ay394YYqAq/Y1iFFKsjCw+gi2pzx/F4ydPMlkKZBwQz7wsPyLlDXtxUVz66Xt1Z3/XoB /duA7D8cWYssfk2FFNKoKy74qGalYPzI6VNiF3/T6DJ9suex+Pzf7WqRh+1i2Q== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 625EB624CA for ; Thu, 11 Apr 2024 16:47:11 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ruvhX-0006UB-Hx; Thu, 11 Apr 2024 10:46:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ruvhV-0006Tk-JI for guix-patches@gnu.org; Thu, 11 Apr 2024 10:46:54 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ruvhV-0004ZL-AB for guix-patches@gnu.org; Thu, 11 Apr 2024 10:46:53 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ruvhe-0007F1-HA for guix-patches@gnu.org; Thu, 11 Apr 2024 10:47:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#69950] [PATCH emacs-team] gnu: emacs: Only verify integrity of bound symbols. Resent-From: Andrew Tropin Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 11 Apr 2024 14:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69950 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler , 69950@debbugs.gnu.org Cc: cox.katherine.e+guix@gmail.com, liliana.prikler@gmail.com Received: via spool by 69950-submit@debbugs.gnu.org id=B69950.171284680227688 (code B ref 69950); Thu, 11 Apr 2024 14:47:02 +0000 Received: (at 69950) by debbugs.gnu.org; 11 Apr 2024 14:46:42 +0000 Received: from localhost ([127.0.0.1]:57105 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ruvh8-0007BZ-HQ for submit@debbugs.gnu.org; Thu, 11 Apr 2024 10:46:39 -0400 Received: from out-177.mta0.migadu.com ([91.218.175.177]:21738) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ruvgx-00078M-HL for 69950@debbugs.gnu.org; Thu, 11 Apr 2024 10:46:26 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trop.in; s=key1; t=1712846763; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pMk39ihKciWjk67zTn38KXOK9KaEEjHX0gXwlBl+7go=; b=oRYfcew+dSkCiBf2LFtkV4lfKJPjTa1IoXCEnIY/6PxYljeqaI4hPisMbhXAQ888ye+p0u arTAkzUbPUjOKZXFsPNn8w/Ze3JLopypedf7FJodB+P1r5MO6BkbEwNfOopfCJsWl/0eF7 St6S6dGgjkoe8SHT5a8QFiyVNZM09ZHXDN9LQo18ULmE9wVsLJOi1YoxtYqr1QljHEpTta 9kUpJNwUoEWa6fVifOWJqlItA8AwA0de042DT5vIpyVOB3NiRLLFO3Z2stiL++RERPcbnq J5inKaQax6wtmvtCxzq1NGBf8IRjA2wzZmu3Xyx7QGHe1+O+1Bk/5/lAOGG23A== In-Reply-To: <9e22ef64adefbc226d0e4ceb99b5823d9df99a3f.1711144224.git.liliana.prikler@gmail.com> References: <9e22ef64adefbc226d0e4ceb99b5823d9df99a3f.1711144224.git.liliana.prikler@gmail.com> Date: Thu, 11 Apr 2024 17:45:57 +0300 Message-ID: <87wmp4yn2y.fsf@trop.in> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Andrew Tropin X-ACL-Warn: , Andrew Tropin via Guix-patches From: Andrew Tropin via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -8.97 X-Migadu-Scanner: mx11.migadu.com X-Spam-Score: -8.97 X-Migadu-Queue-Id: 625EB624CA X-TUID: zCwYlBaE0eHl --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2024-03-22 22:45, Liliana Marie Prikler wrote: > Some variants, like emacs-no-x, come with a reduced set of preloaded symb= ols, > so don't expect them to always be native. > > * gnu/packages/aux-files/emacs/comp-integrity.el (expect-native-if-bound)= : New > function. > (x-setup-function-keys, dynamic-setting-handle-config-changed-event) > (fontset-plain-name, fringe-mode, image-type, regexp-opt, scroll-bar-scal= e): > Use =E2=80=98expect-native-if-bound=E2=80=99. > (x-handle-no-bitmap-icon): Likewise, was already conditional. > --- > .../aux-files/emacs/comp-integrity.el | 22 ++++++++++--------- > 1 file changed, 12 insertions(+), 10 deletions(-) > > diff --git a/gnu/packages/aux-files/emacs/comp-integrity.el b/gnu/package= s/aux-files/emacs/comp-integrity.el > index 191e2ddb98..abe7e7c0c9 100644 > --- a/gnu/packages/aux-files/emacs/comp-integrity.el > +++ b/gnu/packages/aux-files/emacs/comp-integrity.el > @@ -24,6 +24,9 @@ > (defmacro expect-native (fun &optional feature) > `(progn (expect-help ,fun native ,feature))) >=20=20 > + (defmacro expect-native-if-bound (fun) > + `(and (boundp ',fun) (expect-help ,fun native))) > + > (defmacro expect-builtin (fun &optional feature) > `(progn (expect-help ,fun built-in ,feature)))) >=20=20 > @@ -38,7 +41,7 @@ > (expect-native use-default-char-width-table) > (expect-native cl-generic-p) > (expect-native cl-struct-define) > -(expect-native x-setup-function-keys) > +(expect-native-if-bound x-setup-function-keys) > (expect-native encode-composition-rule) > (expect-native custom-declare-face) > (expect-native minibuffer-prompt-properties--setter) > @@ -48,7 +51,7 @@ > (expect-native dnd-open-file) > (expect-native dos-mode25 dos-fns) > (expect-native find-file-text dos-w32) > -(expect-native dynamic-setting-handle-config-changed-event) > +(expect-native-if-bound dynamic-setting-handle-config-changed-event) > (expect-native easy-menu-item-present-p) > (expect-native eldoc-mode) > (expect-native electric-indent-mode) > @@ -60,12 +63,12 @@ > (expect-native fill-region) > (expect-native font-lock-change-mode) > (expect-native font-lock-add-keywords) > -(expect-native fontset-plain-name) > +(expect-native-if-bound fontset-plain-name) > (expect-native format-read) > (expect-native frame-edges) > -(expect-native fringe-mode) > +(expect-native-if-bound fringe-mode) > (expect-native help-quick) > -(expect-native image-type) > +(expect-native-if-bound image-type) > (expect-native indent-region) > (expect-native indian-compose-regexp) > (expect-native msdos-setup-keyboard term/internal) > @@ -86,7 +89,7 @@ > (expect-native convert-define-charset-argument) > (expect-native coding-system-change-eol-conversion) > (expect-native store-substring mule-util) > -(expect-native mouse-wheel-change-button) > +(expect-native-if-bound mouse-wheel-change-button) > (expect-native advice-function-mapc) > (expect-native comment-string-strip) > (if (>=3D emacs-major-version 30) > @@ -99,12 +102,12 @@ > (expect-native show-paren-function) > (expect-native pgtk-dnd-init-frame pgtk-dnd) > (expect-native prog-context-menu) > -(expect-native regexp-opt) > +(expect-native-if-bound regexp-opt) > (expect-native get-register) > (expect-native query-replace-descr) > (expect-native rfn-eshadow-setup-minibuffer) > (expect-native read-multiple-choice) > -(expect-native scroll-bar-scale) > +(expect-native-if-bound scroll-bar-scale) > (expect-native gui-select-text) > (expect-native seq-first) > (expect-native hack-read-symbol-shorthands) > @@ -126,5 +129,4 @@ > (expect-native define-widget) > (expect-native window-right) > (expect-native x-dnd-init-frame x-dnd) > -(and (boundp 'x-handle-no-bitmap-icon) > - (expect-native x-handle-no-bitmap-icon)) > +(expect-native-if-bound x-handle-no-bitmap-icon) > > base-commit: 058532bdd8953feefbd84fd7514822886c7f1a7e Hi Liliana, Looks good! =2D-=20 Best regards, Andrew Tropin --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmYX96UACgkQIgjSCVjB 3rBIzQ//eNQ588FvbEDXwP4cfapguimU0OnJg+S7eVhrTzklg990pW7E7SD53WYq SUwxRTVbPfh/aifmPKjclIYATYrr396r0GC6CTjlMdXbA1cDxc+5M+fxrTQXw0WL bszDod9tMQTzA+U6mBPF+R9AXpetC5SkRl5v55fwwqfJ16Ass3MXdG2WgMptHnFh y9DbKT80ONffL9vBktMJwnNSgaQHX1Xjhw7LTO/pq9yvuLpGcsJe6bbISpgb88Bl e99z+i/BNxo0F9GyvrxEk8ouTdct+EYMH3adbgDCIm6y6oKf5tIgfENvXhrG6i8i +TBzbf1/CCyraif5CxeK1g1hrttah9P1OW/l3+CEeSolKfOUAKPGrkdiXPeVGlsq p7MWbpZAlI3sMcBWupd40G47VXg7cM1RLPsgcDHDu8S8bs0u5SbMM9hpJlys+sTX m0S25uPbDmGI9sEgdA3FR1xMTMgWP7Ps9/mR45a93bHSsRZMuyrwpBkTQBBIXY10 FjKIZCyJlwCTGugJhBcmBH0iV13CQuP/V35xL5aXrc+KHzy6zV7mIu9l9V0+//kZ RRFtCchcmYqiSL1U5rtp7mB5JrlvCnhU82x3k4+ALiLX4pE3vnQtGd6kSEtNLy3e y7uc2xPUtmV0zzas6/d4g1EssEuLJifjXCGcQPABy2ypxYHq0H4= =5OEr -----END PGP SIGNATURE----- --=-=-=--