From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id 2DHKFxJtHWa7CAAAqHPOHw:P1 (envelope-from ) for ; Mon, 15 Apr 2024 20:08:18 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id 2DHKFxJtHWa7CAAAqHPOHw (envelope-from ) for ; Mon, 15 Apr 2024 20:08:18 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=eoTWP8yT; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1713204498; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=p21/OzxrzbuyZQyBn5O47bphdKN+aIRNy0DtxhBIn6g=; b=qjAPxZk8phu/yf22tjI5XUtl27kc79haGov93asMTbUyai45xCM+SUpRy0QYppVAYk/9Nv a0OJe3jFZTBwpRyxugLwraN1vlhnlL9Yap37i9NCEZZbOrlQiB2viziPlfY/EBghcxU5tB Ll3x6FRV9Xw7sddhQRaQnc4INSKOQ9vMCLoimy6GCgi6NCUsgq+wSdSsXABqm1qgCwpzGx xbKAnXGtRsk15Ct1a3FnzwrHaib0UmE3CsU6nqxlzTUUJDYKJBdyh9ncb+HHPWLUKHia2f 9hV7XkINhYnv3i3BVDJWUGq2lviSNnwaGgIPgXcStHj31Zc84ARRryORZKqhdQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1713204498; a=rsa-sha256; cv=none; b=bP5CXusMraKDJFcmy02nbOJdQk/1QsezZsA9oklxFXTNH7ciPN/G6R3MFSf8yqm0fLqntg 1DT2NnW03fpTEmNmlsy9x7fY7fWAB2l0Yslq2wgKO+jHfVvJCHgRIcrf8iSypqoOoXZceV wPip1wVZO1r2u5jRUIN6OwcFlvIEPHm9w8CG0NUOdWvk12SxzswSVfcHjvnFyBJAdvy6Gw udn8ri9b10JA41cp8G9LuBJv7x7E5nw8x4Whl7SMzjyi9zlMjQuPsOw+gm6IfcFNIZVorL Q0fVbHAj2+qw9eWM7Rgu5L8XmqS26Dx0b78T0thABaTveDCNnhZdj11DT7n2aw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=eoTWP8yT; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 29E1C54D49 for ; Mon, 15 Apr 2024 20:08:18 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rwQkF-0003Bq-Mx; Mon, 15 Apr 2024 14:07:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rwQkE-0003BL-0Z for guix-patches@gnu.org; Mon, 15 Apr 2024 14:07:54 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rwQkD-0003v5-NO for guix-patches@gnu.org; Mon, 15 Apr 2024 14:07:53 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rwQkO-00063w-Da for guix-patches@gnu.org; Mon, 15 Apr 2024 14:08:04 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70398] [PATCH 0/5] Reduce the size of gnu/packages/*.go files Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 15 Apr 2024 18:08:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70398 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Ricardo Wurmus , Josselin Poiret , Mathieu Othacehe , Tobias Geerinckx-Rice , 70398@debbugs.gnu.org, Christopher Baines Received: via spool by 70398-submit@debbugs.gnu.org id=B70398.171320447123243 (code B ref 70398); Mon, 15 Apr 2024 18:08:04 +0000 Received: (at 70398) by debbugs.gnu.org; 15 Apr 2024 18:07:51 +0000 Received: from localhost ([127.0.0.1]:38767 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rwQjy-00060r-3D for submit@debbugs.gnu.org; Mon, 15 Apr 2024 14:07:51 -0400 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]:39027) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rwQjo-0005yL-Tf for 70398@debbugs.gnu.org; Mon, 15 Apr 2024 14:07:30 -0400 Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-346407b8c9aso1508287f8f.0 for <70398@debbugs.gnu.org>; Mon, 15 Apr 2024 11:07:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713204431; x=1713809231; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=p21/OzxrzbuyZQyBn5O47bphdKN+aIRNy0DtxhBIn6g=; b=eoTWP8yTgYgESiRz+yBfKoGR+3a0hIKtomms3Hyf6WknV8F3mlCQDBSIR8MHHvnyyH Tr9SWideqpdQiaVqjL7S0CbKEM9qkG1yciAg1QkelVeMXCZk0ZnbYB8IWCKPhoRARIcp co31u3JCPCpuUjCxKSFbK5DQ1sdT4juwAHYfBwMC5+WEISMKlHTbBSvzokBNw0S0zuxH TknEiy+6iSoUUuvO8aoLF+61TtA2PjywPBozXoCT/aATytKPS93oRXiGPei8HAelZUBV GMzT/PtDc1fr5kgohZlM+4sOuvrCJncC7JCOs15vhmbl0tx8ge0IKtyGcaq32dEvH8p2 oyjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713204431; x=1713809231; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=p21/OzxrzbuyZQyBn5O47bphdKN+aIRNy0DtxhBIn6g=; b=fW/gG6MFJj5O6gmHT39vDjX/knZtizYa1DLzqXzyaP5UeowAbtaRe/Q37izVuQNOkf qPirfGXxASDN5o2GxVGlIQ+fnX6Lqgt5rTbJZNuyrKaf+qpTwylM0BVyj9B0bkMBubYQ +H4F/sk8uywZ5vzI+fg8f8tz7Shbfze2QbopOBsdfuVNOR/aol9DFY3CCSV5O3KiI/Ag GU35JrdvbHgqc+DJE77xoZLNt8OX+9OCwN/V3Fe3D6vTcw2lXs8+zYhKHj9xmwHR3r0x a1sqTLZFhCvc0pqK9cg4/AIUkhUStWLTIcirLzFg/J2eK3upLDj+YLoY/LR6vAhOQiQ9 eYiQ== X-Gm-Message-State: AOJu0YxSJ4FUxKZLYwlDmWP3R4f7Nm+8F8SbRSiT95SCZyHRsViVPDac 8lk2m+ApAnro2EXwnGrz7dHeyv3gMz5XklGD1zWtJpPlhQRcvNuY X-Google-Smtp-Source: AGHT+IFEofrkrHpOgcaEhwQnsT8LQoo3b/RVOqPneYZk21ogkRfVIIH2ZK9whkdabQIq7h7gRwPuEg== X-Received: by 2002:a05:600c:6908:b0:418:c7a:c215 with SMTP id fo8-20020a05600c690800b004180c7ac215mr6556240wmb.1.1713204431126; Mon, 15 Apr 2024 11:07:11 -0700 (PDT) Received: from lili (roam-nat-fw-prg-194-254-61-45.net.univ-paris-diderot.fr. [194.254.61.45]) by smtp.gmail.com with ESMTPSA id r11-20020a05600c458b00b00417f7ddd21dsm14104842wmo.37.2024.04.15.11.07.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Apr 2024 11:07:10 -0700 (PDT) From: Simon Tournier In-Reply-To: ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Mon, 15 Apr 2024 17:27:36 +0200") References: Date: Mon, 15 Apr 2024 20:06:15 +0200 Message-ID: <87wmoyijqg.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -5.27 X-Spam-Score: -5.27 X-Migadu-Queue-Id: 29E1C54D49 X-Migadu-Scanner: mx13.migadu.com X-TUID: mXEehzE7uxtv Hi, On lun., 15 avril 2024 at 17:27, Ludovic Court=C3=A8s wrote: > What follows is a bunch of tricks to reduce code bloat, achieving ~14% > reduction in the size of .go files (~18% if we look at gnu/packages > alone). If have not checked that the reduction would be of ~18%. From my understanding, the patch set LGTM; modulo an unrelated comment about ellipsis and potential quadratic penalty on performances. > About 60% of those files are in the 64=E2=80=93128 KiB range. Since ELF = sections > are currently 64 KiB-aligned (see =E2=80=98*lcm-page-size*=E2=80=99 in Gu= ile), we would > save space by ensuring these are sparse files. To do that, we=E2=80=99ll= need to > detect holes when restoring nars and/or to change the nar format to > preserve holes, while also ensuring that when the daemon copies files > around, it also preserves holes. Work for later! Since [1], I think that compiling a generic Guile record for is touching the limit of DSL. :-) Other said, I think the binary (compiled) representation of records should be specific and thus optimized. Work for after later. ;-) Cheers, simon 1: How many bytes do we add (closure of guix) when adding one new package? Simon Tournier Thu, 25 May 2023 20:24:30 +0200 id:87r0r4uv4x.fsf@gmail.com https://lists.gnu.org/archive/html/guix-devel/2023-05 https://yhetil.org/guix/87r0r4uv4x.fsf@gmail.com