From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id ICSOKJvSZmY/MgEAqHPOHw:P1 (envelope-from ) for ; Mon, 10 Jun 2024 10:16:59 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id ICSOKJvSZmY/MgEAqHPOHw (envelope-from ) for ; Mon, 10 Jun 2024 12:16:59 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1718014619; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=HsSBj98eEMh7Aa3w9Kx9SPDgzeEOYqPhq27USYVuB0g=; b=KfiQIFAGJlAGkIk3ynDQzXFJeaefItcHhiOOfsnsABVMGYMujQLzjFDHdIhMIOfyizCMtV KQ1o56CKNo3gVLcV5g/BR6CwZTluJUhHc6dI7j8k4PuD6rIe35eIrTnWPUQKzCqt2W1VFE DqFdpyeY2uBmc9XVBecBuKjPAaKM1nsjojAoLAMzVJDplg5eatN6vKN8fP5xHyO/Ad5tqt mRp7JsE2vhSRD8FeTYRK78yitVlIs2UHb7xlzR1CE2Hq5L5r6sSji4ie3yrWe40BZWUy/W JAr1j8C5mX7LBxT3Rl9ly4rCyFS3gLwoSSfugEEYQNbqBze9RKwxwNldtg/8wQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1718014619; a=rsa-sha256; cv=none; b=DynIK0Ew/9Sk59o6VeImaK6S5Blmljh38xR5nqbLuIawLN8FrSsyLrB874AEU7eiTn3vwj fOC0l7WG7xzkwTbh7evbE7viA/HXwBE+qZwsm0KgtUVCEhEGPCHG6AfTvfzHD+0U6DHTty o6xRnKvHY2YL18SeN0lExBNTRn9ITkyOfpT7C2mMaENj9Pr4NANkDUYXmWBxA/L0io5/5o N7NgQbkUQqBOxya82QdCmcS5qlwDlvm6hvn6D24D/bK82N0MC8eUnJ2x1HXGvIJX8lttVo LHcRJ6Xv44mqyBiKRcZCoCj0Ztq1jBxrT6nHVVk6e0F6xpHdsrFFCbxiXtsc7g== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6CAC5254AE for ; Mon, 10 Jun 2024 12:16:59 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sGc53-0003Nk-H9; Mon, 10 Jun 2024 06:16:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sGc4z-0003My-UQ for guix-patches@gnu.org; Mon, 10 Jun 2024 06:16:46 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sGc4z-0004dm-Ms for guix-patches@gnu.org; Mon, 10 Jun 2024 06:16:45 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sGc5G-0000JV-EC for guix-patches@gnu.org; Mon, 10 Jun 2024 06:17:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#71396] Close Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 10 Jun 2024 10:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71396 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 71396@debbugs.gnu.org Cc: andreas@enge.fr, gemmaro.dev@gmail.com Received: via spool by 71396-submit@debbugs.gnu.org id=B71396.17180145901109 (code B ref 71396); Mon, 10 Jun 2024 10:17:02 +0000 Received: (at 71396) by debbugs.gnu.org; 10 Jun 2024 10:16:30 +0000 Received: from localhost ([127.0.0.1]:52047 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGc4j-0000Hp-BT for submit@debbugs.gnu.org; Mon, 10 Jun 2024 06:16:29 -0400 Received: from mira.cbaines.net ([212.71.252.8]:43626) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGc4f-0000HN-6O for 71396@debbugs.gnu.org; Mon, 10 Jun 2024 06:16:27 -0400 Received: from localhost (unknown [212.132.255.10]) by mira.cbaines.net (Postfix) with ESMTPSA id 8111127BBE2; Mon, 10 Jun 2024 11:07:12 +0100 (BST) Received: from felis (localhost.lan [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id e7fc706c; Mon, 10 Jun 2024 10:07:11 +0000 (UTC) From: Christopher Baines In-Reply-To: (Andreas Enge's message of "Mon, 10 Jun 2024 11:58:59 +0200") References: User-Agent: mu4e 1.12.4; emacs 29.3 Date: Mon, 10 Jun 2024 11:07:11 +0100 Message-ID: <87wmmxyuuo.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: -8.40 X-Migadu-Queue-Id: 6CAC5254AE X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -8.40 X-TUID: 1k9KZYwXpZB0 --=-=-= Content-Type: text/plain Andreas Enge writes: > Concerning the second patch, we do not need a gexp; they are similar to > quoting and unquoting and needed to stage code execution (from the package > definition to the build). Here everything is done at package definition > time. #~ is some kind of (quasi-)quoting, but there is no corresponding > unquoting #$ or #+ in the following block. (Actually, to make this even > clearer, one could replace ` by '; but this would not warrant a commit.) Note that quoting vs gexps matters for package inheritance, so even though there's no ungexp'ing happening in this pacakge, the phases could be ungexp'ed by a package that inherits from solaar. For this reason, I think it's important to move to using gexp's for all phases, even the trivial ones, so that there are less issues when it comes to package inheritance and modifying phases. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmZm0E9fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XcVuQ/7Byj9iKLWThQgVk9J0+tZKZGdcqiTrGmu nklIhxody1b0Z5y6zjsnz3g6YzWnh+VsVnUc/OBWU0zPqdONaFTdpaW3W1O9lHL+ KIrbwO9+8Ywy1j+g5YguGxJVMfLmKlbOxC3n3RoPVOtYa32EPIu63zMCdf/F7cNZ QVXwjDAYB+cBVSDRN/zuoSL9A0q/4XedE9d/vXg8D8VmsAmpY4Y6hDVzVcqU0c3M cFRuYQktOhpcCAixVbtGYCzRnRs2Uxsm4zUBDEnPQIgcgpEXpqJhv3wo3m3LOT1D Mx+MISYKgsHspOB7BQTv9POvjl8X1rgT9izo/QMsi55KTYjG5QIq0MyVZliYoPUo tZXrkdXihhtS+hF8cenB8C8ejSHpv1rM2d9sH7iwUjk+0y9B+wBpKhxW6Pk70xys q35kHT8OlyM89o3SY/59hlZp8K1FTldwu13nYrzFf6lolU1LKLICPPNV9UTXhfCh rb9IImeED/vwGRCDSiC7vWxc930kntblpNw/zlH4Vygq1jzx7Q6GQGPlVAHLdDQy 8ZOoRg90qwCbAqppgp8EqVMnDbAs0Zh41J+Vp7SC/DRD3bNhrR4iRyeuxZqi4A0b MzhYMsTWX1xgZgNJs/p4WrNBTMdAtZwKc9K61ONCbG/OIEeGt//6fm6bZfifl8u/ QmZKVh/HSBY= =yMld -----END PGP SIGNATURE----- --=-=-=--