From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id AEjKBkwxmWYndQAAqHPOHw:P1 (envelope-from ) for ; Thu, 18 Jul 2024 15:14:20 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id AEjKBkwxmWYndQAAqHPOHw (envelope-from ) for ; Thu, 18 Jul 2024 17:14:20 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=RoRUZzfo; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1721315659; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=lFDAKIkNCCqSMy/HvJ/3ueFKeZmx2oRPbLgB//YNlWY=; b=rgQm90P/yG4BTqY6bLUqkAd9O6icPWpRdVoqYrkDk/fyWM1Z6TAIFiGNGtjnGf9ug4h8tC mqk5ZyxV/+fKvyQTZ+lISkZ9OnmR5newCVMimYeME/zxoILppIGqeGbBztqq0VMIoeRpPT 6mMWv9sXbeQU4Wq73WMIuzYIlHplxAKTBqQ9MHvCPHJ2VM0iuLWMzCGYyyl7ZnVZ2dkjRu qjQ1nWmmmbb19xOkWOoq+WKXxDrTg+DgWogdyBM53Jpqv1skFu/2qtFWh3WfEM422K/14g SgItKEdtI/wBqxLtHSQIdCadTVMFyr1F9J1t9Z8BSnIKI/xvnqp3wBE6LdgPWw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=RoRUZzfo; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1721315659; a=rsa-sha256; cv=none; b=uDMBrT87S/tJblaTLSBWiDf3A1J5WA8bKYnxaN6E/1uGrZZxIxy14D7RVu/6WjeMiIrDd6 aKI/FIEePTRcf3SLn8gahREUW1ipX4vxL8CIY0Notg+i1yTrK6xP/k0gGKiCO9en/P27JQ xnKfYJKfzz43cWaLp91HnyXYEOCJpIulcJcVHaEWYe60/1ZPM9YWSj/WnPiI79jbreSVSN Ir9ZwRtdEIyi4zd8DoxswUKLD7LWIgAMmbNKg1QtYVRTx2nuhrdG2kiKLZ97QDkvZvZn5L TQMjlGyURRVU126XirLkxkAfFaxRBdiGKOsBtXCyRr6l0p4WA2vsU6EOv7tI1w== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CE30467607 for ; Thu, 18 Jul 2024 17:14:19 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sUSpe-0003I8-3v; Thu, 18 Jul 2024 11:14:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sUSpT-0003HZ-BR for guix-patches@gnu.org; Thu, 18 Jul 2024 11:14:00 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sUSpS-00055k-PR for guix-patches@gnu.org; Thu, 18 Jul 2024 11:13:58 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sUSpW-0005Mj-2A for guix-patches@gnu.org; Thu, 18 Jul 2024 11:14:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70800] [PATCH v2] scripts: style: Add 'alphabetical-sort' option. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 18 Jul 2024 15:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70800 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Herman Rimm Cc: 70800@debbugs.gnu.org Received: via spool by 70800-submit@debbugs.gnu.org id=B70800.172131558720547 (code B ref 70800); Thu, 18 Jul 2024 15:14:02 +0000 Received: (at 70800) by debbugs.gnu.org; 18 Jul 2024 15:13:07 +0000 Received: from localhost ([127.0.0.1]:37850 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sUSod-0005LK-3p for submit@debbugs.gnu.org; Thu, 18 Jul 2024 11:13:07 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46636) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sUSob-0005Kc-JP for 70800@debbugs.gnu.org; Thu, 18 Jul 2024 11:13:06 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sUSoP-0004TK-UP; Thu, 18 Jul 2024 11:12:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=lFDAKIkNCCqSMy/HvJ/3ueFKeZmx2oRPbLgB//YNlWY=; b=RoRUZzfoKidPfO4khjb9 1j5xHFyI5DTNeZiZKc8A+RhqopOyOAlqZdwsm9USDv2U2zfeS1azaRyQaLJpJW31Ah5kJPklk9Cbs BsAzivsdLn6+yipPJodUxS+/z1bRMgNsjbljQcrG4af6isziRV+mFwqMqTE6RB3U3cjWWIbLsQgTN 6w84S9A9WJJj0uj+KqgmOwZwQa8RoPyeTqw95U34/2JAkbRViAlU+oiwSFUcVQItD1AoI8h8LfM3O hIdLz1OKeaMp51z9TDedI3mNx+AsmIX6m6io+LEC5p2mlXXdJyDHuSuhlsk8zxMDBmzkBtENGUk5t RfpdD3JCO7oy/A==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <20240704155507.20383-1-herman@rimm.ee> (Herman Rimm's message of "Thu, 4 Jul 2024 17:55:06 +0200") References: <8e0df2707343eaee0bf39fa06fcdd5bc5cd9fba2.1714992109.git.herman@rimm.ee> <20240704155507.20383-1-herman@rimm.ee> Date: Thu, 18 Jul 2024 17:12:51 +0200 Message-ID: <87wmlivimk.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: CE30467607 X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -7.31 X-Spam-Score: -7.31 X-TUID: E+z+xsda1y14 Hi Herman, Herman Rimm skribis: > * guix/scripts/style.scm (show-help): Describe option. > (order-packages): Add procedure. > (format-whole-file): Add 'order?' argument. > (%options): Add 'alphabetical-sort' option. > (guix-style): Alphabetically order packages in files. > * doc/guix.texi (Invoking guix style): Document option. > > Change-Id: I4aa7c0bd0b6d42529ae7d304587ffb10bf5f4006 > --- > Hi, > > I should have mentioned it back then, but in May and again today I tried > to not use a reverse. If you can do a sort without it, please amend the > patch. This revision takes the other feedback into account. This looks great to me, thanks! I realize I forgot to ask you to add tests to =E2=80=98tests/guix-style.sh=E2=80=99=E2=80=94my bad. Would you be willing and able to submit an updated version with tests? If not (which I=E2=80=99d understand), I can allocate time to do it. Thanks, Ludo=E2=80=99.