unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Herman Rimm <herman@rimm.ee>
Cc: 70800@debbugs.gnu.org
Subject: [bug#70800] [PATCH v2] scripts: style: Add 'alphabetical-sort' option.
Date: Thu, 18 Jul 2024 17:12:51 +0200	[thread overview]
Message-ID: <87wmlivimk.fsf@gnu.org> (raw)
In-Reply-To: <20240704155507.20383-1-herman@rimm.ee> (Herman Rimm's message of "Thu, 4 Jul 2024 17:55:06 +0200")

Hi Herman,

Herman Rimm <herman@rimm.ee> skribis:

> * guix/scripts/style.scm (show-help): Describe option.
> (order-packages): Add procedure.
> (format-whole-file): Add 'order?' argument.
> (%options): Add 'alphabetical-sort' option.
> (guix-style): Alphabetically order packages in files.
> * doc/guix.texi (Invoking guix style): Document option.
>
> Change-Id: I4aa7c0bd0b6d42529ae7d304587ffb10bf5f4006
> ---
> Hi,
>
> I should have mentioned it back then, but in May and again today I tried
> to not use a reverse.  If you can do a sort without it, please amend the
> patch.  This revision takes the other feedback into account.

This looks great to me, thanks!  I realize I forgot to ask you to add
tests to ‘tests/guix-style.sh’—my bad.

Would you be willing and able to submit an updated version with tests?
If not (which I’d understand), I can allocate time to do it.

Thanks,
Ludo’.




  reply	other threads:[~2024-07-18 15:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-06 10:50 [bug#70800] [PATCH] scripts: style: Add 'order' option to alphabetically order file Herman Rimm via Guix-patches via
2024-05-25 14:14 ` Ludovic Courtès
2024-05-31 15:36   ` Simon Tournier
2024-06-26 21:32   ` Ludovic Courtès
2024-07-04 15:55 ` [bug#70800] [PATCH v2] scripts: style: Add 'alphabetical-sort' option Herman Rimm via Guix-patches via
2024-07-18 15:12   ` Ludovic Courtès [this message]
2024-09-02 18:58 ` [bug#70800] [PATCH] " Herman Rimm via Guix-patches via
2024-09-03  9:50   ` bug#70800: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wmlivimk.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=70800@debbugs.gnu.org \
    --cc=herman@rimm.ee \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).