From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id AB/GLglTAmeQSwAAe85BDQ:P1 (envelope-from ) for ; Sun, 06 Oct 2024 09:06:18 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id AB/GLglTAmeQSwAAe85BDQ (envelope-from ) for ; Sun, 06 Oct 2024 11:06:17 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=bR1exggE; dkim=fail ("headers rsa verify failed") header.d=nanein.fr header.s=mail header.b=oUMTXpbc; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1728205577; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=Xlbm3UItfUQSuX8lC8EOPK25EvY7vjAiy/Xj/2a+O1M=; b=jfvbP2MB7tUe7vCZinOZp0qMdbgGAWtEEWVhAC3/wdyk9lNiCXKM73gEsTe4kuDnCNxXgV AAXWb9UggzHhOk+LMpoodB8I7HuV8OIiQyuGoCfu6tFJ14IWe4Gn9DHJuJu0iTNBSwZouf DOMZQcIDW0CnSg2oyK8YZQC3qcLqLyAa4VUZfo1zVVyAPnR0F//KCVZmSbADUD5joJafUD 0nRrCJ6WcLn4oUp6YX7lTJOrT6dMIUcv+UbTySnIIoufdi+Uv9DSkiCnli6kU9JjtMvoHN Wn/XqWjiw/5s1eSlw9cj8yHPPTAep7L4rAiCQNAmnITsaS51JglJ/bm6/MWvxg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1728205577; a=rsa-sha256; cv=none; b=cmx6k7gp8oQCCDQttB2V405QKe+z/zURaWpAuIboXgRYau2vBEGL/v9tjRSp1E2qfUiiTg sjs9p44BRirA3CBYhas+kdMD0yxyu1x3rICJ/+4jixKHOf1UbUH3Pld+aXsvqirSKLi4PL aD2DAADzuWZDoFPm1sKyMFhzA0aQBdHh7LXCEwYhb4zcsPXQdq80aMQT382U9LJcafeglq EVkEXPhUanTk8LR//p++4AbAJOfQZmGZL/NnCiRj6qmMXp4t5XKwXoJMV7hcvrUANjqqgF 33XcT/x+gr6GExZl5EZdMIR8sN3Xweo7Dijw6k2z8bS9Cei6RaZhaolqjKoYkQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=bR1exggE; dkim=fail ("headers rsa verify failed") header.d=nanein.fr header.s=mail header.b=oUMTXpbc; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0B7F07E2D for ; Sun, 06 Oct 2024 11:06:16 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sxNDC-0002Z1-JC; Sun, 06 Oct 2024 05:05:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sxNDA-0002Yl-N7 for guix-patches@gnu.org; Sun, 06 Oct 2024 05:05:56 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sxNDA-0001JE-EN for guix-patches@gnu.org; Sun, 06 Oct 2024 05:05:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=Xlbm3UItfUQSuX8lC8EOPK25EvY7vjAiy/Xj/2a+O1M=; b=bR1exggEALR8Rsf7qtKnkNoEmbOennCdAwARJU85G3io9u/oHdLcL+Sq2QeQjiMrc7hybtyUis/7Yv7cE14igVWAZTifmefQgvd/rt45J129aTm6DWN9q28lGCQq5aBKfErOjLkMxGue5Tl2Er1jPbJV1ZUzSg0OhuIisy2ny1Di9bZDuBkMMGsdXP4HisFCbRT28jN/MOW9PNgR27MQBwCbz5vrKOJADQMMTIgnEc+1o7+/J7j4aTOc5MZo1+uJGfPj26y8jL1Nv6agouu4kmnX7bMXw2UP8qarZ0G+RmVKbB8XclEBRoa0jFEbQd1/TLuByD5wYigdXWtL32Kq3Q==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sxNDG-0003UM-1z for guix-patches@gnu.org; Sun, 06 Oct 2024 05:06:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#72714] [PATCH] home: services: Add 'home-sway-service-type'. Resent-From: Arnaud Daby-Seesaram Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 06 Oct 2024 09:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72714 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "pelzflorian (Florian Pelz)" Cc: Hilton Chain , Ludovic =?UTF-8?Q?Court=C3=A8s?= , 72714@debbugs.gnu.org Received: via spool by 72714-submit@debbugs.gnu.org id=B72714.172820555913402 (code B ref 72714); Sun, 06 Oct 2024 09:06:02 +0000 Received: (at 72714) by debbugs.gnu.org; 6 Oct 2024 09:05:59 +0000 Received: from localhost ([127.0.0.1]:40136 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sxNDC-0003U5-N4 for submit@debbugs.gnu.org; Sun, 06 Oct 2024 05:05:59 -0400 Received: from nanein.fr ([185.230.78.41]:56896) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sxND9-0003Tp-LN for 72714@debbugs.gnu.org; Sun, 06 Oct 2024 05:05:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nanein.fr; s=mail; t=1728205544; bh=aGMDZvBFmq6DV45lROn0VE4CjpcZZ0ep50c05P/0wnE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=oUMTXpbcH+m2Ioy+rl+1Kuv5XhXQ/J6f6aNkinBR4GxlffB4tfvGh2LnWcPKZpm2F uykTFKWLkuflCzq3uZJEmbojt+tDVuWJzEYAfG/YcxDT6/ckcyP6Qwh2c5dWcKEmAV t8NyPPKlMx7ZkRaaIScxDyPp1VLGPPqMsVSa0fw/sR+tXs/zyeeMqBA5uea17KzKl+ G6VhqOz8z778mqeHuKXAAPfMDooUyjd+idY6BqCaGNJMsftZX8CXBx7535zUOuiYT7 /+Bu4/Evu7v2unxGkeVCtGi+YJRgO/nyut3zEMgrNnXv7EiPzitQwewg0f3kKHBfrp UMvymmbzUehR6BnJS/YAF6O/n43bKXSMReSdIOyfkvdO+FDvsOuPTKIR4XgKEdFvuE v79FvP132jdkEIzl3NIu7jmSLkghSW2OxhoeBi1+9nav6s2Yauly3FJI1kiXYnBH32 BR0S72EJdZUYCorpXwEhq10/nByOvl6uPNNEDydDpGEDU09zyhAhYkOh3fQ4oKUM+4 vZpvCh1JqD2qKird5B2TPptNjf9jjv+QE0lBan3JRJrijMgKYMAuACX6QtpJnPYF9X ByHcoO7/fX04I+ytH1dV6zMyqMUGyNcfwFxo9R/D4iAgNgQ3X+kgscywEUzse7CY17 kcDM7W3t6nmZb69f8WMLlV8k= Received: from cochea (unknown [212.178.179.82]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by nanein.fr (Postfix) with ESMTPSA id EAC76140268; Sun, 6 Oct 2024 11:05:43 +0200 (CEST) In-Reply-To: <8734l94pga.fsf@pelzflorian.de> (pelzflorian@pelzflorian.de's message of "Sun, 06 Oct 2024 10:15:33 +0200") References: <87zfno52ig.fsf@gnu.org> <20241001221313.2490-1-ds-ac@nanein.fr> <878qv6tx5i.fsf@pelzflorian.de> <87ttdu9qmo.fsf@nanein.fr> <875xq9we7n.fsf@pelzflorian.de> <877caoewmh.fsf@nanein.fr> <87jzenr5bj.fsf@pelzflorian.de> <877camv5yk.fsf@nanein.fr> <8734l94pga.fsf@pelzflorian.de> Date: Sun, 06 Oct 2024 11:05:31 +0200 Message-ID: <87wmily52c.fsf@nanein.fr> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Arnaud Daby-Seesaram X-ACL-Warn: , Arnaud Daby-Seesaram via Guix-patches From: Arnaud Daby-Seesaram via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -4.96 X-Spam-Score: -4.96 X-Migadu-Queue-Id: 0B7F07E2D X-Migadu-Scanner: mx13.migadu.com X-TUID: 3X9DfY7GfUyM --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Florian, "pelzflorian (Florian Pelz)" writes: > Thank you Arnaud for this mountain of work. With pleasure :). > Arnaud Daby-Seesaram writes: >> Also: given that you assisted me quite a lot, do you want me to add a >> line in the commit message to express that you helped me write the >> patch > > Not for my review; this would be unusual. Noted. > Normally scm->go is probably unneeded here, because guile will find the c= ompiled > .go file. However program-file seems to add --no-auto-compile. Not > sure now. I do not know why the flag --no-auto-compile is passed either. > Another more thing. I try (bar (sway-bar)), but it prints an empty bar > configuration to .config/sway/config. In patch 6, you added > no-serialization. Did this break it? Hmmm, I am not sure. It is normal that `(sway-bar)' is an empty bar configuration (as all bar fields are now optional or empty by default). However, no configuration block should appear in the serialised configuration in this case. Maybe you need to pass --fresh-auto-compile to Guile when executing your test scripts (so that it does not trust its cache). I realised once that when updating the module `(gnu home services sway)', my test files would not be recompiled and old serialisation functions were used. In v6, `serialize-bar' looks like =2D-8<---------------cut here---------------start------------->8--- (add-block* "bar [bar name]" [possibly empty list L1] [...] [possibly empty list Ln]) =2D-8<---------------cut here---------------end--------------->8--- Thus, if all lists `Li' are empty, this should not add any line to the configuration file. (Except for the header "# Bar configuration.[...]", as it is added in the main serialisation function). In my current version of the patch, the header is also removed if nothing follows. Currently (on my local files), `(sway-configuration (bar (sway-bar)))' is serialised into the following: =2D-8<---------------cut here---------------start------------->8--- #################################### ### Auto-generated configuration ### #################################### # DO NOT EDIT MANUALLY. # Variables. ############ [ ... default variables ... ] # Keybindings. ############## [ ... default keybindings ...] # Gestures. ########### [ ... default gestures ...] # Programs to execute (at startup). ################################### [ ... default startup programs ...] =2D-8<---------------cut here---------------end--------------->8--- and `(sway-configuration (bar (sway-bar (hidden-state 'show))))' is serialised into: =2D-8<---------------cut here---------------start------------->8--- #################################### ### Auto-generated configuration ### #################################### # DO NOT EDIT MANUALLY. # Variables. ############ [ ... ] # Bar configuration. #################### bar bar0 { hidden_state show } # Keybindings. ############## [ ... ] # Gestures. ########### [ ... ] # Programs to execute (at startup). ################################### [ ... ] =2D-8<---------------cut here---------------end--------------->8--- So at least, the v8 should behave as expected. Best regards, =2D-=20 Arnaud --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJEBAEBCgAuFiEEMgqfJ4U0fby1t860ojLKXoMTiAwFAmcCUtwQHGRzLWFjQG5h bmVpbi5mcgAKCRCiMspegxOIDCjBD/9+bPkvTbIt6eF8km+cT0erkoF2EFdJ2x1a /CC/1y/cDHnZXOYlIZi5FC7I8Mg3uURful7ExtS1Q0pDcMtOrX8rbZwTvb/fRneB UtfISHkrPDnLHkUiEkbpVbByCmu2Z15Y4Uts5JPLufpX09pUkfI4ez7p71RUGxV5 MaRWvnN1O18ZnXxqWosLGyJbFm0yX7qE8L3S7qkE60yrbF6f4KdCrocNavGMC0Jf +so3i/lTK791LBZ6WJRGsKiVCiX9oPqhaDB69AZ8EuPBbxdDWs8ifDwgwfensqBT +7YGr6uO7sa1Vegy5bS5iQkT/bwF2hICQH0Y6U1Sapx3TDRqjy7Q3AWD99R8Pkt+ J7NyMJnKcQVY6SVtKynlcccoq+Lrm99zH3lRzJEn/dknv+epTAwgR4bsePUPD4SA qFFxmRN4F5zp6Zwhjss79iK5AyTo3DSiNp0jpgB/lYw4LaBXuYNq8VsA75m6UtQN EkZgp+9fIGJsQatbFYLAxA04RoOtTTOCznS0WHLBDRujeOKpe0jRnALn/RBrrflU Jhdb8L1ZdwwFJAeNgsBZ2PRCCwfzdEtUbsVFrZtkrB0fObS2REXyW4V2z/HzpxTk guDc20B2W3hNq8hQNaJKspVtGK7po60EM6EuUaw9F/37T07jm/aJQl8biCVukpK8 IN1Rqq1FEw== =8x6o -----END PGP SIGNATURE----- --=-=-=--