unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#73646] [PATCH] emacs-alchemist: add alchemist-server output
@ 2024-10-05 21:25 bigbookofbug--- via Guix-patches via
  2024-10-06 13:40 ` Liliana Marie Prikler
  2024-10-15  7:20 ` bug#73646: " Nicolas Goaziou via Guix-patches via
  0 siblings, 2 replies; 4+ messages in thread
From: bigbookofbug--- via Guix-patches via @ 2024-10-05 21:25 UTC (permalink / raw)
  To: 73646; +Cc: emma thompson

From: emma thompson <bigbookofbug@proton.me>

---
 gnu/packages/emacs-xyz.scm | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 09ac57a464..5567c38a3a 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -4046,6 +4046,15 @@ (define-public emacs-alchemist
     (build-system emacs-build-system)
     (propagated-inputs
      (list emacs-elixir-mode emacs-dash emacs-company emacs-pkg-info))
+    (arguments
+     '(#:phases (modify-phases %standard-phases
+                  (add-after 'install 'install-server
+                    (lambda* (#:key outputs #:allow-other-keys)
+                      (let* ((out (assoc-ref outputs "out"))
+                             (server (string-append out "/share/emacs/site-lisp/alchemist-1.8.2/alchemist-server")))
+                        (mkdir-p server)
+                        (copy-recursively "alchemist-server" server)
+                        (delete-file-recursively (string-append server "/test"))))))))
     (home-page "http://www.github.com/tonini/alchemist.el")
     (synopsis "Elixir tooling integration into Emacs")
     (description

base-commit: 002df8abd2f4d7c5d23febb1459b77c880345ca7
-- 
2.46.0






^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#73646] [PATCH] emacs-alchemist: add alchemist-server output
  2024-10-05 21:25 [bug#73646] [PATCH] emacs-alchemist: add alchemist-server output bigbookofbug--- via Guix-patches via
@ 2024-10-06 13:40 ` Liliana Marie Prikler
  2024-10-06 17:06   ` emma via Guix-patches via
  2024-10-15  7:20 ` bug#73646: " Nicolas Goaziou via Guix-patches via
  1 sibling, 1 reply; 4+ messages in thread
From: Liliana Marie Prikler @ 2024-10-06 13:40 UTC (permalink / raw)
  To: bigbookofbug, 73646

Am Samstag, dem 05.10.2024 um 21:25 +0000 schrieb
bigbookofbug@proton.me:
> From: emma thompson <bigbookofbug@proton.me>
> 
> ---
>  gnu/packages/emacs-xyz.scm | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 09ac57a464..5567c38a3a 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -4046,6 +4046,15 @@ (define-public emacs-alchemist
>      (build-system emacs-build-system)
>      (propagated-inputs
>       (list emacs-elixir-mode emacs-dash emacs-company emacs-pkg-
> info))
> +    (arguments
Prefer the new style, that is (list #:phases ...)
> +     '(#:phases (modify-phases %standard-phases
> +                  (add-after 'install 'install-server
> +                    (lambda* (#:key outputs #:allow-other-keys)
> +                      (let* ((out (assoc-ref outputs "out"))
> +                             (server (string-append out
> "/share/emacs/site-lisp/alchemist-1.8.2/alchemist-server")))
Is there a better way to encode this path?  You might also want to look
into #:include, which is already provided by emacs-build-system.
> +                        (mkdir-p server)
> +                        (copy-recursively "alchemist-server" server)
> +                        (delete-file-recursively (string-append
> server "/test"))))))))
Cheers

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#73646] [PATCH] emacs-alchemist: add alchemist-server output
  2024-10-06 13:40 ` Liliana Marie Prikler
@ 2024-10-06 17:06   ` emma via Guix-patches via
  0 siblings, 0 replies; 4+ messages in thread
From: emma via Guix-patches via @ 2024-10-06 17:06 UTC (permalink / raw)
  To: Liliana Marie Prikler; +Cc: 73646

[-- Attachment #1: Type: text/plain, Size: 3961 bytes --]

"Liliana Marie Prikler" <liliana.prikler@gmail.com> writes:

> Am Samstag, dem 05.10.2024 um 21:25 +0000 schrieb
> bigbookofbug@proton.me:
>> From: emma thompson <bigbookofbug@proton.me>
>>
>> ---
>>  gnu/packages/emacs-xyz.scm | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>
>> diff --git a/gnu/packages/emacs-xyz.scm 
>> b/gnu/packages/emacs-xyz.scm
>> index 09ac57a464..5567c38a3a 100644
>> --- a/gnu/packages/emacs-xyz.scm
>> +++ b/gnu/packages/emacs-xyz.scm
>> @@ -4046,6 +4046,15 @@ (define-public emacs-alchemist
>>      (build-system emacs-build-system)
>>      (propagated-inputs
>>       (list emacs-elixir-mode emacs-dash emacs-company 
>> emacs-pkg-
>> info))
>> +    (arguments
> Prefer the new style, that is (list #:phases ...)
>> +     '(#:phases (modify-phases %standard-phases
>> +                  (add-after 'install 'install-server
>> +                    (lambda* (#:key outputs 
>> #:allow-other-keys)
>> +                      (let* ((out (assoc-ref outputs "out"))
>> +                             (server (string-append out
>> "/share/emacs/site-lisp/alchemist-1.8.2/alchemist-server")))
> Is there a better way to encode this path?  You might also want 
> to look
> into #:include, which is already provided by emacs-build-system.
>> +                        (mkdir-p server)
>> +                        (copy-recursively "alchemist-server" 
>> server)
>> +                        (delete-file-recursively 
>> (string-append
>> server "/test"))))))))
> Cheers

hi and thanks for the advice on use of #:include. would the 
following be preferrable? output produced the directory correctly 
(also added info to copyright section as that part had slipped my 
mind:

 ;;; Copyright © 2024 Ashish SHUKLA <ashish.is@lostca.se>
 ;;; Copyright © 2024 Artyom V. Poptsov <poptsov.artyom@gmail.com>
 ;;; Copyright © 2024 Spencer King <spencer.king@nursiapress.com>
+;;; Copyright © 2024 emma thompson <bigbookofbug@proton.me>
 
 ;;;
 ;;; This file is part of GNU Guix.
@@ -4047,22 +4048,15 @@ (define-public emacs-alchemist
     (propagated-inputs
      (list emacs-elixir-mode emacs-dash emacs-company 
      emacs-pkg-info))
     (arguments
-     '(#:phases (modify-phases %standard-phases
-                  (add-after 'install 'install-server
-                    (lambda* (#:key outputs #:allow-other-keys)
-                      (let* ((out (assoc-ref outputs "out"))
-                             (server (string-append out 
                              "/share/emacs/site-lisp/alchemist-1.8.2/alchemist-server")))
-                        (mkdir-p server)
-                        (copy-recursively "alchemist-server" 
                         server)
-                        (delete-file-recursively (string-append 
                         server "/test"))))))))
-    (home-page "http://www.github.com/tonini/alchemist.el")
-    (synopsis "Elixir tooling integration into Emacs")
-    (description
-     "This package brings you all the Elixir tooling and power 
      inside your Emacs
+     (list #:include '(cons "^alchemist-server/" 
%default-include)))
+     (home-page "http://www.github.com/tonini/alchemist.el")
+     (synopsis "Elixir tooling integration into Emacs")
+     (description
+      "This package brings you all the Elixir tooling and power 
inside your Emacs
 editor.  It comes with commands to compile, execute and test your 
 code, spawn
 an interactive shell, and look up definitions and documentation 
 as well as
 code completion and project management support.")
-    (license license:gpl3+)))
+     (license license:gpl3+)))
 
 (define-public emacs-auto-compile
   (package

-- 
emma
EF515F7D600717781DF9AB2E0FB1CF2867A117F5

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 881 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#73646: [PATCH] emacs-alchemist: add alchemist-server output
  2024-10-05 21:25 [bug#73646] [PATCH] emacs-alchemist: add alchemist-server output bigbookofbug--- via Guix-patches via
  2024-10-06 13:40 ` Liliana Marie Prikler
@ 2024-10-15  7:20 ` Nicolas Goaziou via Guix-patches via
  1 sibling, 0 replies; 4+ messages in thread
From: Nicolas Goaziou via Guix-patches via @ 2024-10-15  7:20 UTC (permalink / raw)
  To: bigbookofbug--- via Guix-patches via; +Cc: bigbookofbug, 73646-done

Hello,

bigbookofbug--- via Guix-patches via <guix-patches@gnu.org> writes:

> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 09ac57a464..5567c38a3a 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -4046,6 +4046,15 @@ (define-public emacs-alchemist
>      (build-system emacs-build-system)
>      (propagated-inputs
>       (list emacs-elixir-mode emacs-dash emacs-company emacs-pkg-info))
> +    (arguments
> +     '(#:phases (modify-phases %standard-phases
> +                  (add-after 'install 'install-server
> +                    (lambda* (#:key outputs #:allow-other-keys)
> +                      (let* ((out (assoc-ref outputs "out"))
> +                             (server (string-append out "/share/emacs/site-lisp/alchemist-1.8.2/alchemist-server")))
> +                        (mkdir-p server)
> +                        (copy-recursively "alchemist-server" server)
> +                        (delete-file-recursively (string-append server "/test"))))))))

Applied. Thank you.

Regards,
-- 
Nicolas Goaziou






^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-10-15  7:59 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-05 21:25 [bug#73646] [PATCH] emacs-alchemist: add alchemist-server output bigbookofbug--- via Guix-patches via
2024-10-06 13:40 ` Liliana Marie Prikler
2024-10-06 17:06   ` emma via Guix-patches via
2024-10-15  7:20 ` bug#73646: " Nicolas Goaziou via Guix-patches via

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).