From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id 4DaNC4XLFGeCrwAAe85BDQ:P1 (envelope-from ) for ; Sun, 20 Oct 2024 09:21:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id 4DaNC4XLFGeCrwAAe85BDQ (envelope-from ) for ; Sun, 20 Oct 2024 11:21:09 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=qOfe680U; dkim=fail ("headers rsa verify failed") header.d=gmx.com header.s=s31663417 header.b=JxNUMl8Z; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1729416069; a=rsa-sha256; cv=none; b=US/QvuK+yqiiYeaPWq0npUl0tiVbaAw5g/BUFg/jDWsJZpo8CcSdGurGRHZAj4YgtGFNUe rg1qz0jVR/qhInFK1lPJk4WWpQu0y9h7QzDmVkNfxUquVOo8BV6eaeLmDWTWTGao5cqDGU MiVDQvE3qkA717DsLKVuJUiCmwUoEB4yKhZJ+TjZKQygW3lzLjIxIjSIwuvoexpxHlh33H HByE4w2r9bNS2VphPp2RKKzyObySYivOcTpJ2tdvgymupMOEXycJPh1QxCdBFTDc2YVoOu E7Uvdhl72O9hUM2dLuakx6NVmTpNB2CLxDKZ7EX2Mw3AACyFG+ICIfmom09f3A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=qOfe680U; dkim=fail ("headers rsa verify failed") header.d=gmx.com header.s=s31663417 header.b=JxNUMl8Z; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1729416069; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=xLW7hYGteTSGGAH/I2x3Xdok9qUFYOQCMn5770dENgA=; b=ub0CAr3BDIj64YcpKFbZ14fqD4iLF57zJlKeqvAjgxD306o0K8tkLl0L4I7vCNYhJvFS7j jNRbpsTvaotozFloobi9+y9WH0ABFX674QSxPspVQgl+/4BYSk8pEFPpMQ+8AIrLCybVc1 +6CTLLUBlf0oVZ1Nbb6aSNn+zK86m7CcNzE4t27pJYkjLTytZ36+DX0dYzZEN1t8B96OBG GvhrnIjC5qMPeuMp7+GiW5XBlloxJQ0w4yqyOjWz2gkZ3jKTw1hy+1W7ZbefpiZM431Yfk nCb7R1m+hvLXDUAGqHgL0pZAvp6CzC+jjOLs01QVu3J7h3LA6Vl0MoxTcV0w/Q== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AA088370C for ; Sun, 20 Oct 2024 11:21:08 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t2S78-0008Rv-V7; Sun, 20 Oct 2024 05:20:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t2QCz-0003dQ-WA for guix-patches@gnu.org; Sun, 20 Oct 2024 03:18:38 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t2QCz-0000pJ-Nu for guix-patches@gnu.org; Sun, 20 Oct 2024 03:18:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=xLW7hYGteTSGGAH/I2x3Xdok9qUFYOQCMn5770dENgA=; b=qOfe680UiQkSeNBoytXJCsY8TNc5eGxCWs1LaW2xC3yppj1WTMV0oTyw3FfiC/tJ5XHNy4Y6Hesl3s67C2p1GuTHA39xF9atr7UCauOjUIlktDm2zyAliT0gUah3zf36gO3wouGbxaPXcceg6r6HohbaTQni2XO7/wA5MljII6qCD79B9+43m1TxjtxubSd2E56/NYJG/5yYiQjEnSIlych++sGqtx2e0qT6m4vaX68XvL88z+SOe+LQgQ7U9+iNz1Oke99AEdO0aFxD8bQ2h3a74CWHxBpPj16alptUCXm975r/ILeUSH/C/1xftspIjV5ZJiDjWgp+NL+1Z31Hxw==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t2QDO-0007ZM-C5 for guix-patches@gnu.org; Sun, 20 Oct 2024 03:19:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#73647] [PATCH] Add indicator-sound-switcher Resent-From: Nicolas Graves Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 20 Oct 2024 07:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73647 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Sebastian Willenbrink , 73647@debbugs.gnu.org Cc: Sebastian Willenbrink Received: via spool by 73647-submit@debbugs.gnu.org id=B73647.172940873729087 (code B ref 73647); Sun, 20 Oct 2024 07:19:02 +0000 Received: (at 73647) by debbugs.gnu.org; 20 Oct 2024 07:18:57 +0000 Received: from localhost ([127.0.0.1]:45582 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t2QDJ-0007Z0-7y for submit@debbugs.gnu.org; Sun, 20 Oct 2024 03:18:57 -0400 Received: from mout.gmx.net ([212.227.15.19]:60627) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t2Q91-0007Lk-44 for 73647@debbugs.gnu.org; Sun, 20 Oct 2024 03:14:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.com; s=s31663417; t=1729408440; x=1730013240; i=ngraves@gmx.com; bh=xLW7hYGteTSGGAH/I2x3Xdok9qUFYOQCMn5770dENgA=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=JxNUMl8Z4Y4BrAP31z6wxBY/lAp8fyvX5n03UssGEGmRuJ/NVyckIJ5mARCzWdIM 6yZei5wgAoxT8uZR8a8JhEysO6qYPJRqbWf74K0+LmYXJKXtX/iaB1Ri54yuYXqqv Tr0nry7s1DKYhhYmYjg9Zd3MlIMnipv2aMrNItVPQccypZQu7QVoD+POOMAG92E6N 9Qk4pXh5/ftuKx3dpSFECyYuD9YAs5MzwJhsiFRzj0jvkA2L2gyn4Gw8VNlT3Habw Gc5rxJApYewFysmdLZLfsHlkj5kId1TppycvcI4vbQKv6dwpO7kD8azUuuEiFHcgq +Xl+jDLPTFJbIhtulw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from localhost ([176.179.140.244]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MMXQ5-1tJoIK3fa3-00Ncd5; Sun, 20 Oct 2024 09:14:00 +0200 In-Reply-To: <1266383a76e3fe2cd6e05894e3c04b5b5fdc0242.1728154207.git.sebastian.willenbrink@gmail.com> References: <1266383a76e3fe2cd6e05894e3c04b5b5fdc0242.1728154207.git.sebastian.willenbrink@gmail.com> Date: Sun, 20 Oct 2024 09:13:59 +0200 Message-ID: <87wmi3456w.fsf@ngraves.fr> MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:/TciVK+LzpVgm85nI3/zaZv/Ng2roMV/Zap4hTzmx2oLQWQfsJN MS6nEca2iOBAyv0kejgbc447jzkdtTuK+tqeeBoYHXCRiWNpj4e+/zA63hjC749pz1ljXoM raw4s7gkoT89wDGMDyxpIRyPgicK1FCtGh+90l+G22BSuAr3RKqYpTs9DJ1C9E1+hCjL+Dy xGRNtX21q1dAYl7U4bmrA== UI-OutboundReport: notjunk:1;M01:P0:JxkK3uTlcRc=;ZG9rdOf4Hs3JkCB/zJj1Kn9dt4j f5w7P87+3cG7YYvfJ9Jvo3zupZziy/D4DkbcBn3AsvBFEmaf3tej6LEAZG0kouG4SpBOLzKuS J+1XVwQuu8ZESpiGxbEow9dYCmt6qFUAjYqftT7RTnsbOQPGB7TF+jT0tzHS1zJiP4meb6JxX 3hdBEt+uP0gvFh7kB/3eIC/bGea7wb77WFGR+rUFj/crSjVlRddTXwZxA+4ODRXq1KFsHwWCG gabCGU1UmofqDVBT5A4dTBClwW2MB8rEXonvtcRV8HYbVBS9zznmNHddekrXMX5IMqgbBIxX4 0zVB4JoFt+P1q/7Hwl1yAX2TWwxw11Cj8zCgYcp8RAvq1I9bEuFeo+T/ougoEO22wnhopx7tE T1LdEblHWmFmuTk3j7lR0yKKpxW21Fm6Z+yX0X0mDQabi3u8SvzIANF6YFPfh58hih38WWkBz ZVCytLg65kqgjTEetku8qACSRa+zZN3OD0G1hXY1163i5nk8gDA9N0qeXsabClhCz/heFus+Y zJLQy7EESnbkDgEql846ltA0sIFTgb+Ei1UTf+MW984BTGsIazv1brZM09smE7S9DIW6fAciz 50iuiaA68wbHboX4wnMeobDU0+BRIUJIrba3/551ZQqjGDsh8edNbLkOQOWMomaIomuYw+GLg WiVmB+9coRROgCQk55X5m0ndAuD4JN+sCRMO1fOyeWOsvW0mD9+ytlcBL+hHy66y2YbcBHsbD SUBbK2RboVUhI7GF+JvgPwAfKH/2ummoCumJ2njJOcn8NaTXUDWevQGTDj5jCW+DVGZ/gQX7W WL8w8jyPqqkuHsg9oW2j/HNxSbBGzcztSx530g/Ib6Wgg= Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Sun, 20 Oct 2024 03:18:52 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Mailman-Approved-At: Sun, 20 Oct 2024 05:20:40 -0400 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Nicolas Graves X-ACL-Warn: , Nicolas Graves via Guix-patches From: Nicolas Graves via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: 1.00 X-Spam-Score: 1.00 X-Migadu-Queue-Id: AA088370C X-Migadu-Scanner: mx12.migadu.com X-TUID: txL+RYlSrjau Hi! Below some review comments ;) On 2024-10-05 20:50, Sebastian Willenbrink wrote: > +(define-public indicator-sound-switcher > + (package > + (name "indicator-sound-switcher") > + (version "2.3.10.1") > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/yktoo/indicator-sound-switcher") > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 "0y52k56ww2327r7ywwdvld5lx85qmcy8yrpaxc5lim7w3jbf3s85")= ))) > + (build-system python-build-system) > + (native-inputs (list gettext-minimal gobject-introspection)) > + (inputs (list python-pygobject girara python-pulsectl pulseaudio)) > + (propagated-inputs (list libappindicator keybinder)) > + (arguments > + (list > + #:phases #~(modify-phases %standard-phases > + (add-before 'install 'patch-xdg-autostart > + (lambda* (#:key inputs outputs #:allow-other-keys) > + (let* ((pulseaudio (assoc-ref inputs "pulseaudio= ")) > + (pulse (string-append pulseaudio > + "/lib/libpulse.so.0= "))) We rather use (search-input-file inputs "/lib/libpulse.so.0") now. It's also shorter, so you can probably drop the let* and use that directly in the substitute* > + (substitute* "setup.py" > + (("/etc/xdg/autostart") > + '"share/etc/xdg/autostart")) > + (substitute* "lib/indicator_sound_switcher/lib= _pulseaudio.py" This line is probably above 79 characters. Use the next line ;) > + (("libpulse.so.0") > + pulse)))))))) > + (home-page "https://github.com/yktoo/indicator-sound-switcher") > + (synopsis "Sound input/output selector indicator for Linux") > + (description > + "It shows an icon in the indicator area or the system tray Please use "This package" or its name instead of it. > +(whatever is available in your desktop environment). > +The icon's menu allows you to switch the current sound input and output > +(i.e. source ports and sink ports in PulseAudio's terms, respectively) = with just two clicks:") This last line is too long and shouldn't end with : > + (license license:gpl3))) > > base-commit: 713f5562faf1acc02dc9e3f3a2d45dc39abbe9f1 You should also write a proper git commit message. There are templates in guix's source etc/snippets folder if you use emacs (either tempel or yasnippets). Or copy another gnu: Add [pkg] commit. I don't see other lints but for some reason the build is blocked for x86-64-linux on QA. =2D- Best regards, Nicolas Graves