From: Nicolas Graves via Guix-patches via <guix-patches@gnu.org>
To: Sebastian Willenbrink <sebastian.willenbrink@gmail.com>,
73647@debbugs.gnu.org
Cc: Sebastian Willenbrink <sebastian.willenbrink@gmail.com>
Subject: [bug#73647] [PATCH] Add indicator-sound-switcher
Date: Sun, 20 Oct 2024 09:13:59 +0200 [thread overview]
Message-ID: <87wmi3456w.fsf@ngraves.fr> (raw)
In-Reply-To: <1266383a76e3fe2cd6e05894e3c04b5b5fdc0242.1728154207.git.sebastian.willenbrink@gmail.com>
Hi!
Below some review comments ;)
On 2024-10-05 20:50, Sebastian Willenbrink wrote:
> +(define-public indicator-sound-switcher
> + (package
> + (name "indicator-sound-switcher")
> + (version "2.3.10.1")
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/yktoo/indicator-sound-switcher")
> + (commit (string-append "v" version))))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32 "0y52k56ww2327r7ywwdvld5lx85qmcy8yrpaxc5lim7w3jbf3s85"))))
> + (build-system python-build-system)
> + (native-inputs (list gettext-minimal gobject-introspection))
> + (inputs (list python-pygobject girara python-pulsectl pulseaudio))
> + (propagated-inputs (list libappindicator keybinder))
> + (arguments
> + (list
> + #:phases #~(modify-phases %standard-phases
> + (add-before 'install 'patch-xdg-autostart
> + (lambda* (#:key inputs outputs #:allow-other-keys)
> + (let* ((pulseaudio (assoc-ref inputs "pulseaudio"))
> + (pulse (string-append pulseaudio
> + "/lib/libpulse.so.0")))
We rather use (search-input-file inputs "/lib/libpulse.so.0") now.
It's also shorter, so you can probably drop the let* and use that
directly in the substitute*
> + (substitute* "setup.py"
> + (("/etc/xdg/autostart")
> + '"share/etc/xdg/autostart"))
> + (substitute* "lib/indicator_sound_switcher/lib_pulseaudio.py"
This line is probably above 79 characters. Use the next line ;)
> + (("libpulse.so.0")
> + pulse))))))))
> + (home-page "https://github.com/yktoo/indicator-sound-switcher")
> + (synopsis "Sound input/output selector indicator for Linux")
> + (description
> + "It shows an icon in the indicator area or the system tray
Please use "This package" or its name instead of it.
> +(whatever is available in your desktop environment).
> +The icon's menu allows you to switch the current sound input and output
> +(i.e. source ports and sink ports in PulseAudio's terms, respectively) with just two clicks:")
This last line is too long and shouldn't end with :
> + (license license:gpl3)))
>
> base-commit: 713f5562faf1acc02dc9e3f3a2d45dc39abbe9f1
You should also write a proper git commit message. There are templates
in guix's source etc/snippets folder if you use emacs (either tempel or
yasnippets). Or copy another gnu: Add [pkg] commit.
I don't see other lints but for some reason the build is blocked for
x86-64-linux on QA.
--
Best regards,
Nicolas Graves
next prev parent reply other threads:[~2024-10-20 9:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-05 18:50 [bug#73647] [PATCH] Add indicator-sound-switcher Sebastian Willenbrink
2024-10-06 20:51 ` [bug#73647] Small oversight Sebastian Willenbrink
2024-10-20 7:13 ` Nicolas Graves via Guix-patches via [this message]
2024-10-20 9:01 ` [bug#73647] [PATCH] Add indicator-sound-switcher Nicolas Graves via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmi3456w.fsf@ngraves.fr \
--to=guix-patches@gnu.org \
--cc=73647@debbugs.gnu.org \
--cc=ngraves@gmx.com \
--cc=sebastian.willenbrink@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).