unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Rodion Goritskov <rodion.goritskov@gmail.com>
Cc: 73989-done@debbugs.gnu.org
Subject: bug#73989: [PATCH games-team 0/2] Add TORCS.
Date: Tue, 12 Nov 2024 20:49:51 +0900	[thread overview]
Message-ID: <87wmh84qow.fsf@gmail.com> (raw)
In-Reply-To: <87msicdrkl.fsf@bumblebee-mighty.mail-host-address-is-not-set> (Rodion Goritskov's message of "Thu, 07 Nov 2024 00:40:10 +0400")

Hi!

Rodion Goritskov <rodion.goritskov@gmail.com> writes:

> I tried to apply and build this patchset with the current master.
> It applies fine (with some warnings on whitespaces).
>
> Plib builds fine. However, TORCS fails to build with the following error:
>
> building /gnu/store/1r1lq54yhvh748jsdmd1apdxss5qbk11-download.drv...
> source is at 'download'
> applying '/gnu/store/jlgga73s3qj44kkdqagqhg32ipiqmlrk-torcs-isnan.patch'...
> can't find file to patch at input line 7
> Perhaps you used the wrong -p or --strip option?
> The text leading up to this was:
> --------------------------
> |Source: https://src.fedoraproject.org/rpms/torcs/raw/rawhide/f/torcs-1.3.7-isnan.patch
> |Upstream-status:
> | https://sourceforge.net/p/torcs/mailman/torcs-devel/thread/0bd466b7-e158-471b-13ad-504167587d01%40embecosm.com/#msg35836767
> |
> |diff -up torcs-1.3.7/src/drivers/olethros/geometry.cpp.orig torcs-1.3.7/src/drivers/olethros/geometry.cpp
> |--- torcs-1.3.7/src/drivers/olethros/geometry.cpp.orig 2016-06-07 19:49:11.347896827 +0100
> |+++ torcs-1.3.7/src/drivers/olethros/geometry.cpp      2016-06-07 19:49:46.532894257 +0100
> --------------------------

Ah! That download.drv seemed wrong.  I think it is caused by a last
minute change I did following 'guix lint', which suggested adapting the
URL; I had added /download at the end of the URL and apparently that
threw off our unpacking phase, which no longer considered it a tarball
or something.

Anyway, fixed by adding a 'file-name' field to the origin, and pushed as
18bd867b24 as a fixup commit.

Enjoy!

-- 
Maxim




  reply	other threads:[~2024-11-12 11:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-24 15:45 [bug#73989] [PATCH games-team 0/2] Add TORCS Maxim Cournoyer
2024-10-24 16:04 ` [bug#73989] [PATCH 1/2] gnu: plib: Build with -fPIC Maxim Cournoyer
2024-10-24 16:04   ` [bug#73989] [PATCH 2/2] gnu: Add torcs Maxim Cournoyer
2024-11-06 20:40 ` [bug#73989] [PATCH games-team 0/2] Add TORCS Rodion Goritskov
2024-11-12 11:49   ` Maxim Cournoyer [this message]
2024-11-13  2:57   ` Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wmh84qow.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=73989-done@debbugs.gnu.org \
    --cc=rodion.goritskov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).