From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id ONKIKxiadmd8WgEAe85BDQ:P1 (envelope-from ) for ; Thu, 02 Jan 2025 13:52:24 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id ONKIKxiadmd8WgEAe85BDQ (envelope-from ) for ; Thu, 02 Jan 2025 14:52:24 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=QPZYltzT; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=EOmdTvXG; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1735825944; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=3Mos5f/ruxJ81Nnl75cvsMajVhvRdBSE2CanB+udvu8=; b=JpEE2F8jWhO9OjGJwG/NOhI5zA1p+ItuoPHk2+hXxw/qzUuAw5a7j/jK8wh8/FaXzOUq+U fkemgQsFQDQoTVcNAmyTGsiSpKqzUHPNLe8dO2/ibuh3q+HZjtB2hhqRx1loq4hUK1lXug uUMmdqD+BhmLNNe/8uAgIvGsV+hoiBaek5FzwkMbMT8PcAPyoOSwUDaPQmOhXwxrXw7vun vAFd2Hv9+fl2J1oK3Zv9lMB8uubzbzZfcnxl0ke0uzOXIuMODC/s8mr4Rka47urfLTd4a3 OfPzR3Ujz3Pyf9XSUxNvUrsHkffGl+TPbNTXnjzV4TMAITX5yvsAC8nDS1hcfQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=QPZYltzT; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=EOmdTvXG; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1735825944; a=rsa-sha256; cv=none; b=pTCZkdHG1Iqplb5Tz4rqTGvHeeHBdH7YdLpS4Q4hVTKb9afC9L+geqDWOASKbs2Tk1h/TA E4v/bknhGxoy+WoD8qfLsA+kJsCNJVIem1r2c+paLj5lWiWQXIaBXp/2k5JsDAWlaKJVN3 9Qf81Hqakq99ISRC9fYtaIfVJYuqLtA9mzwjjhB+Qw5RUgzoM19EyulmiYS5/pHkR0AvJy xz582jUkePEXiv8WOyjYayPMxPlkU3IymzNZ6tE0uQSlr8js4vGlcQUwq3IvGltpIHEJov FjQzsKp0s+PAP7QffyfUQ9VPXBs1eih2B7JnPTU2k8+9B1MkXc0E6a6+BnC+fg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 408F09473B for ; Thu, 02 Jan 2025 14:52:24 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tTLcL-0001YS-2Z; Thu, 02 Jan 2025 08:52:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tTLcJ-0001Y7-8L for guix-patches@gnu.org; Thu, 02 Jan 2025 08:52:03 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tTLcI-0001lA-VJ for guix-patches@gnu.org; Thu, 02 Jan 2025 08:52:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=3Mos5f/ruxJ81Nnl75cvsMajVhvRdBSE2CanB+udvu8=; b=QPZYltzTu/LhKPhPHqqFnykc8Yv54kNq2ApWA1niV6Xs6LVxKcnYYrhkjNbkzHaWd2xlijmHKObdI2Cc/Qb1JMqgxOUVXrNQ4MyT0cgcPUZPHrP+CxZCoNhDKa796Nrta1jHTjlNwykAZVSI1XU7IEB5HGqsqNz3ZKe4XLI1ZwJ6k965EJuX7lhoPCeZUOIsM0NYl4JUoTk1oHKTuIA+8vf7t7gE32j2GTuBWrG7GW7nu/2o/0ScWmkSajY8N/V0Yp8gX14h4TfD05Fw+GxaggnItzCrhQmrEW7q06WAFfRyuVKbXK4Po93cel/mrPDAKHJmYuU8I9idWGMyp3b6Dg==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tTLcI-0001Bm-MJ for guix-patches@gnu.org; Thu, 02 Jan 2025 08:52:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74405] [bug#74406] [PATCH 1/1] gnu: antlr4: Pass full path to java in bin executable Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 02 Jan 2025 13:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74405 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Rutherther Cc: Julien Lepiller , 74405@debbugs.gnu.org, 74406@debbugs.gnu.org Received: via spool by 74405-submit@debbugs.gnu.org id=B74405.17358259104545 (code B ref 74405); Thu, 02 Jan 2025 13:52:02 +0000 Received: (at 74405) by debbugs.gnu.org; 2 Jan 2025 13:51:50 +0000 Received: from localhost ([127.0.0.1]:43190 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tTLc5-0001BC-5k for submit@debbugs.gnu.org; Thu, 02 Jan 2025 08:51:49 -0500 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]:47259) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tTLc2-0001At-I8; Thu, 02 Jan 2025 08:51:47 -0500 Received: by mail-pl1-x634.google.com with SMTP id d9443c01a7336-21680814d42so133374385ad.2; Thu, 02 Jan 2025 05:51:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735825900; x=1736430700; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=3Mos5f/ruxJ81Nnl75cvsMajVhvRdBSE2CanB+udvu8=; b=EOmdTvXGhmmZNu1bn+o10sbXcnvmJqxAJA681qtv38EK9roOjW0tGJ31G/ZE9ZKnxC ptG2CHB3LbhDsMYLyXPVqjrwndKxCqWWKGQhGuBzOn0qsXSs+TJPCaJQaH5TPqcivobM Dyr662UJcG3XgvYh22Ub8s1MZ+aCzZrd4KC7binOCflCQEGxcVDUbEyVjoFwbcTS/mmt bWjmOOvLl+hj8cm1RxCpEr033GxY8qI40MzwxlQOpApVfDKx8w30SlANUC7Ifq6Asz8p xuGJS2V2TWPci72Je33xzYKDZeXcmwvDXiTHUXHwZ1heIUcZyNGUE/HS7A9EpgVqB5/Z 5I6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735825900; x=1736430700; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3Mos5f/ruxJ81Nnl75cvsMajVhvRdBSE2CanB+udvu8=; b=e9dk+kajg6vvL7WjDP1JFHAcSpuZnHSiJ4seED5IiAIUWQb0ZgbrCorGysHISEKpHx PHV+acF5tevrTUOcAfAf9OUu1A3BK4zVTqAoTs6q7oTqzjq4+yO1x8onauWnUaaJ4cPS EiMpD5ke++0eNxrm5iJW4D6JRPNhiSn2f4L7Mum7tPSK2ZJfk3JyxB41GsE/wnrNqo+3 jBFwJyj98bJo9/YyZbjpVrE4bwnr/2aZP4EcyEA0Q2FH/VVgSPAhqRMgg6ak6WL/dcYH nFRaj+lyddgIepjmoUOZ4zEZvlp7KucRxAEnuO/ixqosJKONZyRIyzBQsvB1H0No62zU HR0g== X-Forwarded-Encrypted: i=1; AJvYcCWPVFoz3ZeuKRa1XQiQezLHguUWtDCP9ibDQZBK++Xs1W8Vih8kRdqqcGd6fMG72N4szpLcvg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwGt2+Jt6Ab329ShMtis8sDDe1GY5NC2rZF1KGx3NPDxE9DDE8g WVJfxQSDh7TYcBnaSMSF+wMFrj62pZ9w+VVLnT54shtwqoCpCePUNageT0QC X-Gm-Gg: ASbGnctDlY3pwp1z4xtuNFVmobNTE608Xr8Jidkt5QPNj0A0Gr0fRYaLzesFwpl0QEP Oa8Cg0t76t1xB+VnvK2RbRz6rDCEiFxfGD4JkDdWUxloAWjJXq2dcyrSGhkgCgTqEcG1yEmOIwk vxNP2ptaQLZUBOjUY/TIkn1fncDPstMv+YuL60YbxBLbLbDLObU4xTZjyPTo7pmRzC3fBcFJvsN 6svxtehHx0nLgxFObnDLV7eUYwF7Ej4mCJYCz05SZIbRIOPI072lQ== X-Google-Smtp-Source: AGHT+IG1cXHduT7z+4SJDxLUJZbshYFpD01KnUs1j03nWidMESUdHswMweyChT3tqBzBNcHqPQvYiA== X-Received: by 2002:a17:902:c406:b0:215:854c:a71a with SMTP id d9443c01a7336-219e6ebb68dmr545512085ad.34.1735825900393; Thu, 02 Jan 2025 05:51:40 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dca013f4sm227754135ad.234.2025.01.02.05.51.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jan 2025 05:51:39 -0800 (PST) From: Maxim Cournoyer In-Reply-To: <27ea0b2b5326c827fd03399b4009c1bb62d81600.1731870758.git.rutherther@ditigal.xyz> (rutherther@ditigal.xyz's message of "Sun, 17 Nov 2024 20:43:58 +0100") References: <27ea0b2b5326c827fd03399b4009c1bb62d81600.1731870758.git.rutherther@ditigal.xyz> Date: Thu, 02 Jan 2025 22:51:28 +0900 Message-ID: <87wmfd5nof.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.65 X-Spam-Score: -4.65 X-Migadu-Queue-Id: 408F09473B X-Migadu-Scanner: mx10.migadu.com X-TUID: NdTAB8Jq44Y/ Hi Rutherther, Apologies for the delay, this had been tagged as SPAM by big G. Rutherther writes: > The executable outputted by antlr4 package does not > refer to full path of java, but to standalone "java". > That means the package expects java to be in PATH. > Since it's an application, requiring java to run, > it should rather refer to full path of java executable > it was built with/for. > > * gnu/packages/java.scm: (antrl4)[arguments]: Change "java" in bin/antlr4 for full path > > Change-Id: I311b9ec54a90fc7251eb8fcb62b232e843853e64 > --- > gnu/packages/java.scm | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm > index df57385ea7..8607b62bea 100644 > --- a/gnu/packages/java.scm > +++ b/gnu/packages/java.scm > @@ -8866,13 +8866,14 @@ (define-public antlr4 > (add-after 'install 'bin-install > (lambda* (#:key inputs outputs #:allow-other-keys) > (let ((jar (string-append (assoc-ref outputs "out") "/share/java")) > - (bin (string-append (assoc-ref outputs "out") "/bin"))) > + (bin (string-append (assoc-ref outputs "out") "/bin")) > + (java (search-input-file inputs "bin/java"))) > (mkdir-p bin) > (with-output-to-file (string-append bin "/antlr4") > (lambda _ > (display > (string-append "#!" (which "sh") "\n" > - "java -cp " jar "/antlr4.jar:" > + java " -cp " jar "/antlr4.jar:" Hm. I'm not sure what is the state of the art here for our Java packages; it makes sense that it should work out of the box, but perhaps there's a reason to want to have it run with any Java available on PATH? I'll defer to Julien, which I believe has done more work with Java in Guix. -- Thanks, Maxim