From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55187)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d0OYP-0007pD-9T
	for guix-patches@gnu.org; Tue, 18 Apr 2017 04:32:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d0OYM-00025l-6F
	for guix-patches@gnu.org; Tue, 18 Apr 2017 04:32:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:55208)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1d0OYM-00025h-3h
	for guix-patches@gnu.org; Tue, 18 Apr 2017 04:32:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d0OYL-0002kO-V5
	for guix-patches@gnu.org; Tue, 18 Apr 2017 04:32:01 -0400
Subject: bug#26544: [PATCH] system: Move "--load" and other guix-specific
	parameters from the grub module to the generic system module.
Resent-Message-ID: <handler.26544.B26544.149250426510497@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20170417170030.2212-1-dannym@scratchpost.org>
Date: Tue, 18 Apr 2017 10:30:53 +0200
In-Reply-To: <20170417170030.2212-1-dannym@scratchpost.org> (Danny
	Milosavljevic's message of "Mon, 17 Apr 2017 19:00:30 +0200")
Message-ID: <87vaq2rubm.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 26544@debbugs.gnu.org

Hi Danny,

Another quick preliminary review=E2=80=A6

Could you explain the =E2=80=9Cbig picture=E2=80=9D, the rationale behind t=
his change?

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> +(define (bootable-kernel-arguments kernel-arguments system root-device)
> +  (cons* (string-append "--root=3D" root-device)
> +         #~(string-append "--system=3D" #$system)
> +         #~(string-append "--load=3D" #$system "/boot")
> +         kernel-arguments))

Please add a docstring to top-level procedures:

  https://www.gnu.org/software/guix/manual/html_node/Formatting-Code.html

> +(define (operating-system-all-kernel-arguments os system root-device)
> +  (bootable-kernel-arguments (operating-system-kernel-arguments os)
> +                             system
> +                             root-device))

For services, we have:

  operating-system-user-services
  operating-system-services

So I suggest stick to this convention and thus have:

  operating-system-user-kernel-arguments     ;arguments specified by the us=
er
  operating-system-kernel-arguments          ;all the arguments

> -(define (operating-system-parameters-file os)
> +(define (operating-system-boot-parameters os system root-device)

I think it would be clearer to rename in a separate patch.

> +(define (read-boot-parameters-file sysgen)
> +  "Read boot parameters from SYSGEN's (system or generation) \"parameter=
s\"

Please use full words in variable names, typically =E2=80=98system=E2=80=99=
 here.

Thanks,
Ludo=E2=80=99.