unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Alex Kost <alezost@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 26693-done@debbugs.gnu.org
Subject: bug#26693: [PATCH 0/2] Fix indentation in indent-code.el and dir-locals.el
Date: Thu, 04 May 2017 22:47:00 +0300	[thread overview]
Message-ID: <87vapgcsln.fsf@gmail.com> (raw)
In-Reply-To: <87k25zym43.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Tue, 02 May 2017 23:39:24 +0200")

Ludovic Courtès (2017-05-02 23:39 +0200) wrote:

> Hi Alex,
>
> Alex Kost <alezost@gmail.com> skribis:
>
>> As reported by Petter on #guix, "indent-code.el" may not work, and it is
>> absolutely not clear why it happens (it took me 20 minutes to figure out
>> what the problem was).
>>
>> So the problem is that "indent-code.el" works only when it is run from
>> the top directory of the guix checkout (as it is described in the
>> manual), otherwise it doesn't indent properly (because it doesn't find
>> ".dir-locals.el").
>>
>> So the upcoming patch fixes this problem.  Also there is another patch
>> that indents 'modify-keywords' properly.
>
> Good catch!
>
>> * .dir-locals.el: Add indentation rules for 'replace', 'add-before' and
>> 'add-after'.
>
> OK.
>
>> >From d4abac119e2c62cc42a8786034c905196d7262e6 Mon Sep 17 00:00:00 2001
>> From: Alex Kost <alezost@gmail.com>
>> Date: Fri, 28 Apr 2017 16:07:33 +0300
>> Subject: [PATCH] etc: indent-code.el: Define source tree by "indent-code.el".
>>
>> * etc/indent-code.el.in: Set default directory by "indent-code.el"
>> itself, otherwise it works only when called from the top directory of
>> the guix source tree.
>
> LGTM.
>
> Thank you!

Committed, thanks!

-- 
Alex

      reply	other threads:[~2017-05-04 19:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-28 13:28 bug#26693: [PATCH 0/2] Fix indentation in indent-code.el and dir-locals.el Alex Kost
2017-04-28 13:44 ` bug#26693: [PATCH 1/2] dir-locals.el: Add 'modify-phases' keywords Alex Kost
2017-04-28 13:44   ` bug#26693: [PATCH 2/2] doc: Add references to Emacs-Guix manual Alex Kost
2017-04-28 13:52     ` Alex Kost
2017-05-02 21:39 ` bug#26693: [PATCH 0/2] Fix indentation in indent-code.el and dir-locals.el Ludovic Courtès
2017-05-04 19:47   ` Alex Kost [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vapgcsln.fsf@gmail.com \
    --to=alezost@gmail.com \
    --cc=26693-done@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).