From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47115)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d8S8x-0000Ss-Fw
	for guix-patches@gnu.org; Wed, 10 May 2017 09:59:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d8S8s-0007Qj-OA
	for guix-patches@gnu.org; Wed, 10 May 2017 09:59:07 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:34121)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1d8S8s-0007Qf-LT
	for guix-patches@gnu.org; Wed, 10 May 2017 09:59:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d8S8s-0002L3-Ep
	for guix-patches@gnu.org; Wed, 10 May 2017 09:59:02 -0400
Subject: bug#26803: [PATCH 06/36] gnu: Add java-asm.
Resent-Message-ID: <handler.26803.B26803.14944247018941@debbugs.gnu.org>
References: <20170506153617.3074-1-rekado@elephly.net>
	<20170506153617.3074-6-rekado@elephly.net> <87k25tk9dk.fsf@gnu.org>
From: Ricardo Wurmus <rekado@elephly.net>
In-reply-to: <87k25tk9dk.fsf@gnu.org>
Date: Wed, 10 May 2017 15:58:13 +0200
Message-ID: <87vap8hkzu.fsf@elephly.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Roel Janssen <roel@gnu.org>
Cc: 26803@debbugs.gnu.org


Roel Janssen <roel@gnu.org> writes:

>> +(define-public java-asm
>> +  (package
>> +    (name "java-asm")
>> +    (version "5.2")
>> +    (source (origin
>> +              (method url-fetch)
>> +              (uri (string-append "http://download.forge.ow2.org/asm/"
>> +                                  "asm-" version ".tar.gz"))
>> +              (sha256
>> +               (base32
>> +                "0kxvmv5275rnjl7jv0442k3wjnq03ngkb7sghs78avf45pzm4qgr"))))
>> +    (build-system ant-build-system)
>> +    (arguments
>> +     `(#:build-target "compile"
>> +       #:test-target "test"
>> +       ;; The tests require an old version of Janino, which no longer compiles
>> +       ;; with the JDK7.
>> +       #:tests? #f
>
> Why set the test-target if you disable the tests?

You’re right, that doesn’t make much sense.  I’ll remove it.

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net