[bug#27654] [PATCH] base: Report evaluation error.

[ludo@gnu.org (Ludovic Courtès)]

[-- Attachment #1: Type: text/plain, Size: 650 bytes --]

Mathieu Othacehe <m.othacehe@gmail.com> skribis:

> From c9a3325c1c021564edc689ff2421b04c9e794052 Mon Sep 17 00:00:00 2001
> From: Mathieu Othacehe <m.othacehe@gmail.com>
> Date: Tue, 11 Jul 2017 19:15:08 +0200
> Subject: [PATCH] base: Report evaluation error.
>
> * src/cuirass/base.scm (evaluate): Report an error if eof-object? is true on
>   data read from port. Otherwise, suppose that data are correct and keep thins
>   going.

Please mention the new ‘&evaluation-error’ in here.

BTW, shouldn’t ‘process-specs’ protect against it, so that Cuirass
doesn’t stop as soon as it encounters an evaluation error?  Like:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 788 bytes --]

diff --git a/src/cuirass/base.scm b/src/cuirass/base.scm
index fc3cc1a..3d19bda 100644
--- a/src/cuirass/base.scm
+++ b/src/cuirass/base.scm
@@ -185,9 +185,12 @@ if required.  Return the last commit ID on success, #f otherwise."
                                #:use-substitutes? (%use-substitutes?)
                                #:keep-going? #t)
 
+            (guard (c ((evaluation-error? c)
+                       ;; Report the problem in the log...
+                       #f))
               (let* ((spec* (acons #:current-commit commit spec))
                      (jobs  (evaluate store db spec*)))
-              (build-packages store db jobs))))
+                (build-packages store db jobs)))))
         (db-add-stamp db spec commit))))
 
   (for-each process jobspecs))

[-- Attachment #3: Type: text/plain, Size: 60 bytes --]


OK with something along these lines, thanks!

Ludo’.