From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57985) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dvouL-0003rI-I0 for guix-patches@gnu.org; Sat, 23 Sep 2017 14:12:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dvouI-0003ZD-AA for guix-patches@gnu.org; Sat, 23 Sep 2017 14:12:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:46170) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dvouI-0003Z6-5v for guix-patches@gnu.org; Sat, 23 Sep 2017 14:12:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dvouH-0003Za-Vw for guix-patches@gnu.org; Sat, 23 Sep 2017 14:12:02 -0400 Subject: [bug#28531] [PATCH] gnu: Add vcsh. Resent-Message-ID: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57856) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dvotD-0003dS-PF for guix-patches@gnu.org; Sat, 23 Sep 2017 14:10:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dvotA-00035s-Hw for guix-patches@gnu.org; Sat, 23 Sep 2017 14:10:55 -0400 Received: from dd5424.kasserver.com ([85.13.138.252]:44624) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dvotA-000356-BI for guix-patches@gnu.org; Sat, 23 Sep 2017 14:10:52 -0400 Received: from localhost (unknown [149.154.152.222]) by dd5424.kasserver.com (Postfix) with ESMTPA id D24CBB583D95 for ; Sat, 23 Sep 2017 20:10:46 +0200 (CEST) From: Stefan =?UTF-8?Q?Reich=C3=B6r?= In-Reply-To: <87vak9a875.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Sat, 23 Sep 2017 14:52:14 +0200") References: <150593626773.31985.7642001649222018304.stgit@sandburg> <87a81pru0m.fsf@gnu.org> <87o9q2o1bw.fsf@xsteve.at> <87vak9a875.fsf@gnu.org> Date: Sat, 23 Sep 2017 20:10:45 +0200 Message-ID: <87vak92sm2.fsf@xsteve.at> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 28531@debbugs.gnu.org Hi Ludo, > Hello, > > Stefan Reich=C3=B6r skribis: > >>> Hi Stefan, >>> >>> Stefan Reich=C3=B6r skribis: >>> >>>> * gnu/packages/version-control.scm (vcsh): New variable. >>> >>> Pushed with the minor changes below (the first sentence of the >>> description looked awkward to me). >>> >>> Note that vcsh takes =E2=80=98git=E2=80=99 from $PATH. I wonder if we = should keep it >>> this way, or if we should hard-code the absolute file name to =E2=80=98= git=E2=80=99 so >>> that it always works. >>> >>> Thoughts? >> >> I don't think that it is desirable to change all external tool >> invocations for programs in Guix. I am currently preparing the tool >> atool that has to invoke a lot of archivers. > > We always have a choice between =E2=80=9Cstatic binding=E2=80=9D (where w= e hard-wire a > tool and its dependencies) and =E2=80=9Clate binding=E2=80=9D (where the = dependencies > are searched for at run time.) > > Most of the time in Guix we favor static binding: it makes sure that (1) > programs work out of the box, regardless of what happens to be already > installed on your system, and (2) that the program will behave the same > on all systems since its behavior does not depend on external state. > > There are exceptions where we want dynamic binding, for instance for > plugins or optional/soft dependencies. > > The case of =E2=80=98vcsh=E2=80=99 is borderline. I have a slight prefer= ence to > hardwire the dependency on Git (after all, someone might want to use > vcsh without having installed Git before), but I=E2=80=99m open to other > arguments. > > Thoughts? Thanks for the explaination. I see the benefit of the static binding. The good thing is that the package versions are reproducable. However, I am used to the way it works on other systems. There is almost always the search path used to start other programs. And to make it even more complicated, I still use Ubuntu and install some tools using Guix. So it is even possible that I use vcsh from Guix and git from Ubuntu. I took a look at the vcsh script. git is hardcoded in many places there. Patching it to have static binding seems to be complicated. The only sane solution would be to change the script and make git configurable and try to make this change upstream. However I am not really keen on doing this kind of work... Or do you have another idea how the static binding should be accomplished? Stefan. > Thanks, > Ludo=E2=80=99. > > PS: Please preserve Cc:. o.k. - I interpreted the Cc: "28531-done@debbugs.gnu.org" as flag that the bug is closed and was unsure what will happen when I respond to the closed bug...