unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Dave Love <fx@gnu.org>
Cc: 28673@debbugs.gnu.org
Subject: [bug#28673] [PATCH 5/6] gnu: libunwind: Merge update and test changes.
Date: Tue, 03 Oct 2017 16:46:20 +0200	[thread overview]
Message-ID: <87vajw47cz.fsf@gnu.org> (raw)
In-Reply-To: <20171002204848.23646-5-fx@gnu.org> (Dave Love's message of "Mon, 2 Oct 2017 21:48:47 +0100")

Dave Love <fx@gnu.org> skribis:

> * gnu/packages/patches/libunwind-known_test_failure_to_XFAIL_TESTS.patch:
> New file.
> * gnu/packages/patches/libunwind-ppc_lib64.patch: New file.
> * gnu/packages/libunwind.scm (libunwind)[source]: Use them.
> (libunwind)(native-inputs): Add autotools.
> (libunwind)(arguments): Enable tests; run autoreconf.
> * gnu/local.mk: Update dependencies.

[...]

> +++ b/gnu/packages/patches/libunwind-known_test_failure_to_XFAIL_TESTS.patch
> @@ -0,0 +1,11 @@
> +--- libunwind-1.2.1/tests/Makefile.am~	1970-01-01 01:00:00.000000000 +0100
> ++++ libunwind-1.2.1/tests/Makefile.am	2017-09-06 13:32:52.331888031 +0100
> +@@ -97,7 +97,7 @@
> + XFAIL_TESTS =
> + 
> + if !ARCH_IA64
> +-XFAIL_TESTS += Gtest-dyn1 Ltest-dyn1
> ++XFAIL_TESTS += Gtest-dyn1 Ltest-dyn1 test-ptrace
> + endif
> + 
> + # Use if arch defines but does not support PTRACE_SINGLESTEP
> diff --git a/gnu/packages/patches/libunwind-ppc_lib64.patch b/gnu/packages/patches/libunwind-ppc_lib64.patch
> new file mode 100644
> index 000000000..9ab0108ae
> --- /dev/null
> +++ b/gnu/packages/patches/libunwind-ppc_lib64.patch
> @@ -0,0 +1,17 @@
> +Index: pkg-libunwind/configure.ac
> +===================================================================
> +--- pkg-libunwind.orig/configure.ac	2014-05-07 15:13:28.247711669 +0900
> ++++ pkg-libunwind/configure.ac	2014-05-07 15:14:25.924958386 +0900
> +@@ -164,12 +164,6 @@
> + AM_CONDITIONAL(USE_DWARF, [test x$use_dwarf = xyes])
> + AC_MSG_RESULT([$use_dwarf])
> + 
> +-if test x$target_arch = xppc64; then
> +-        libdir='${exec_prefix}/lib64'
> +-        AC_MSG_NOTICE([PowerPC64 detected, lib will be installed ${libdir}]);
> +-        AC_SUBST([libdir])
> +-fi

Could you avoid this patch and instead use ‘substitute*’ on ‘configure’
and ‘tests/Makefile.in’ such that we don’t need the extra dependency on
the autotools?

Please make sure to add a comment explaining why we’re doing this (the
Makefile.am bit is not obvious to me.)

TIA!

Ludo’.

  reply	other threads:[~2017-10-03 14:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-02 20:48 [bug#28673] [PATCH 1/6] gnu: Add papi Dave Love
2017-10-02 20:48 ` [bug#28673] [PATCH 2/6] gnu: Add otf2 Dave Love
2017-10-03 14:09   ` Ludovic Courtès
2017-10-02 20:48 ` [bug#28673] [PATCH 3/6] gnu: Add cube Dave Love
2017-10-03 14:44   ` Ludovic Courtès
2017-10-02 20:48 ` [bug#28673] [PATCH 4/6] gnu: Add opari2 Dave Love
2017-10-03 14:13   ` Ludovic Courtès
2017-10-02 20:48 ` [bug#28673] [PATCH 5/6] gnu: libunwind: Merge update and test changes Dave Love
2017-10-03 14:46   ` Ludovic Courtès [this message]
2017-11-16  9:47     ` bug#28673: " Ludovic Courtès
2017-10-02 20:48 ` [bug#28673] [PATCH 6/6] gnu: Add scorep-openmpi Dave Love
2017-10-03 15:07   ` Ludovic Courtès
2017-10-03 13:43 ` [bug#28673] [PATCH 1/6] gnu: Add papi Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vajw47cz.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=28673@debbugs.gnu.org \
    --cc=fx@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).